From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B161ECAAD3 for ; Sat, 17 Sep 2022 05:39:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B4EB8D0002; Sat, 17 Sep 2022 01:39:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 764D78D0001; Sat, 17 Sep 2022 01:39:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C728D0002; Sat, 17 Sep 2022 01:39:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50B8B8D0001 for ; Sat, 17 Sep 2022 01:39:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1F0C41A0581 for ; Sat, 17 Sep 2022 05:39:40 +0000 (UTC) X-FDA: 79920475320.21.A207693 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf15.hostedemail.com (Postfix) with ESMTP id C8CA9A00A6 for ; Sat, 17 Sep 2022 05:39:39 +0000 (UTC) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-3452214cec6so282711267b3.1 for ; Fri, 16 Sep 2022 22:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=jtchFBzH++GNnoEIjx4Ntdk5N32UzL43DOyjEpT0F40=; b=dJxoQglJeLOCooo0FT4B+QraWQ1bXsy25QL/vTl84rT1Gni03SmGjzePHDWpT4fM8K ErqVf8DevI7SYHzNgpwnX6iZPijhshFz2z5NDNTPTRoqB0anBfoW/svWx1XzMMCHSe4o iTggvuOqeiN4NmseghWJMkvm5hcqNMgOUsrU0q6Gr0A6aACjELxbVowgrZfcXRB/vtjh L7HVIXt5XVZxYMoq4NCoXjwIv0sCfImJg39GYIhO/8/mpAjyTaEHCnCIGGWHxsJpT+3Z U3Zl/T6WZH8ZbavoF0LxOD+27l1x5cbR7aDIFgb61MiQ+YQptj1YF0VM5oqgUjIAp39+ 0V2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=jtchFBzH++GNnoEIjx4Ntdk5N32UzL43DOyjEpT0F40=; b=ldse4vNNeD701C/B+3wAET7WPCHJ5iyL1qtg4oY9RqfqgwtbE2kQE2MdC0keXPdCPA rCHZ1Ft7eHkfeaDv2EeFGJ5A6LqdTmZuvRzkQcdjHpXNlcByPMKyzt/6umF62y+koG18 eytKJ4HE+sryv4BjNBT6wIKVjrTKLbLwLDO1xLu0BP3bamHYazzYKzM1fA7bOS4KjnMj bfsTqrbn75f1/wVDuVfgKJtc482ZoKgmn1YPDlvp7TsVsO0GZPSXVDRc8SefpExJuiKK jiSuJuhUoZ72EC+meNFtp3HOrH2lxVlwHmUsfBVqGKCeoQkgQipwYwMdY4Mv5qgsbf64 8vnA== X-Gm-Message-State: ACrzQf0/I1at6k1LGuGWTxANE+riP5g3Xz0TiFqDwfihzsTFsRNPZrLJ Nyg9h+PcRI+FZqcN64QDMBxkIYZvBZIvL6oB/DE= X-Google-Smtp-Source: AMsMyM6DmOxto5DLfQbbd3bh0eCeqHW2bVoVaCR+dUroG7Bnno9/axoOfGN+QI8A5K+MHF1/+jmm/GMIrhHLv10Mx+M= X-Received: by 2002:a0d:e6cf:0:b0:349:ef2b:1940 with SMTP id p198-20020a0de6cf000000b00349ef2b1940mr7052010ywe.331.1663393179003; Fri, 16 Sep 2022 22:39:39 -0700 (PDT) MIME-Version: 1.0 References: <20220915085757.258608-1-zhaogongyi@huawei.com> <20220915085757.258608-2-zhaogongyi@huawei.com> In-Reply-To: <20220915085757.258608-2-zhaogongyi@huawei.com> From: Akinobu Mita Date: Sat, 17 Sep 2022 14:39:27 +0900 Message-ID: Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values To: Zhao Gongyi Cc: linux-doc@vger.kernel.org, LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Jonathan Corbet , david@redhat.com, osalvador@suse.de, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dJxoQglJ; spf=pass (imf15.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663393179; a=rsa-sha256; cv=none; b=lviLG2t+uJwGdN14Q7UiJIqzkMr7kfnZlL9ravFIfcCMG6xQzQijw0MxXDiHeG1HFmDtay dNcU+ep1Adrr3+UKUX0RQ+SjJw+jggCaZafvW5PutLbAX31TM9JyfDGBajGHqCYLpmW/Lz A7OeAlNix6IWRgzJFx2qwiEFJw17jRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663393179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jtchFBzH++GNnoEIjx4Ntdk5N32UzL43DOyjEpT0F40=; b=0HscUBEzW96YhC5tfYzFnQ+X8ME8KIcaac//00GCW+XdtiqfqRmIHzKkuPL0sERremZEcm Fn7e18SBT5dbNfW37UO/JkICIJy4387VsN2+TeK0hUoreETWxWCeoTUgE8H6Qm6kHrrP8f HT5YlhfNmjtQobm/rn9LzYjVKe0nWEU= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dJxoQglJ; spf=pass (imf15.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: mxt7fxt8rtinj7sq9dim4mkncom7ekxa X-Rspamd-Queue-Id: C8CA9A00A6 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1663393179-101287 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2022=E5=B9=B49=E6=9C=8815=E6=97=A5(=E6=9C=A8) 18:01 Zhao Gongyi : > > Fault injection uses debugfs in a way that the provided values via > sysfs are interpreted as u64. Providing negative numbers results in > an error: > > # cd sys/kernel/debug/notifier-error-inject/memory > # echo -12 > actions/MEM_GOING_ONLINE/error > -bash: echo: write error: Invalid argument > > Update the docs and examples to use "printf %#x " in these cases. I'd rather fix the notifier-error-inject module than change the user interf= ace. I'll send a patch, so could you check if that solves the problem.