From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C22C54EE9 for ; Mon, 19 Sep 2022 11:40:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB1E4940008; Mon, 19 Sep 2022 07:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B60CA940007; Mon, 19 Sep 2022 07:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A290F940008; Mon, 19 Sep 2022 07:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 92572940007 for ; Mon, 19 Sep 2022 07:40:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5C56016093E for ; Mon, 19 Sep 2022 11:40:51 +0000 (UTC) X-FDA: 79928643102.16.D28A324 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 0663A14000F for ; Mon, 19 Sep 2022 11:40:50 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id c9so42038635ybf.5 for ; Mon, 19 Sep 2022 04:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=99zbpHyljYgorKF920Y7sKiR42NQt8fjAj417BqAEvM=; b=B9YfLnYqiSoPPoQXpq9fMjhAnUNXVLaypeVd33fU7AzcEi7beWb1nDqIheJCZ0D9Bo 851PwQhks1dvH9DHcYEZi6d9Jy6bhe+8ELmEBzUe1KpjHUNRK6ZJ/ZL5uxSBoRc5YzU5 6X4LrUlaug4JFSGW8RIUBn8Ffyp+7TyKkH4E78EcaGnsFRznqGdFJojxk/G0lZFUpvqq ctGiFaYlpPUngHdZ0xlITcXJQDQkfZB1CH//gDHJKsSbu03IO2Q6Gl1BjHaUPjRQrmco nsFpZnwjy/X034T6aUiPGOtEp/O1H2Ifm+EQNe7q/5v6Q5L4iISnBs/WZgMh7qWHhm3A tRug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=99zbpHyljYgorKF920Y7sKiR42NQt8fjAj417BqAEvM=; b=OKwN9qD2JSNsKkjDErBLWSYkOLfv8FiNzph+xgh2nr+A5uQ5jdsQthrMBbjp67iTsB Oa8VrG4ucxWcYUptmUNo8Cl/1RGbyImdB4kxe3dugkKGO1zqIw03vpeBph5sBr4rr0hK V2Gk7DLWsU1r8Gjqc2lGU/qZ2zvhLkVI5Lye7/ZzmQB6/ypsR4B43KXyNlQq62XAlMiC NDJVwjhDBlc7n4kgGy7/uKhpWN5Pwld2j91Xrezjes/1ghNEf+bHn5McUegJJ+Lk8n7U wrVhAf9Um29eJI6ljIyCUe2b2KSrnoEpIJOaP0+zuLx8l5CpQBRG0NHZk82mLQaW0zBK eDhg== X-Gm-Message-State: ACrzQf1oYmTKOgJMkD0L0gjQZrzYPD/qEZ6HrYyqlNl3CNb7Z4FjL5HT KDvpsGzTgkMMFx0+QyqkO8egHS79GV8n6R4u/tI= X-Google-Smtp-Source: AMsMyM5TdD4vl/dOOkzUqbZdwVEK/mnJxlfCKc3Bik1j5Kp9r99vkYfgD0J1ICbJ+yjVv/CCrpb97bj8pqhiRoXr1FE= X-Received: by 2002:a5b:107:0:b0:67c:4077:17f0 with SMTP id 7-20020a5b0107000000b0067c407717f0mr13252085ybx.363.1663587650140; Mon, 19 Sep 2022 04:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220917071427.28499-1-akinobu.mita@gmail.com> <93c044ca-7d2f-e23f-8eb4-72c133737a15@redhat.com> In-Reply-To: <93c044ca-7d2f-e23f-8eb4-72c133737a15@redhat.com> From: Akinobu Mita Date: Mon, 19 Sep 2022 20:40:38 +0900 Message-ID: Subject: Re: [PATCH -v2] lib/notifier-error-inject: fix error when writing errno to debugfs file To: David Hildenbrand Cc: linux-doc@vger.kernel.org, LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Jonathan Corbet , osalvador@suse.de, shuah@kernel.org, Zhao Gongyi , Wei Yongjun , Yicong Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663587651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=99zbpHyljYgorKF920Y7sKiR42NQt8fjAj417BqAEvM=; b=lpLCDq6I0dQqPBgHG+5pwHqdz+G/UaK9yf7jh8lNMtivWCbs7ReATFGuGaWyNT615b/pf5 37P2KnJUhV+QNSN43EeQIpkBH6uik3qPyRxEmQ+hrQlAWE4dcV8fIgun1VbawoRT/EbOQ8 9HPafbwm5QA1RXM5HbkzCW4K7PCCLpU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B9YfLnYq; spf=pass (imf26.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663587651; a=rsa-sha256; cv=none; b=DCQLR43JKXXlHe8K7CVA05kF5Fdebtjm4cQYu9T7l7lKR4y2JhBdHXpyRw/SQAkioGMorX 912mc2iIsY/4vHp0ZY3h4qtAQcqBuagY2NrjQ+rkMG9NuzArRtRl+/2+cnhjQQKST0YKbI KbBgZPr12w9IkoTFISX8Is5+1kKYv2Y= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0663A14000F X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B9YfLnYq; spf=pass (imf26.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: a4k5eyxawwyn8hrh3c1rnzfkbikys87n X-HE-Tag: 1663587650-675525 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2022=E5=B9=B49=E6=9C=8819=E6=97=A5(=E6=9C=88) 18:20 David Hildenbrand : > > On 17.09.22 09:14, Akinobu Mita wrote: > > The simple attribute files do not accept a negative value since the > > commit 488dac0c9237 ("libfs: fix error cast of negative value in > > simple_attr_write()"), so we can no longer use DEFINE_SIMPLE_ATTRIBUTE(= ) to > > define a file operations for errno value. > > > > Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple= _attr_write()") > > Reported-by: Zhao Gongyi > > Signed-off-by: Akinobu Mita > > But shouldn't we fix simple_attr_write() instead? > > I mean, simple_attr_read() might use attr->fmt to print a signed value, > but simple_attr_write() fails on signed values now? > > I might be wrong, but there is a disconnect. I feel like > simple_attr_write() should similarly make decisions based on attr->fmt. I agree there is a disconnect, but I have no idea how to fix simple_attr_write(). (strcmp(attr->fmt, "%%lld\n") is ugly) If no one seems to come up with a good idea, I'll fix the similar problems in fault-injection the same way I did here.