From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43680C433DB for ; Mon, 21 Dec 2020 01:53:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4C8522D6D for ; Mon, 21 Dec 2020 01:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C8522D6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0CC2C6B005C; Sun, 20 Dec 2020 20:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07D4C6B005D; Sun, 20 Dec 2020 20:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4146B0068; Sun, 20 Dec 2020 20:53:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id D85F86B005C for ; Sun, 20 Dec 2020 20:53:57 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 974218249980 for ; Mon, 21 Dec 2020 01:53:57 +0000 (UTC) X-FDA: 77615618514.23.lake31_05145ab27453 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 6E79537606 for ; Mon, 21 Dec 2020 01:53:57 +0000 (UTC) X-HE-Tag: lake31_05145ab27453 X-Filterd-Recvd-Size: 3821 Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 01:53:56 +0000 (UTC) Received: by mail-vs1-f51.google.com with SMTP id p7so4550847vsf.8 for ; Sun, 20 Dec 2020 17:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JK7GPELnfYfTU31E5sBOxTPyNSRDBZKEGXh3/pdYXF8=; b=fJGVqT1vMsWrs9wn+FpeBeQUqvE/KtwgFUiXvMPHFenUx/AJnhoGMxn7YGsLzJZaTG F7Wsn2Tqhq3uqY/MISUiFX7rFiJpifYFil1jM9u1aPHTYTvPflTZc6wDtzV9pSqgrUpO ZfJLqknHuAN5c7V+Uif3tnDbLW36slpd8IUnu6Ml8SQQqtsl3KC4Gir8k5rW5oelixf7 mIongcsNCmisp4Bj/EsSy7Md3F3PS8mQfTOjK5hfGKSs0BQesT3FAxkB0kyEJkGBHisS m1mpN4CrguIz1U1QHA6/SNVBvbd+UYnJvfKdN0gW76fiDisRZt5I6DIbUWQrczLryMoA z2qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JK7GPELnfYfTU31E5sBOxTPyNSRDBZKEGXh3/pdYXF8=; b=ivce6jsbW8YxUvkPFXTuJnnQGi16ZqHGpFnmVVT3STRyiEtkeio805yaw9zO+KLhuZ J1YwjHTIEsyRpH4BFScWgaw1oKMiCIIjEpfwEvl24yTjGOKFtwngFcqFQpB7cFNJ2h9J LAnsoNow/J8qqakrBmUkCpXI4LCVD0ZRlD6X6rMqlqoyemoniwJD+hs/Kw5bPLoGsOif H5bJt8m1IDLRlNWtXkxquxXfi/bId0lRPAeZ47/RcfLcqWjc/WNnyty/9AQ3YdYfaGbN uTihaMHREIPc4+UCaW6U8XB7FaS0ZZNFu4RQBJPeCdn1xSxJwhOKcBtfHo3ra7av3lDd GA3g== X-Gm-Message-State: AOAM533V5d9uEa1Cw1IB0MJ3myRWOqnIpmDQUAeWx6N4Eid+4t9YGml6 vljHBkAybH7gUQdG1+PocU0sVEJwRnAWOyWuObE= X-Google-Smtp-Source: ABdhPJzEW9fJyir2xUPBOg//vyJRSn7cMWLp6rS2pbLzFg/XmxFdQpLz3X3HX2iaLfehkPWtK+6sB0iCtxo0Bj8j3so= X-Received: by 2002:a05:6102:666:: with SMTP id z6mr11507327vsf.46.1608515636460; Sun, 20 Dec 2020 17:53:56 -0800 (PST) MIME-Version: 1.0 References: <20201220050340.849754-1-npiggin@gmail.com> In-Reply-To: <20201220050340.849754-1-npiggin@gmail.com> From: huang ying Date: Mon, 21 Dec 2020 09:53:45 +0800 Message-ID: Subject: Re: [PATCH 1/3] mm: prefix page_cpupid_reset_last as non-atomic To: Nicholas Piggin Cc: linux-mm@kvack.org, Peter Zijlstra , Huang Ying Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Nicholas, On Sun, Dec 20, 2020 at 1:03 PM Nicholas Piggin wrote: > > Add a __ prefix to indicate that it should be used in non-atomic > situations (where the page is not subject to concurrent flags > access, following the pattern of the other page flags modifications). > > This prepares for an atomic version. > > Signed-off-by: Nicholas Piggin > --- > include/linux/mm.h | 6 +++--- > mm/page_alloc.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 855161080f18..5b3fc2c8fd8b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1358,7 +1358,7 @@ static inline int page_cpupid_last(struct page *page) > { > return page->_last_cpupid; > } > -static inline void page_cpupid_reset_last(struct page *page) > +static inline void __page_cpupid_reset_last(struct page *page) > { > page->_last_cpupid = -1 & LAST_CPUPID_MASK; How about replace all these -1 & LAST_CPUPID_MASK and (1 << LAST_CPUPID_SHIFT) - 1) with LAST_CPUPID_MASK I think that can improve the code readability a little. Best Regards, Huang, Ying