From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21BAC10DCE for ; Thu, 12 Mar 2020 07:55:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65350206B7 for ; Thu, 12 Mar 2020 07:55:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NYpb5ale" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65350206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD7FB6B0003; Thu, 12 Mar 2020 03:55:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88906B0006; Thu, 12 Mar 2020 03:55:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99DAA6B0007; Thu, 12 Mar 2020 03:55:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 7F13B6B0003 for ; Thu, 12 Mar 2020 03:55:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 15E638248047 for ; Thu, 12 Mar 2020 07:55:52 +0000 (UTC) X-FDA: 76585951344.28.sign02_6d65fe60eb423 X-HE-Tag: sign02_6d65fe60eb423 X-Filterd-Recvd-Size: 4493 Received: from mail-yw1-f65.google.com (mail-yw1-f65.google.com [209.85.161.65]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 07:55:51 +0000 (UTC) Received: by mail-yw1-f65.google.com with SMTP id d206so4677330ywa.12 for ; Thu, 12 Mar 2020 00:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y8PH8OwRLD6nQXDDi9y8VIf66Uz6y/cjwU3hUU4CHeQ=; b=NYpb5alec01RBygunaSyIwAvzoDgMhxcnYOM5Z0iWhI6ke8QJJuGbFWLgFtCkzOhSo GmBEWrvQPIhOxjn7HuZ7k5vG73LaHkos049KQPV5cc2hFNRvbijKNH9UqIw+VgasE4xn 3u7y7elTcNfK1JzMXRbdFDFnqbOxqmLRe+0rUE5mK/coiDm/Xdd+K3y7vJXqETfNaKUl I7SRSFAGlpKQOP6enB7qLsjfHZagaBg0kGG8KnhuK9p/9Obksy8WCavX1brmWM52OIno Zyuu7bat/tQDr2/OE3y96UhIQ7QPveDoq0k2IxJJU4ACBvdTqQ5KLP5bueYl/O1MeTvH Bw2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y8PH8OwRLD6nQXDDi9y8VIf66Uz6y/cjwU3hUU4CHeQ=; b=bSPmTNcxxnwIku8mm3JghAlPX54HFf39W60hqJGM2s/PHaixqfm67y2UMooHvY0OOl r2DKJXMPQ0XHTloMY5907i4FvmH838yicL9YhYg0ZlwXwISaWR1HIkyZQbFdtP1qZlLQ U7tBZoxWDlayf3658GOvXbPjlkoTJ+ofvMw8Xjkb2CCTkAX/scLdYyZ4MOW9XfLVBpad lePoLSAs+NepU7vZvdtm3aFwgcduiYfj1MCSmgugZopcEeX3NMWJnOIN++OgXIE7w6cE UwWpSibTlbcsFdu8Q5M91/ljUj7M1IDuxCqS1rNjXL4ekwzn7pJWJyZ6AuRBEvafplim vLYQ== X-Gm-Message-State: ANhLgQ3QU3PoBygByV/OkKUulZpLB2Qcq8ZBOWYPf3MmyFzzUblsIUTk Sg0zQ4gTPN8pUmqQ/9HzhjHAplGOFB6mok7gvwo= X-Google-Smtp-Source: ADFU+vts+xJgjvsNggC0oJn6T/AhhA6fIzZAK7IOhIRQgnxsxYNXe7MXAD02qS1EHhqhreTigQi0w6OWbvY0Klo8cyc= X-Received: by 2002:a25:ace2:: with SMTP id x34mr7802951ybd.83.1583999750963; Thu, 12 Mar 2020 00:55:50 -0700 (PDT) MIME-Version: 1.0 References: <20200304001339.8248-1-rcampbell@nvidia.com> <20200304001339.8248-2-rcampbell@nvidia.com> In-Reply-To: <20200304001339.8248-2-rcampbell@nvidia.com> From: Ben Skeggs Date: Thu, 12 Mar 2020 17:55:39 +1000 Message-ID: Subject: Re: [Nouveau] [PATCH v3 1/4] nouveau/hmm: fix vma range check for migration To: Ralph Campbell Cc: ML dri-devel , linux-rdma@vger.kernel.org, linux-mm@kvack.org, LKML , ML nouveau , Jason Gunthorpe , Ben Skeggs , Andrew Morton , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I've taken all 4 patches in my tree. Thanks Ralph, Ben. On Wed, 4 Mar 2020 at 10:14, Ralph Campbell wrote: > > find_vma_intersection(mm, start, end) only guarantees that end is greater > than or equal to vma->vm_start but doesn't guarantee that start is > greater than or equal to vma->vm_start. The calculation for the > intersecting range in nouveau_svmm_bind() isn't accounting for this and > can call migrate_vma_setup() with a starting address less than > vma->vm_start. This results in migrate_vma_setup() returning -EINVAL for > the range instead of nouveau skipping that part of the range and migrating > the rest. > > Signed-off-by: Ralph Campbell > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c > index df9bf1fd1bc0..169320409286 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_svm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c > @@ -179,6 +179,7 @@ nouveau_svmm_bind(struct drm_device *dev, void *data, > if (!vma) > break; > > + addr = max(addr, vma->vm_start); > next = min(vma->vm_end, end); > /* This is a best effort so we ignore errors */ > nouveau_dmem_migrate_vma(cli->drm, vma, addr, next); > -- > 2.20.1 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau