From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E676EC43460 for ; Thu, 8 Apr 2021 12:50:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59EE861106 for ; Thu, 8 Apr 2021 12:50:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59EE861106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E2856B0072; Thu, 8 Apr 2021 08:50:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9926B6B0078; Thu, 8 Apr 2021 08:50:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80C006B0080; Thu, 8 Apr 2021 08:50:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 605056B0072 for ; Thu, 8 Apr 2021 08:50:06 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 20FF55DDC for ; Thu, 8 Apr 2021 12:50:06 +0000 (UTC) X-FDA: 78009182412.14.CCF29B0 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf29.hostedemail.com (Postfix) with ESMTP id 23FB9EF for ; Thu, 8 Apr 2021 12:50:03 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id a1so2130379ljp.2 for ; Thu, 08 Apr 2021 05:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ue62b/nOsWagddlxWSHgZE+xJ7jpEp33uT3hApzk61s=; b=vvSgQJ10J71/hJsIWwLP3XbsOekOzbhwMvBACn4AWfAGleRLrUNzHNNK5uzeLyioMB oXIl0KjQfY0cc+zIdEytIHzN42/OjUgsVSyQzPNF7LHyemG4aoQzWGjp1kQcgyP994UF PBZBxmSiF5r5UO7u4g9kPbjUHVxyNNgYMU5Knd5mi7CHQ+mjXkXFxyyxdoyhMqiKcHh7 KD6xoCCNSIaQ7e7UvoyagNDB6CPkDalEXBqyL+CK5Z+carCsx1vQWABrVJ+/Y/1Z2juI 00Ab6erVT5dMmK0+1wheunsMvAYIodPt4qdrCvcG+ZzapbmUF0rbOlXfcBEE0hLDekJq R2NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ue62b/nOsWagddlxWSHgZE+xJ7jpEp33uT3hApzk61s=; b=EYtTs0/wHW26+d+jcqLHNdFJTPXmALxk4iYaD+EUD+bcL22CFwTnFPxuRQQ9RM6LJv uI6f+zk7nexUZoLU8G5Q3laTv5b3MXBYNlCikI4/H1ubDHcK1DJqogzrPdDwDSlOZn0a IuH44Hg44dMckhPk8mQQnrt16Fihd+dUVL9EyIAxzyPiDZgQOCkcL7R/S6MvMyz8KMTY MLkSf+jWBp+fgfXCmIe+OBLvQN5C81U6aLsjZF5/I7KfwhY4Ql9tdn2RbFNPClZ23xNA tWYKZ8ed+qAkXXza1qsoJjGEs5wvAtS6qGEEFO7SyZSIuYMsjfFDptc+kNIG56uWJ/sr aqGQ== X-Gm-Message-State: AOAM530lg78HrhlXbfx32hgfxGqErWkGFuIIsOPO02P0JQj7SeqmMRMa D39/ktvJjvwiuwtOdsiJ1+aQHda9HcRED9WlL2J4Wg== X-Google-Smtp-Source: ABdhPJzHwP6BmbIRqU1HYc3FQkCjshHvviqMY3IIos9nhT5ENCEad5QCJ7O5xWMp2CMbQh00KOeiYn4d7d9pP/p57KM= X-Received: by 2002:a2e:7001:: with SMTP id l1mr5550860ljc.200.1617886202537; Thu, 08 Apr 2021 05:50:02 -0700 (PDT) MIME-Version: 1.0 References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> In-Reply-To: <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> From: Linus Walleij Date: Thu, 8 Apr 2021 14:49:51 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: David Hildenbrand Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 23FB9EF X-Stat-Signature: q1kukpk65cwuyiie3zwszwca5nwbgg61 Received-SPF: none (linaro.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-lj1-f182.google.com; client-ip=209.85.208.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617886203-197420 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > > This is something you could do using a hidden helper symbol like > > > > config DRMA_ASPEED_GFX > > bool "Aspeed display driver" > > select DRM_WANT_CMA > > > > config DRM_WANT_CMA > > bool > > help > > Select this from any driver that benefits from CMA being enabled > > > > config DMA_CMA > > bool "Use CMA helpers for DRM" > > default DRM_WANT_CMA > > > > Arnd > > > > That's precisely what I had first, with an additional "WANT_CMA" -- but > looking at the number of such existing options (I was able to spot 1 !) If you do this it probably makes sense to fix a few other drivers Kconfig in the process. It's not just a problem with your driver. "my" drivers: drivers/gpu/drm/mcde/Kconfig drivers/gpu/drm/pl111/Kconfig drivers/gpu/drm/tve200/Kconfig certainly needs this as well, and pretty much anything that is selecting DRM_KMS_CMA_HELPER or DRM_GEM_CMA_HELPER "wants" DMA_CMA. Yours, Linus Walleij