From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5F5C5DF9D for ; Tue, 3 Nov 2020 00:17:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B03E52231B for ; Tue, 3 Nov 2020 00:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w2GT/Dui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B03E52231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 395B86B0068; Mon, 2 Nov 2020 19:17:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E366B006C; Mon, 2 Nov 2020 19:17:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20F3B6B006E; Mon, 2 Nov 2020 19:17:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id DDEAF6B0068 for ; Mon, 2 Nov 2020 19:17:48 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7D05E181AC9CB for ; Tue, 3 Nov 2020 00:17:48 +0000 (UTC) X-FDA: 77441193816.12.board43_02179b8272b4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 53F7818015332 for ; Tue, 3 Nov 2020 00:17:48 +0000 (UTC) X-HE-Tag: board43_02179b8272b4 X-Filterd-Recvd-Size: 3595 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 00:17:47 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id l28so19793331lfp.10 for ; Mon, 02 Nov 2020 16:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/CEavdvMM7dMfX8P02tid+B2Vle313TCm3ZWxhN4jhM=; b=w2GT/Dui08tjsJtLWEqwgy9q6BzzAyknfTXVSF5tLeQb/VvI2VsSFZhT6tv6MTFSL1 dqNpcYxEcZZiuav4HEbKNfEn9FEb635Z7IguJRgETcIGjUkOySVkN8nRJspOupL3NMF5 ZDrhm33G41kqnbtc6/m9fqNV1haL97tLfbSE7BrJzPWlSUnEzhuDM7vizYjT0eqajl46 ZC+UI5RtYoBT1j2dj8pcYV1n6qCI4REpcCMi7eyG8sinQOOZpqhb3su6rVMbTLuEoNmH bCrAB4H3kdcDKVqUR4HenrVCaV5tq73NZJq2MJBCHMnLAqfYIJizUs6sYj87B2igdEaJ 8lDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/CEavdvMM7dMfX8P02tid+B2Vle313TCm3ZWxhN4jhM=; b=nqqAxUVqsfELBjzjbm6iDkuhXeAFP8HEhTdmWu+7afUV/3fLNjNRXxUxGONEfzf4xB NSo38rrS7ucmihLz7peZILv25CqktrX7+zObz60BpW38kJTm7kZgxw3C1i1yPh5rt2SO 9qlYw5HLsYQ6X6loAdCGFSJybfuXUbdyFZm/O9w62hmADwf+swXrxGsigi00oEs1Ia5z V+SI8RUfX98XePWPpFbrRV/j745GOhc3hj0RBI/+LtiaA6xhAoK7pLQTqsO2EuMDKpEe XHOFxGMkNbLzzVtR9H2GFuDC9yiFidl7xOWC4u51cy5+HQ4LJpsQK/vw/FmwW3AZba0B aEdg== X-Gm-Message-State: AOAM53364ux10eQIv0tiKnxIBvJPYIGeJXtFnFCp7VOYIO5a0lTjN2de j2KplGu6iLpSgTsnNZTV/PU7v/+U1BsFWDA+W+h+kQ== X-Google-Smtp-Source: ABdhPJwZnshymJxSzG7hBjsl32UmhE6ZNfcjboeKGV/KrvSdmPZp2ViN4zKDzSvBcrgXWbeS6WpUClVjSrKcW8n5cdk= X-Received: by 2002:a19:c8c6:: with SMTP id y189mr339819lff.502.1604362666121; Mon, 02 Nov 2020 16:17:46 -0800 (PST) MIME-Version: 1.0 References: <202011020749.5XQ3Hfzc-lkp@intel.com> In-Reply-To: <202011020749.5XQ3Hfzc-lkp@intel.com> From: Linus Walleij Date: Tue, 3 Nov 2020 01:17:35 +0100 Message-ID: Subject: Re: [linux-next:master 1570/2472] mm/kasan/init.c:318:9: warning: variable 'pud' set but not used To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Russell King , Ard Biesheuvel , Abbott Liu , Florian Fainelli , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 2, 2020 at 12:32 AM kernel test robot wrote: > mm/kasan/init.c: In function 'kasan_free_pud': > >> mm/kasan/init.c:318:9: warning: variable 'pud' set but not used [-Wunused-but-set-variable] > 318 | pud_t *pud; > | ^~~ So this is because arch/arm/include/asm/pgtable-2level.h has: #define pud_none(pud) (0) because of the way that PMDs are folded into the PUD. (See the comment in the file.) This is not liked by KASan because it looks like the pud variable is unused. Any suggestions? Should it be: #define pud_none(pud) (!pud_val(pud)) Like most other archs? I also toyed with just putting __maybe_unused into the kasan init. Any other ways to solve this? Yours, Linus Walleij