From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC95C3F2D2 for ; Fri, 28 Feb 2020 17:23:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 308D524699 for ; Fri, 28 Feb 2020 17:23:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oehpK1n0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 308D524699 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B15076B0005; Fri, 28 Feb 2020 12:23:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3836B0006; Fri, 28 Feb 2020 12:23:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA4B6B0007; Fri, 28 Feb 2020 12:23:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 8684F6B0005 for ; Fri, 28 Feb 2020 12:23:27 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5643440C0 for ; Fri, 28 Feb 2020 17:23:27 +0000 (UTC) X-FDA: 76540207254.20.rub42_58571c29fe728 X-HE-Tag: rub42_58571c29fe728 X-Filterd-Recvd-Size: 4418 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 17:23:26 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id a5so4028168wmb.0 for ; Fri, 28 Feb 2020 09:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=To96rXV6IlbyYDvdE4LwzTEZNpGCDgaSmssNkvOgMDA=; b=oehpK1n0ccDU8aof9+AU+lJlCqUQrri1zNSrg/KLjt0qBcm/7zkxOShQTf+7lEHU2A daxoYYNhFyXNZjInJqtmSY522guET2fEY5Ilx1FTzBtKiBhETeGCJouEISwxJ3pm8+lB qyndU6x5FM48Rsp8J8o2UaFdKmaNgZALBoy/rJqeAVUIeEsTdgKM0DBQknriSV2NB73R /80WAslkWNceoKS9dWrGP9vs2rkwwAswaN/P+zlO9cl4o5C4NS12vZTYgiCwFx71W7H0 MmyvydLnm3cwKlMMVJBJf+mwuYvolPN/I31cvYFSS+gnZqV19tQvHb1dVDBhZ2B2Co6f KOgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=To96rXV6IlbyYDvdE4LwzTEZNpGCDgaSmssNkvOgMDA=; b=BJewzvkeEkfe9dDXHvWMNQyglNkOfAjEVmEjSpRsPqz9Qkiux+kVtYZ/3voH3xmuZ8 7OC4HJbtknnmQfDH9D2BgXEJRoxxeW7uuvjXgA97PDHQxzSB8PSsLMr94zSVDvkQdx2b B5sdua5Fbxz9Cw22cQSaHfc54YVRg/tpEsXeGtWas6lKMZvDm/RVvcPCTbfeross7xpj OeUrAP3cx+VdeoPDrRI6rXxHyARD6C/KhMpCopG9fJa3vzx+DyHJt9/muE7JiiNXsnpY Gpres/nPDNh8DU+VMV+24+W3js7JaJVUILYHbLSSszO6VmeNDZ24Ap7phMnNngzAvnlb rlEw== X-Gm-Message-State: APjAAAU5IgSiqXkT99y8Cvnhg0bb+8qsvggpWR4oQLPmBIceOSYMRuAz weOax4Vap0l6PxlnWRS3d5B680PPt9o6LjqC/Si81w== X-Google-Smtp-Source: APXvYqxIybFZkIUG5KXG/nlo2qXDdXuACBJtH7Qxix99qPeH/5riUxib+hX2beEs2eaz7SC+o3Dv+/8O1/ptgclsIrs= X-Received: by 2002:a1c:e146:: with SMTP id y67mr5535300wmg.81.1582910605178; Fri, 28 Feb 2020 09:23:25 -0800 (PST) MIME-Version: 1.0 References: <20200228054714.204424-1-arjunroy.kdev@gmail.com> <20200228054714.204424-2-arjunroy.kdev@gmail.com> <20200228133803.GO31668@ziepe.ca> In-Reply-To: <20200228133803.GO31668@ziepe.ca> From: Soheil Hassas Yeganeh Date: Fri, 28 Feb 2020 12:22:48 -0500 Message-ID: Subject: Re: [PATCH v3 mm 2/2] mm: vm_insert_pages() checks if pte_index defined. To: Jason Gunthorpe Cc: Arjun Roy , David Miller , akpm@linux-foundation.org, linux-mm , Arjun Roy , Eric Dumazet , Stephen Rothwell , geert@linux-m68k.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 28, 2020 at 8:38 AM Jason Gunthorpe wrote: > > On Thu, Feb 27, 2020 at 09:47:14PM -0800, Arjun Roy wrote: > > diff --git a/mm/memory.c b/mm/memory.c > > index d6f834f7d145..47b28fcc73c2 100644 > > +++ b/mm/memory.c > > @@ -1460,18 +1460,6 @@ static int insert_page_into_pte_locked(struct mm_struct *mm, pte_t *pte, > > return 0; > > } > > > > -static int insert_page_in_batch_locked(struct mm_struct *mm, pmd_t *pmd, > > - unsigned long addr, struct page *page, pgprot_t prot) > > -{ > > - int err; > > - > > - if (!page_count(page)) > > - return -EINVAL; > > - err = validate_page_before_insert(page); > > - return err ? err : insert_page_into_pte_locked( > > - mm, pte_offset_map(pmd, addr), addr, page, prot); > > -} > > - > > /* > > * This is the old fallback for page remapping. > > * > > @@ -1500,8 +1488,21 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, > > return retval; > > } > > > > +#ifdef pte_index > > It seems a bit weird like this, don't we usually do this kind of stuff > with some CONFIG_ARCH_HAS_XX thing? > > IMHO all arches should implement pte_index as the static inline, that > has been the general direction lately. Based on a comment from Stephen Rothwell, we found out that "static inline" functions are only used in tile and x86. That's why Arjun opted for this method to create a smaller patch-series to fix the build breakage. Thanks, Soheil > Jason