From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F400DC4363A for ; Wed, 28 Oct 2020 10:56:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 359E0246AA for ; Wed, 28 Oct 2020 10:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EchNxfjW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 359E0246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9758A6B005D; Wed, 28 Oct 2020 06:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 905B16B0062; Wed, 28 Oct 2020 06:56:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C89B6B0068; Wed, 28 Oct 2020 06:56:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 4B36A6B005D for ; Wed, 28 Oct 2020 06:56:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ED14D8249980 for ; Wed, 28 Oct 2020 10:56:09 +0000 (UTC) X-FDA: 77421029658.01.way17_2801aa827284 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id CE2E1100480B1 for ; Wed, 28 Oct 2020 10:56:09 +0000 (UTC) X-HE-Tag: way17_2801aa827284 X-Filterd-Recvd-Size: 6717 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 10:56:09 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id f93so3147237qtb.10 for ; Wed, 28 Oct 2020 03:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hsdkNzdMfWbXcZddXcT8aNBIhrkn1PkorkEU1qPCnjs=; b=EchNxfjWzAUq7C9Ti1qSHxWy2ojph/urHy60IprjNwVnnSHv7akwPxW+W2Gw79lVrr LBbC8gDgPCvGF57RQQ7Dilxntcq9QqyIP0hw2I5p0AViyp/dUDzvzA5xOrfpTbIi8+Qs 8Pv9zi0mH6SAJpljfdLeMgoLkyH3mGsakv8Kcc5zmt0yfZS1SpaQeUwLVrsH5fzsd3lK iYnLuOdfZavOXph0Z9SmP8/S8UV6MpNMXLcVwfU4LL/RUeKjJ9nav4TIpS8wHWRitI4c PUHVbQ/ww+WTSzqXxmoctill4YXA+t3xUpvV5z1XlFCEzqqmEpb3ZFVcqJbJBMMB3X83 nFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hsdkNzdMfWbXcZddXcT8aNBIhrkn1PkorkEU1qPCnjs=; b=iJWCAhMwuu3IuN1uc0Tv3h3F7t6WwnD5B5sa5T/wOEK2KXCL6bslZQQLBGtcqcaTc3 grouIVVgdmmMDbarf/iTn4MXjCjv3X6YVT3aYs4SSGDQhMlDQpac+WJKIq8voY2jspCz AMRMtQQfqxbdU6+YsECGI7p+LM/3oKl81I1VvkLp6oeftzjkLsYUF4SS7+FReE2Iljz1 0YpZu+SahLs00wCnTNotWSvkiZN5hgURnzlTuKG2Mx4k9p6ZCtH5XqRfgmFUWXWEj6G8 /iaIq8i8UUijNkLVT8s5plKKg+LPD06w3YfhyJ1NLUwAVwqTPg+DQAAVlJLkNpPVKytw uKIg== X-Gm-Message-State: AOAM531sTpBJo5vMqvHhFT3tKpomrGhTgJIEeLPV9WuiijA4nw4JHRph dops7ZSfnRgO0JhQHMNG5XDDNiIFYmuWY0YkwX4PLg== X-Google-Smtp-Source: ABdhPJydQ3JF4RJPCBrrrnsibfOQNjmnkH8RvdYTDaT4t9agLmajW2JLdDceJKZXK/JBoej4wJGe7HarOCof+hiFJhU= X-Received: by 2002:ac8:6c54:: with SMTP id z20mr6093592qtu.337.1603882568390; Wed, 28 Oct 2020 03:56:08 -0700 (PDT) MIME-Version: 1.0 References: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> In-Reply-To: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> From: Dmitry Vyukov Date: Wed, 28 Oct 2020 11:55:57 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/21] kasan, arm64: move initialization message To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > Tag-based KASAN modes are fully initialized with kasan_init_tags(), > while the generic mode only requireds kasan_init(). Move the > initialization message for tag-based modes into kasan_init_tags(). > > Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, Why doesn't it need it? What's the difference with tag modes? > tag-based modes should use "kasan:" instead of KBUILD_MODNAME. With generic KASAN I currently see: [ 0.571473][ T0] kasan: KernelAddressSanitizer initialized So KBUILD_MODNAME somehow works. Is there some difference between files? > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/Idfd1e50625ffdf42dfc3dbf7455b11bd200a0a49 > --- > arch/arm64/mm/kasan_init.c | 3 +++ > mm/kasan/generic.c | 2 -- > mm/kasan/hw_tags.c | 4 ++++ > mm/kasan/sw_tags.c | 4 +++- > 4 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index b6b9d55bb72e..8f17fa834b62 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -290,5 +290,8 @@ void __init kasan_init(void) > { > kasan_init_shadow(); > kasan_init_depth(); > +#if defined(CONFIG_KASAN_GENERIC) > + /* CONFIG_KASAN_SW/HW_TAGS also requires kasan_init_tags(). */ A bit cleaner way may be to introduce kasan_init_early() and kasan_init_late(). Late() will do tag init and always print the message. > pr_info("KernelAddressSanitizer initialized\n"); > +#endif > } > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index de6b3f03a023..d259e4c3aefd 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -9,8 +9,6 @@ > * Andrey Konovalov > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > - > #include > #include > #include > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index 0128062320d5..b372421258c8 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -6,6 +6,8 @@ > * Author: Andrey Konovalov > */ > > +#define pr_fmt(fmt) "kasan: " fmt > + > #include > #include > #include > @@ -18,6 +20,8 @@ > void __init kasan_init_tags(void) > { > init_tags(KASAN_TAG_MAX); > + > + pr_info("KernelAddressSanitizer initialized\n"); > } > > void *kasan_reset_tag(const void *addr) > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index bf1422282bb5..099af6dc8f7e 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -6,7 +6,7 @@ > * Author: Andrey Konovalov > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +#define pr_fmt(fmt) "kasan: " fmt > > #include > #include > @@ -41,6 +41,8 @@ void __init kasan_init_tags(void) > > for_each_possible_cpu(cpu) > per_cpu(prng_state, cpu) = (u32)get_cycles(); > + > + pr_info("KernelAddressSanitizer initialized\n"); > } > > /* > -- > 2.29.0.rc1.297.gfa9743e501-goog >