From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED09FA372C for ; Fri, 8 Nov 2019 12:09:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 387482085B for ; Fri, 8 Nov 2019 12:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vP/FGegR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 387482085B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 781776B0005; Fri, 8 Nov 2019 07:08:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 731466B0006; Fri, 8 Nov 2019 07:08:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6478E6B0007; Fri, 8 Nov 2019 07:08:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 4F6E76B0005 for ; Fri, 8 Nov 2019 07:08:59 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 042CA4995E8 for ; Fri, 8 Nov 2019 12:08:59 +0000 (UTC) X-FDA: 76132989198.10.boot18_8896daff22c27 X-HE-Tag: boot18_8896daff22c27 X-Filterd-Recvd-Size: 6139 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 Nov 2019 12:08:58 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id 205so5045343qkk.1 for ; Fri, 08 Nov 2019 04:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=njIoDqmvQ1VEZ9ra52KRdQl+Hz+9OkRPaFfud4xhNNg=; b=vP/FGegRPncfmsifSHCm4FqLb1gY7jha/8GAWmEhs5leV8dZfpToY3T5SRB4kZ9ri1 Kb9ho1v6VySUUjZLWIhrV0bljB5U7vRkudYURrjAo/8DFdfqSjXAd2bY8/ZyUPwUN3Xm A63cGv/YniCTjpwOSVUeiDgyjVDHpb3JlxoOx6MTlV6qqw1yv+8btyL7f75b9Oz9WREX QbcNPYaz4uBsptJsbHhqZgc+ZMRDnnvfJsf0gsxjPO7Jxm4qQlMKhK5LvduHllbmz2G+ dclGHWxWt5T/CJvICBy49PuKjebPLmKz8CCC0brjry/hcD123E8wSxmAaiXNC2VGzTcS qp8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=njIoDqmvQ1VEZ9ra52KRdQl+Hz+9OkRPaFfud4xhNNg=; b=Xb4WjF+2/Qae0nu42W+CJ+CfLqoGDXb4WRlGtPFoTCKJv2ZhQ3Hwt8NzIRZ88Ucd1b jmmKWTTqhrkPV1npPEEdZJQrdwjMGhjAnA+Dc6kDjjWxnrft0P/EI40DLFjT3W7tZaWW ufBkHFtDus4A2jl/8eUvC04kACcP7gY2f+VzAVZB2RaGWjZ/clfA012R/Yrg76Ppo97V aKhUn4VUoKz/nJ/aJZrCjX6rch/5er2c/+h1w0N59hcoE+TrDCOpJXnbR0iDrBPFfGWv YDt66ol3xbHA7vN6ckJGvn8xiaekQ+GfOMl75G+Fur7C6pe5eEQ26qclhaEB1Rx4EMqN FZyg== X-Gm-Message-State: APjAAAXT1ut5qXnBhEdU2dakpM2UfMjngHXDjskqzN2G/E7SE8K/wcMC FUiEZhgGxaMuqlGFgVLajZiMdljw2DKOwtkegR55Ng== X-Google-Smtp-Source: APXvYqzLUfrQpojnAi3MrlY/1926eC+WlPIVplXgb71NWYOUAJ9J+K/5fVhFfaMAfQbVtYnGplX23YEYmJ+0hoFGkL8= X-Received: by 2002:a37:6156:: with SMTP id v83mr8535128qkb.43.1573214937443; Fri, 08 Nov 2019 04:08:57 -0800 (PST) MIME-Version: 1.0 References: <20191030142237.249532-1-glider@google.com> <20191030142237.249532-10-glider@google.com> In-Reply-To: <20191030142237.249532-10-glider@google.com> From: Dmitry Vyukov Date: Fri, 8 Nov 2019 13:08:46 +0100 Message-ID: Subject: Re: [PATCH RFC v2 09/25] kmsan: add KMSAN runtime To: Alexander Potapenko Cc: Vegard Nossum , Linux-MM , Al Viro , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Dmitry Torokhov , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ingo Molnar , Jens Axboe , "Martin K. Petersen" , Martin Schwidefsky , "Michael S. Tsirkin" , monstr@monstr.eu, Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Wolfram Sang , Vasily Gorbik , iii@linux.ibm.com, Mark Rutland , Matthew Wilcox , Randy Dunlap , Andrey Konovalov , Marco Elver Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 30, 2019 at 3:23 PM wrote: > > This patch adds the KernelMemorySanitizer runtime and associated files: > > - arch/x86/include/asm/kmsan.h: assembly definitions for hooking > interrupt handlers; > - include/linux/kmsan-checks.h: user API to enable/disable KMSAN, > poison/unpoison memory etc. > - include/linux/kmsan.h: declarations of KMSAN memory hooks to be > referenced outside KMSAN runtime > - lib/Kconfig.kmsan: declarations for CONFIG_KMSAN and > CONFIG_TEST_KMSAN > - mm/kmsan/Makefile: boilerplate Makefile > - mm/kmsan/kmsan.h: internal KMSAN declarations > - mm/kmsan/kmsan.c: core functions that operate with shadow and > origin memory and perform checks, utility functions > - mm/kmsan/kmsan_entry.c: KMSAN hooks for entry_64.S > - mm/kmsan/kmsan_hooks.c: KMSAN hooks for kernel subsystems > - mm/kmsan/kmsan_init.c: KMSAN initialization routines > - mm/kmsan/kmsan_instr.c: functions called by KMSAN instrumentation > - scripts/Makefile.kmsan: CFLAGS_KMSAN > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: linux-mm@kvack.org >+ kmsan_pr_err("Local variable description: %s\n", descr); >+ kmsan_pr_err("Variable was created at:\n"); It would be nice to tidy up the description, it contains lots of duplicate/unneeded/confusing info: Local variable description: ----br.i@vp7045_read_mac_addr Variable was created at: vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline] vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline] vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132 It could be just: Local variable br was created at: vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline] vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline] vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132