From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B415C2BA19 for ; Sat, 18 Apr 2020 07:04:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03AE321D82 for ; Sat, 18 Apr 2020 07:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LcLkUN50" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03AE321D82 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 904828E0003; Sat, 18 Apr 2020 03:04:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4F68E0001; Sat, 18 Apr 2020 03:04:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CAB58E0003; Sat, 18 Apr 2020 03:04:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 646B88E0001 for ; Sat, 18 Apr 2020 03:04:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 28B1D180ACF9A for ; Sat, 18 Apr 2020 07:04:51 +0000 (UTC) X-FDA: 76720088382.01.sound48_476d1fb258437 X-HE-Tag: sound48_476d1fb258437 X-Filterd-Recvd-Size: 5143 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sat, 18 Apr 2020 07:04:50 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id w24so3996767qts.11 for ; Sat, 18 Apr 2020 00:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=frcRIzvUu/qQayHA5R2SRcLWyTjvWi33DiBNKj+vA2I=; b=LcLkUN501e4hh2Vf9DuLPtGQ/JpLMVGYDMR/tyElPI6RiZmLO6U26K0NH2SIUbCdwD UVcu1R6soOOc5voW8OC+ZA8WuFhGNjO6IPA0x/m05518n0j2VPVmIXJtEe7E+fZqMwWE fx4YB9PiLDHhEJERBLUGTsnnQSdaGzrWo0BBI1LjMg+anW6xdG0gAA9uJJ/Z9Fk4dosS mEY9vonmuIvTvndoy8hMKvBA3tzalWOQ+hwdXxX04hABIIonSd14gDSpgC66CHOXeZHa R/JRHWU/AmxWLqBjJUYwxf5ccY8uzDNJe9qum4Kx3xhTiaBszPVs02Kn2OLMScr+9MqQ ru8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=frcRIzvUu/qQayHA5R2SRcLWyTjvWi33DiBNKj+vA2I=; b=sTQptYDCYItV5gF2genDJA41RMy0hdffEQFqVDVCCs27+WbroIS3G4aXTpeeLfjxc4 49FZ+H0BqxEQhIegutXk/VWKebHYZKsY34o2cZ1Eu9GV1VukDcYhML9jsp804QNBPM/X Mpno7TI5Vzp58Aq05v4pw3KNyn3bDUZVSskq59+tZMQSK/F7qQV9jKBr7Me2rCeOwfTt Ar9Mo3OqccH4akLu+77IWdfz8S8V2+BhCjt7RXosx6FVuzipo/9gJmnc5wX6vpSyK86h VcGyLgUf4VNEgkfiXNoVICaNqiE4ISVPDiPAQlapUn+WBRRsZ15LodEZKCScBGHR2wIJ PhKQ== X-Gm-Message-State: AGi0PuYj39yWR15V9iyj53mAE2iaC/HvCNRBE7+Dhe/RW25ucqKf+Lni zORn+t+r3I6LrK4vpZCkc5i79GRqByT4qaKkbKP/tQ== X-Google-Smtp-Source: APiQypINDBkJDFArA1lpSkec1Z+GgV2eVqSt4z5L1ETOlwWtYWFglYmzQVtAF1J+CXbGHT+VoKbsR7tT4/0sIFn1G+4= X-Received: by 2002:ac8:370c:: with SMTP id o12mr6795321qtb.380.1587193489821; Sat, 18 Apr 2020 00:04:49 -0700 (PDT) MIME-Version: 1.0 References: <00000000000022640205a04a20d8@google.com> <20200309092423.2ww3aw6yfyce7yty@box> <5b1196be-09ce-51f7-f5e7-63f2e597f91e@linux.alibaba.com> In-Reply-To: From: Dmitry Vyukov Date: Sat, 18 Apr 2020 09:04:38 +0200 Message-ID: Subject: Re: linux-next test error: BUG: using __this_cpu_read() in preemptible code in __mod_memcg_state To: Alex Shi , Linux-Next Mailing List , Stephen Rothwell Cc: "Kirill A. Shutemov" , syzbot , Andrew Morton , Cgroups , Johannes Weiner , LKML , Linux-MM , Michal Hocko , syzkaller-bugs , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 9, 2020 at 2:27 PM Alex Shi wrote: > =E5=9C=A8 2020/3/9 =E4=B8=8B=E5=8D=885:56, Alex Shi =E5=86=99=E9=81=93: > > > > > > =E5=9C=A8 2020/3/9 =E4=B8=8B=E5=8D=885:24, Kirill A. Shutemov =E5=86=99= =E9=81=93: > >>> check_preemption_disabled: 3 callbacks suppressed > >>> BUG: using __this_cpu_read() in preemptible [00000000] code: syz-fuzz= er/9432 > >>> caller is __mod_memcg_state+0x27/0x1a0 mm/memcontrol.c:689 > >>> CPU: 1 PID: 9432 Comm: syz-fuzzer Not tainted 5.6.0-rc4-next-20200306= -syzkaller #0 > >>> Hardware name: Google Google Compute Engine/Google Compute Engine, BI= OS Google 01/01/2011 > >>> Call Trace: > >>> __dump_stack lib/dump_stack.c:77 [inline] > >>> dump_stack+0x188/0x20d lib/dump_stack.c:118 > >>> check_preemption_disabled lib/smp_processor_id.c:47 [inline] > >>> __this_cpu_preempt_check.cold+0x84/0x90 lib/smp_processor_id.c:64 > >>> __mod_memcg_state+0x27/0x1a0 mm/memcontrol.c:689 > >>> __split_huge_page mm/huge_memory.c:2575 [inline] > >>> split_huge_page_to_list+0x124b/0x3380 mm/huge_memory.c:2862 > >>> split_huge_page include/linux/huge_mm.h:167 [inline] > >> It looks like a regression due to c8cba0cc2a80 ("mm/thp: narrow lru > >> locking"). > > > > yes, I guess so. > > Yes, it is a stupid mistake to pull out lock for __mod_memcg_state which > should be in a lock. > > revert this patch should be all fine, since ClearPageCompound and page_re= f_inc > later may related with lru_list valid issue in release_pges. > > > Sorry for the disaster! > > Alex +linux-next, Stephen for currently open linux-next build/boot failure Hi Alex, What's the status of this? Was the guilty patch reverted? If so, please mark it as invalid for syzbot, otherwise it still shows up as open bug.