From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E613AC388F9 for ; Tue, 27 Oct 2020 12:41:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1985221D24 for ; Tue, 27 Oct 2020 12:41:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UMOH9tN9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1985221D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 749FA6B0070; Tue, 27 Oct 2020 08:41:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F8536B0071; Tue, 27 Oct 2020 08:41:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C0396B0072; Tue, 27 Oct 2020 08:41:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 290336B0070 for ; Tue, 27 Oct 2020 08:41:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B2BC81EE6 for ; Tue, 27 Oct 2020 12:41:25 +0000 (UTC) X-FDA: 77417666130.26.shop47_5004daf2727c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 8FFFE1804B654 for ; Tue, 27 Oct 2020 12:41:25 +0000 (UTC) X-HE-Tag: shop47_5004daf2727c X-Filterd-Recvd-Size: 5020 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 27 Oct 2020 12:41:25 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id 188so912805qkk.12 for ; Tue, 27 Oct 2020 05:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0WSVQEGSlOmtaeUZ3M4C4CAr2aYtzYDFb3Hz1iLTMF8=; b=UMOH9tN9cRSeE3vqgrC7b4Xw4Z+jRzjlh2yVsnZ3YEdcbfFSLs+oCQESgJnMTZ8nIh W6e0KgXWbYLK4lgMJfCL+flgQ3bpd4Tpv7CU1B0SbGvvBNbReYP/HuU1vpn4OvucZitg Raba86EeUzNKk6nvUzF7j68OhyYslwCOh47A7oIwpB6l0Ayk6S/tPfbvXGE6naK2MBGW /zthLNFbnSCS8//whSDtHe95WGW0r7gP/+JarTUYQqYUD6LoVZfk8LuGw5x4n9qZs6K2 nwxsqHEFczak759sjA+NjGlhQxjdSmD5CeddkhVBF38VeLNm4LB2gSJPHdvs3uOEmfju BNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0WSVQEGSlOmtaeUZ3M4C4CAr2aYtzYDFb3Hz1iLTMF8=; b=h1Gl5bOiEJWCKH1cAR6TMcoSzx6NpSPuc3mztcHIi/3EeFYcuHx0npyLMKAL9JOx3m z4NQlk7v9V5mb7YR3Gp6szf4uvXH8feq7T3+DEcwWdZSWsvWiGz+VRUrVC/j3etLoViv iMA1d1I2EXVYDPTJVEIi8ilf/EZS4OFCndBz9Ge4MdYv68HkROQqdwYBL5gVrNeIh1Qe pk2XeMK9ueWm8FQjOFyAQbThucBK4ykp2uxHXqDpzm9On+4SFz7DmWYUA1ppVouWzQP+ xX2dMlgRggxRLFnniuGQJE2+WCU96pTeD7AQAqkaAwGYG6nqWIOAvbRf1NqcVDC5F6YN oWBg== X-Gm-Message-State: AOAM532cXj3MghZFYCAyAyPHQf3k6wqUPw7XJCLLtTLD2WX4ntZoowmT HKWqaGc/WhdQZkQtACl1KEBGLI7uxnXz9RYvLcFHKA== X-Google-Smtp-Source: ABdhPJzeCOTIT+z3O6NE9HLXrbPisUui6Q4rs7ispRERno/r+2ZWxwle5JD3oLkx32lFdhp7ceeyYAOnF6WEGfI/zig= X-Received: by 2002:a05:620a:1657:: with SMTP id c23mr1940261qko.231.1603802484307; Tue, 27 Oct 2020 05:41:24 -0700 (PDT) MIME-Version: 1.0 References: <595f9936a80b62ab89b884d71e904eaa884a96c2.1603372719.git.andreyknvl@google.com> In-Reply-To: <595f9936a80b62ab89b884d71e904eaa884a96c2.1603372719.git.andreyknvl@google.com> From: Dmitry Vyukov Date: Tue, 27 Oct 2020 13:41:13 +0100 Message-ID: Subject: Re: [PATCH RFC v2 03/21] kasan: introduce set_alloc_info To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > Add set_alloc_info() helper and move kasan_set_track() into it. This will > simplify the code for one of the upcoming changes. > > No functional changes. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I0316193cbb4ecc9b87b7c2eee0dd79f8ec908c1a Reviewed-by: Dmitry Vyukov > --- > mm/kasan/common.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 8fd04415d8f4..a880e5a547ed 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -318,6 +318,11 @@ bool kasan_slab_free(struct kmem_cache *cache, void *object, unsigned long ip) > return __kasan_slab_free(cache, object, ip, true); > } > > +static void set_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags) > +{ > + kasan_set_track(&kasan_get_alloc_meta(cache, object)->alloc_track, flags); > +} > + > static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > size_t size, gfp_t flags, bool keep_tag) > { > @@ -345,7 +350,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > KASAN_KMALLOC_REDZONE); > > if (cache->flags & SLAB_KASAN) > - kasan_set_track(&kasan_get_alloc_meta(cache, object)->alloc_track, flags); > + set_alloc_info(cache, (void *)object, flags); > > return set_tag(object, tag); > } > -- > 2.29.0.rc1.297.gfa9743e501-goog >