From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688A2C47404 for ; Mon, 7 Oct 2019 12:20:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E2CF206BB for ; Mon, 7 Oct 2019 12:20:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LHYPKcnf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E2CF206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A07D68E0005; Mon, 7 Oct 2019 08:20:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B9198E0003; Mon, 7 Oct 2019 08:20:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A60D8E0005; Mon, 7 Oct 2019 08:20:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 529AA8E0003 for ; Mon, 7 Oct 2019 08:20:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id BED7A6137 for ; Mon, 7 Oct 2019 12:20:08 +0000 (UTC) X-FDA: 76016895696.18.dog74_759326babd835 X-HE-Tag: dog74_759326babd835 X-Filterd-Recvd-Size: 16421 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 12:20:07 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id n7so18778455qtb.6 for ; Mon, 07 Oct 2019 05:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=foEkWUCM575fnsqo6dD50iM97OZJEympj2lwIIE9A5g=; b=LHYPKcnfysh/Caiq374/gthsrLoIyk3tHXauOq+eeVZLHdbJJfrDcvWMnP2YRDOG4y o5uB6vwOOlA557aaOrvSnrvdUsLdP6tDbE57H4KMJFVNh3LP+hyNKyQWB8mgP6sbfMwk 7mj/gcuVz6UtV+hEqDDnDPAm8v9hZdZpVm3cCRfysjB5nenQdwqdBbxgL46F9xMZv/tY 8lycVZo65X1EijvrwASG3VLPlK2s6MohOoUoZ9qq8JkoaFH4dF54hK4Bz5PT5q73wR72 cEvq0/v0xrIYrPBFoQZotC6HP9bsE82nGsWHRSnVk6yzliex7OHgj34KO9NeiwPN+CYu 4GSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=foEkWUCM575fnsqo6dD50iM97OZJEympj2lwIIE9A5g=; b=FEb97onL27rNFuWV/mENETzAGP83mHFPz6nyMilPjBHNYiCXRS1wzK+I4eW5SEOfF6 uogPzvJWP0ww01FOA+OhHLge2Y+P5qXVaJZPyDpIeJW/RsPf1LupfiEmSq7Qi9pxn1xm MwY6NVFTCdveL3l9vrtZY7oRoUTnxMD9WtCBwBDsJ6iPWpsAaCK58/novGLCUMaPIU3g l4yzkDFKhN1P1BsnOWxpyPtap8p3S8YcShlWVyKlIPVNei5lMqX2XN9t4OUiR2DP9NPB zRp6Du1+T8Q2iIkWO9LQ2vwuTaXPqgOrzVWOp8Ebb0vPi0MLtzVALMNboU79TdR+b1CD +Ujw== X-Gm-Message-State: APjAAAVc5BAzON/dSaZq8K5BYwCuGxXICPP/G/xuuZSNsXcA/duv5s6Y 54POG5LhLspDf2CeKjWU3+P4LRmEsBk6LxCcRkdxsA== X-Google-Smtp-Source: APXvYqwd0VtKG/ssBM8w+azUJA7VLtUFK0uvly01KrSBiPL8XWh9b9V7ijucaxueKzu4MiMHLgWkXKNRUS58zXWZCeU= X-Received: by 2002:ac8:108b:: with SMTP id a11mr29317165qtj.380.1570450806687; Mon, 07 Oct 2019 05:20:06 -0700 (PDT) MIME-Version: 1.0 References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> <1570018513.19702.36.camel@mtksdccf07> <1570069078.19702.57.camel@mtksdccf07> <1570095525.19702.59.camel@mtksdccf07> <1570110681.19702.64.camel@mtksdccf07> <1570164140.19702.97.camel@mtksdccf07> <1570176131.19702.105.camel@mtksdccf07> <1570182257.19702.109.camel@mtksdccf07> <1570190718.19702.125.camel@mtksdccf07> <1570418576.4686.30.camel@mtksdccf07> <1570436289.4686.40.camel@mtksdccf07> <1570438317.4686.44.camel@mtksdccf07> <1570439032.4686.50.camel@mtksdccf07> <1570440492.4686.59.camel@mtksdccf07> <1570441833.4686.66.camel@mtksdccf07> <1570449804.4686.79.camel@mtksdccf07> In-Reply-To: <1570449804.4686.79.camel@mtksdccf07> From: Dmitry Vyukov Date: Mon, 7 Oct 2019 14:19:54 +0200 Message-ID: Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 7, 2019 at 2:03 PM Walter Wu wrote: > > > > > > > > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu wrote: > > > > > > > > > > The patchsets help to produce KASAN report when size is negative numbers > > > > > > > > > > in memory operation function. It is helpful for programmer to solve the > > > > > > > > > > undefined behavior issue. Patch 1 based on Dmitry's review and > > > > > > > > > > suggestion, patch 2 is a test in order to verify the patch 1. > > > > > > > > > > > > > > > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=199341 > > > > > > > > > > [2]https://lore.kernel.org/linux-arm-kernel/20190927034338.15813-1-walter-zh.wu@mediatek.com/ > > > > > > > > > > > > > > > > > > > > Walter Wu (2): > > > > > > > > > > kasan: detect invalid size in memory operation function > > > > > > > > > > kasan: add test for invalid size in memmove > > > > > > > > > > > > > > > > > > > > lib/test_kasan.c | 18 ++++++++++++++++++ > > > > > > > > > > mm/kasan/common.c | 13 ++++++++----- > > > > > > > > > > mm/kasan/generic.c | 5 +++++ > > > > > > > > > > mm/kasan/generic_report.c | 12 ++++++++++++ > > > > > > > > > > mm/kasan/tags.c | 5 +++++ > > > > > > > > > > mm/kasan/tags_report.c | 12 ++++++++++++ > > > > > > > > > > 6 files changed, 60 insertions(+), 5 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > commit 5b3b68660b3d420fd2bd792f2d9fd3ccb8877ef7 > > > > > > > > > > Author: Walter-zh Wu > > > > > > > > > > Date: Fri Oct 4 18:38:31 2019 +0800 > > > > > > > > > > > > > > > > > > > > kasan: detect invalid size in memory operation function > > > > > > > > > > > > > > > > > > > > It is an undefined behavior to pass a negative numbers to > > > > > > > > > > memset()/memcpy()/memmove() > > > > > > > > > > , so need to be detected by KASAN. > > > > > > > > > > > > > > > > > > > > If size is negative numbers, then it has two reasons to be defined > > > > > > > > > > as out-of-bounds bug type. > > > > > > > > > > 1) Casting negative numbers to size_t would indeed turn up as a > > > > > > > > > > large > > > > > > > > > > size_t and its value will be larger than ULONG_MAX/2, so that this > > > > > > > > > > can > > > > > > > > > > qualify as out-of-bounds. > > > > > > > > > > 2) Don't generate new bug type in order to prevent duplicate reports > > > > > > > > > > by > > > > > > > > > > some systems, e.g. syzbot. > > > > > > > > > > > > > > > > > > > > KASAN report: > > > > > > > > > > > > > > > > > > > > BUG: KASAN: out-of-bounds in kmalloc_memmove_invalid_size+0x70/0xa0 > > > > > > > > > > Read of size 18446744073709551608 at addr ffffff8069660904 by task > > > > > > > > > > cat/72 > > > > > > > > > > > > > > > > > > > > CPU: 2 PID: 72 Comm: cat Not tainted > > > > > > > > > > 5.4.0-rc1-next-20191004ajb-00001-gdb8af2f372b2-dirty #1 > > > > > > > > > > Hardware name: linux,dummy-virt (DT) > > > > > > > > > > Call trace: > > > > > > > > > > dump_backtrace+0x0/0x288 > > > > > > > > > > show_stack+0x14/0x20 > > > > > > > > > > dump_stack+0x10c/0x164 > > > > > > > > > > print_address_description.isra.9+0x68/0x378 > > > > > > > > > > __kasan_report+0x164/0x1a0 > > > > > > > > > > kasan_report+0xc/0x18 > > > > > > > > > > check_memory_region+0x174/0x1d0 > > > > > > > > > > memmove+0x34/0x88 > > > > > > > > > > kmalloc_memmove_invalid_size+0x70/0xa0 > > > > > > > > > > > > > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=199341 > > > > > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > > > Reported -by: Dmitry Vyukov > > > > > > > > > > Suggested-by: Dmitry Vyukov > > > > > > > > > > > > > > > > > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > > > > > > > > index 6814d6d6a023..6ef0abd27f06 100644 > > > > > > > > > > --- a/mm/kasan/common.c > > > > > > > > > > +++ b/mm/kasan/common.c > > > > > > > > > > @@ -102,7 +102,8 @@ EXPORT_SYMBOL(__kasan_check_write); > > > > > > > > > > #undef memset > > > > > > > > > > void *memset(void *addr, int c, size_t len) > > > > > > > > > > { > > > > > > > > > > - check_memory_region((unsigned long)addr, len, true, _RET_IP_); > > > > > > > > > > + if (!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) > > > > > > > > > > + return NULL; > > > > > > > > > > > > > > > > > > > > return __memset(addr, c, len); > > > > > > > > > > } > > > > > > > > > > @@ -110,8 +111,9 @@ void *memset(void *addr, int c, size_t len) > > > > > > > > > > #undef memmove > > > > > > > > > > void *memmove(void *dest, const void *src, size_t len) > > > > > > > > > > { > > > > > > > > > > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > > > > > > - check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > + if (!check_memory_region((unsigned long)src, len, false, _RET_IP_) || > > > > > > > > > > + !check_memory_region((unsigned long)dest, len, true, _RET_IP_)) > > > > > > > > > > + return NULL; > > > > > > > > > > > > > > > > > > > > return __memmove(dest, src, len); > > > > > > > > > > } > > > > > > > > > > @@ -119,8 +121,9 @@ void *memmove(void *dest, const void *src, size_t > > > > > > > > > > len) > > > > > > > > > > #undef memcpy > > > > > > > > > > void *memcpy(void *dest, const void *src, size_t len) > > > > > > > > > > { > > > > > > > > > > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > > > > > > > > > > - check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > > > > > > > > > + if (!check_memory_region((unsigned long)src, len, false, _RET_IP_) || > > > > > > > > > > + !check_memory_region((unsigned long)dest, len, true, _RET_IP_)) > > > > > > > > > > + return NULL; > > > > > > > > > > > > > > > > > > > > return __memcpy(dest, src, len); > > > > > > > > > > } > > > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > > > index 616f9dd82d12..02148a317d27 100644 > > > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > > > @@ -173,6 +173,11 @@ static __always_inline bool > > > > > > > > > > check_memory_region_inline(unsigned long addr, > > > > > > > > > > if (unlikely(size == 0)) > > > > > > > > > > return true; > > > > > > > > > > > > > > > > > > > > + if (unlikely((long)size < 0)) { > > > > > > > > > > + kasan_report(addr, size, write, ret_ip); > > > > > > > > > > + return false; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > if (unlikely((void *)addr < > > > > > > > > > > kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) { > > > > > > > > > > kasan_report(addr, size, write, ret_ip); > > > > > > > > > > diff --git a/mm/kasan/generic_report.c b/mm/kasan/generic_report.c > > > > > > > > > > index 36c645939bc9..ed0eb94cb811 100644 > > > > > > > > > > --- a/mm/kasan/generic_report.c > > > > > > > > > > +++ b/mm/kasan/generic_report.c > > > > > > > > > > @@ -107,6 +107,18 @@ static const char *get_wild_bug_type(struct > > > > > > > > > > kasan_access_info *info) > > > > > > > > > > > > > > > > > > > > const char *get_bug_type(struct kasan_access_info *info) > > > > > > > > > > { > > > > > > > > > > + /* > > > > > > > > > > + * If access_size is negative numbers, then it has two reasons > > > > > > > > > > + * to be defined as out-of-bounds bug type. > > > > > > > > > > + * 1) Casting negative numbers to size_t would indeed turn up as > > > > > > > > > > + * a 'large' size_t and its value will be larger than ULONG_MAX/2, > > > > > > > > > > + * so that this can qualify as out-of-bounds. > > > > > > > > > > + * 2) Don't generate new bug type in order to prevent duplicate > > > > > > > > > > reports > > > > > > > > > > + * by some systems, e.g. syzbot. > > > > > > > > > > + */ > > > > > > > > > > + if ((long)info->access_size < 0) > > > > > > > > > > + return "out-of-bounds"; > > > > > > > > > > > > > > > > > > "out-of-bounds" is the _least_ frequent KASAN bug type. It won't > > > > > > > > > prevent duplicates. "heap-out-of-bounds" is the frequent one. > > > > > > > > > > > > > > > > > > > > > > > > /* > > > > > > > > * If access_size is negative numbers, then it has two reasons > > > > > > > > * to be defined as out-of-bounds bug type. > > > > > > > > * 1) Casting negative numbers to size_t would indeed turn up as > > > > > > > > * a "large" size_t and its value will be larger than ULONG_MAX/2, > > > > > > > > * so that this can qualify as out-of-bounds. > > > > > > > > * 2) Don't generate new bug type in order to prevent duplicate > > > > > > > > reports > > > > > > > > * by some systems, e.g. syzbot. "out-of-bounds" is the _least_ > > > > > > > > frequent KASAN bug type. > > > > > > > > * It won't prevent duplicates. "heap-out-of-bounds" is the > > > > > > > > frequent one. > > > > > > > > */ > > > > > > > > > > > > > > > > We directly add it into the comment. > > > > > > > > > > > > > > > > > > > > > OK, let's start from the beginning: why do you return "out-of-bounds" here? > > > > > > > > > > > > > Uh, comment 1 and 2 should explain it. :) > > > > > > > > > > The comment says it will cause duplicate reports. It does not explain > > > > > why you want syzbot to produce duplicate reports and spam kernel > > > > > developers... So why do you want that? > > > > > > > > > We don't generate new bug type in order to prevent duplicate by some > > > > systems, e.g. syzbot. Is it right? If yes, then it should not have > > > > duplicate report. > > > > > > > Sorry, because we don't generate new bug type. it should be duplicate > > > report(only one report which may be oob or size invlid), > > > the duplicate report goal is that invalid size is oob issue, too. > > > > > > I would not introduce a new bug type. > > > These are parsed and used by some systems, e.g. syzbot. If size is > > > user-controllable, then a new bug type for this will mean 2 bug > > > reports. > > > > To prevent duplicates, the new crash title must not just match _any_ > > crash title that kernel can potentially produce. It must match exactly > > the crash that kernel produces for this bug on other input data. > > > > Consider, userspace passes size=123, KASAN produces "heap-out-of-bounds in foo". > > Now userspace passes size=-1 and KASAN produces "invalid-size in foo". > > This will be a duplicate bug report. > > Now if KASAN will produce "out-of-bounds in foo", it will also lead to > > a duplicate report. > > Only iff KASAN will produce "heap-out-of-bounds in foo" for size=-1, > > it will not lead to a duplicate report. > > I think it is not easy to avoid the duplicate report(mentioned above). > As far as my knowledge is concerned, KASAN is memory corruption detector > in kernel space, it should only detect memory corruption and don't > distinguish whether it is passed by userspace. if we want to do, then we > may need to parse backtrace to check if it has copy_form_user() or other > function? My idea was just to always print "heap-out-of-bounds" and don't differentiate if the size come from userspace or not.