From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD30ECE58C for ; Mon, 7 Oct 2019 13:34:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39FED2173B for ; Mon, 7 Oct 2019 13:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LpR2u7B9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39FED2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA1838E0005; Mon, 7 Oct 2019 09:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D51C98E0003; Mon, 7 Oct 2019 09:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C40FD8E0005; Mon, 7 Oct 2019 09:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id A294B8E0003 for ; Mon, 7 Oct 2019 09:34:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3CDC7180AD81B for ; Mon, 7 Oct 2019 13:34:05 +0000 (UTC) X-FDA: 76017082050.28.use53_239cd911a4f3d X-HE-Tag: use53_239cd911a4f3d X-Filterd-Recvd-Size: 5165 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 13:34:04 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id 201so12502291qkd.13 for ; Mon, 07 Oct 2019 06:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nwlp1QPq4c1Fg6asQ7NB8TWNONjREWmPa9T7sJeo1Lk=; b=LpR2u7B9qLEOo21QyyEqXT18++T96JVqMjjDQyKd2ZljeCz4lOfAqE9jICCOUofOUh JVqDxIg1Co8ZFXn/zlC3TsCfiNvKGMhAnJLziq46rxbu4og/R+XW5nGWOgqMfz6pbbio DYlXgZzLO48AJQMOMhcVvAs3AI4aCK6b9O3UsPvpLyfmVZgxV62R4sbvBtT07sHpnj9p GKBLb19GpMl2Ppo9oiKiS+DUJEs6IMFL9vxBn6QRUcr9K8bqdEuG6fWgtOg4oqA3msfL F8mqxebT+PFm55/aoOV7zBRZ7ftd+J6BEiZbp+9jRyzhUTvQLBzB0PTqhbMLTk9e18EE 78RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nwlp1QPq4c1Fg6asQ7NB8TWNONjREWmPa9T7sJeo1Lk=; b=hiT2Uo8kn6LU6BDMDCwjtisayNhy5FDcaIbx2HoN9dt8uf3itQy4TNLYvrlyg2WjNz A20Lk6JSPWEOi3owKhPfpzJ6DDQthbM4iHZkkYTUHJdv97e/u3WcG0jfFqSC/8izyG1D LOqDCcx0TUUx047AD8tLGEsaWq8lqu97Vo/mpKXy63+woJ1IvNe4VFY00lk+HNoiLTpM 0gX2C/UMAjPkcomCRKQFjkUgzLRFaDn2J5yjVAY42X7ns2oM8C0kJMBIsQlZ+Mmxt+CF H/z/IX1jq3b7T2ETuHwKGwYMwt65r0nRy1J85vdZTOYBVXjbpK/AjS+1DXyo+wnL/h+A JayQ== X-Gm-Message-State: APjAAAV04QXks5JfYhthRBic/stskyDgngU/S09phxSvqJxxocnBXsGy DTDxuCiSL4VRR3KP2SldK2h90aOkwD+TnAwMZwlE4g== X-Google-Smtp-Source: APXvYqw2Ad19XCqX+cZlHA+koY+Sx+ZtM8Qex4TkHKoGbm8iZRab0lV148rExC6MroVc/4YnPTOIulyRMYK1XqNpOvw= X-Received: by 2002:a37:e10f:: with SMTP id c15mr22691586qkm.256.1570455243666; Mon, 07 Oct 2019 06:34:03 -0700 (PDT) MIME-Version: 1.0 References: <20190927034338.15813-1-walter-zh.wu@mediatek.com> <1569594142.9045.24.camel@mtksdccf07> <1569818173.17361.19.camel@mtksdccf07> <1570018513.19702.36.camel@mtksdccf07> <1570069078.19702.57.camel@mtksdccf07> <1570095525.19702.59.camel@mtksdccf07> <1570110681.19702.64.camel@mtksdccf07> <1570164140.19702.97.camel@mtksdccf07> <1570176131.19702.105.camel@mtksdccf07> <1570182257.19702.109.camel@mtksdccf07> <1570190718.19702.125.camel@mtksdccf07> <1570418576.4686.30.camel@mtksdccf07> <1570436289.4686.40.camel@mtksdccf07> <1570438317.4686.44.camel@mtksdccf07> <1570439032.4686.50.camel@mtksdccf07> <1570440492.4686.59.camel@mtksdccf07> <1570441833.4686.66.camel@mtksdccf07> <1570449804.4686.79.camel@mtksdccf07> <1570451575.4686.83.camel@mtksdccf07> In-Reply-To: <1570451575.4686.83.camel@mtksdccf07> From: Dmitry Vyukov Date: Mon, 7 Oct 2019 15:33:51 +0200 Message-ID: Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , LKML , kasan-dev , Linux-MM , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 7, 2019 at 2:33 PM Walter Wu wrote: > On Mon, 2019-10-07 at 14:19 +0200, Dmitry Vyukov wrote: > > On Mon, Oct 7, 2019 at 2:03 PM Walter Wu wrote: > > My idea was just to always print "heap-out-of-bounds" and don't > > differentiate if the size come from userspace or not. > > Got it. > Would you have any other concern about this patch? Last versions of the patch looked good to me except for the bug title. The comment may also need some updating if you change the title.