From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3FD7C432C0 for ; Fri, 29 Nov 2019 12:15:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74F522086A for ; Fri, 29 Nov 2019 12:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DKA8tIwm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F522086A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FCC06B0587; Fri, 29 Nov 2019 07:15:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 086266B0588; Fri, 29 Nov 2019 07:15:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68DA6B0589; Fri, 29 Nov 2019 07:15:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id CBD8E6B0587 for ; Fri, 29 Nov 2019 07:15:46 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 821B475BA for ; Fri, 29 Nov 2019 12:15:46 +0000 (UTC) X-FDA: 76209211092.18.nut61_6c88919b81040 X-HE-Tag: nut61_6c88919b81040 X-Filterd-Recvd-Size: 7795 Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com [209.85.221.196]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 Nov 2019 12:15:45 +0000 (UTC) Received: by mail-vk1-f196.google.com with SMTP id m128so5569842vkb.5 for ; Fri, 29 Nov 2019 04:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0WhiOTotl5RS7Nhgu+DEp8rXQD1OdZR5GYdZuvSwXtw=; b=DKA8tIwm6GhRCI9jM01jburuNuRhJ9QKdTdbOs1G37L+s6Y84DB70YpPu9dvJ0cNtF Uka7bGagc7OvWyNoYKY8oy4QG+CFzlkkq6alj2Wt8PV3ObRe30ZzTKHjwx9k9UbD+PK6 Dsfm+mu1P++SkcE26EBwMnGR+EIDsC8P8XC3apJsDfSmFjHqcH7KL371QwS66TG96Hrp J/VzqfGjBEr1phEyAO5fWXe2ScSBThqXw/XpPrJQv61UFTK5sR7110dRnlg5+HYiHNpf x/kYVtL8fEmkrkiltG3cClKNjjITwZg4zzF2bzjZIQCKjaJ4iEmJf2f/U5CkrJ/Edn7x Z4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0WhiOTotl5RS7Nhgu+DEp8rXQD1OdZR5GYdZuvSwXtw=; b=M6VUU2noYFDKe2iTe8sDxg0rgEUu2OZSi2gJh/rN4QPE9UmroqSkDtrKlTRmNtD+fN qBRoU0v7linkdDW0WBugouwXGIKUqaKw2OiOJcW7BOnd/3YrHjicufT/qBN7P5JV+Erv 4WFf9J/aRhv5uHcP1Wo6zxMA9dDW+ermsVaS6ycIzPBGOqFVbhrqhLHa/V92e8oOBkW/ Zaks1q2wO7yI1vRiCYmLPBzq5rz41Ax9qJERgx+3ehjqwjStCzbxLfDUCCsv6zBr5dPO R9Hq1rD6cG8FlgA9jjG0mbF++Qc6nrJTcO4cyQY5doDvFK77UEkEqVaEoYN9b7XCyhwb Zi9Q== X-Gm-Message-State: APjAAAUcTIXA9swcRpXI1L7XQpjedD1CpgEfN1ga9y4dfju4qpf+4AIh 0RaA3SWGSPu6GXKuTNRZbEUKjKT33EeIuRzRgiU1Dg== X-Google-Smtp-Source: APXvYqzNZ/VvYg4NgWBljroyp/35Y0lyzRyZZphFXvnh/ws+m4BYhBTRf2ctuzvd8hjgkzeO3o6i1ZU1oOdDWXm3mYA= X-Received: by 2002:a1f:e784:: with SMTP id e126mr9488593vkh.102.1575029743872; Fri, 29 Nov 2019 04:15:43 -0800 (PST) MIME-Version: 1.0 References: <20191031093909.9228-1-dja@axtens.net> <20191031093909.9228-2-dja@axtens.net> <1573835765.5937.130.camel@lca.pw> <871ru5hnfh.fsf@dja-thinkpad.axtens.net> <952ec26a-9492-6f71-bab1-c1def887e528@virtuozzo.com> <874kymg9zc.fsf@dja-thinkpad.axtens.net> In-Reply-To: <874kymg9zc.fsf@dja-thinkpad.axtens.net> From: Dmitry Vyukov Date: Fri, 29 Nov 2019 13:15:28 +0100 Message-ID: Subject: Re: [PATCH v11 1/4] kasan: support backing vmalloc space with real shadow memory To: Daniel Axtens Cc: Andrey Ryabinin , Qian Cai , kasan-dev , Linux-MM , "the arch/x86 maintainers" , Alexander Potapenko , Andy Lutomirski , LKML , Mark Rutland , Christophe Leroy , linuxppc-dev , Vasily Gorbik Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 29, 2019 at 1:09 PM Daniel Axtens wrote: > > Hi Dmitry, > > >> I am testing this support on next-20191129 and seeing the following warnings: > >> > >> BUG: sleeping function called from invalid context at mm/page_alloc.c:4681 > >> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 44, name: kworker/1:1 > >> 4 locks held by kworker/1:1/44: > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: > >> __write_once_size include/linux/compiler.h:247 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: > >> arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: atomic64_set > >> include/asm-generic/atomic-instrumented.h:868 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: > >> atomic_long_set include/asm-generic/atomic-long.h:40 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: set_work_data > >> kernel/workqueue.c:615 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: > >> set_work_pool_and_clear_pending kernel/workqueue.c:642 [inline] > >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: > >> process_one_work+0x88b/0x1750 kernel/workqueue.c:2235 > >> #1: ffffc900002afdf0 (pcpu_balance_work){+.+.}, at: > >> process_one_work+0x8c0/0x1750 kernel/workqueue.c:2239 > >> #2: ffffffff8943f080 (pcpu_alloc_mutex){+.+.}, at: > >> pcpu_balance_workfn+0xcc/0x13e0 mm/percpu.c:1845 > >> #3: ffffffff89450c78 (vmap_area_lock){+.+.}, at: spin_lock > >> include/linux/spinlock.h:338 [inline] > >> #3: ffffffff89450c78 (vmap_area_lock){+.+.}, at: > >> pcpu_get_vm_areas+0x1449/0x3df0 mm/vmalloc.c:3431 > >> Preemption disabled at: > >> [] spin_lock include/linux/spinlock.h:338 [inline] > >> [] pcpu_get_vm_areas+0x1449/0x3df0 mm/vmalloc.c:3431 > >> CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.4.0-next-20191129+ #5 > >> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.12.0-1 04/01/2014 > >> Workqueue: events pcpu_balance_workfn > >> Call Trace: > >> __dump_stack lib/dump_stack.c:77 [inline] > >> dump_stack+0x199/0x216 lib/dump_stack.c:118 > >> ___might_sleep.cold.97+0x1f5/0x238 kernel/sched/core.c:6800 > >> __might_sleep+0x95/0x190 kernel/sched/core.c:6753 > >> prepare_alloc_pages mm/page_alloc.c:4681 [inline] > >> __alloc_pages_nodemask+0x3cd/0x890 mm/page_alloc.c:4730 > >> alloc_pages_current+0x10c/0x210 mm/mempolicy.c:2211 > >> alloc_pages include/linux/gfp.h:532 [inline] > >> __get_free_pages+0xc/0x40 mm/page_alloc.c:4786 > >> kasan_populate_vmalloc_pte mm/kasan/common.c:762 [inline] > >> kasan_populate_vmalloc_pte+0x2f/0x1b0 mm/kasan/common.c:753 > >> apply_to_pte_range mm/memory.c:2041 [inline] > >> apply_to_pmd_range mm/memory.c:2068 [inline] > >> apply_to_pud_range mm/memory.c:2088 [inline] > >> apply_to_p4d_range mm/memory.c:2108 [inline] > >> apply_to_page_range+0x5ca/0xa00 mm/memory.c:2133 > >> kasan_populate_vmalloc+0x69/0xa0 mm/kasan/common.c:791 > >> pcpu_get_vm_areas+0x1596/0x3df0 mm/vmalloc.c:3439 > >> pcpu_create_chunk+0x240/0x7f0 mm/percpu-vm.c:340 > >> pcpu_balance_workfn+0x1033/0x13e0 mm/percpu.c:1934 > >> process_one_work+0x9b5/0x1750 kernel/workqueue.c:2264 > >> worker_thread+0x8b/0xd20 kernel/workqueue.c:2410 > >> kthread+0x365/0x450 kernel/kthread.c:255 > >> ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 > >> > >> > >> Not sure if it's the same or not. Is it addressed by something in flight? > > It looks like this one is the same. > > There is a patch to fix it: > https://lore.kernel.org/linux-mm/20191120052719.7201-1-dja@axtens.net/ > > Andrew said he had picked it up on the 22nd: > https://marc.info/?l=linux-mm-commits&m=157438241512561&w=2 > It's landed in mmots but not mmotm, so hopefully that will happen and > then it will land in -next very soon! > > I will look into your other bug report shortly. Thanks for the quick responses, Andrey, Daniel. > Regards, > Daniel > > >> > >> My config: > >> https://gist.githubusercontent.com/dvyukov/36c7be311fdec9cd51c649f7c3cb2ddb/raw/39c6f864fdd0ffc53f0822b14c354a73c1695fa1/gistfile1.txt > > > > > > I've tried this fix for pcpu_get_vm_areas: > > https://groups.google.com/d/msg/kasan-dev/t_F2X1MWKwk/h152Z3q2AgAJ > > and it helps. But this will break syzbot on linux-next soon.