From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1869BC388F7 for ; Wed, 28 Oct 2020 16:57:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D6ED2479C for ; Wed, 28 Oct 2020 16:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eWofOYiP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D6ED2479C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 80E7E6B006E; Wed, 28 Oct 2020 12:57:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BE4B6B0070; Wed, 28 Oct 2020 12:57:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 660046B0071; Wed, 28 Oct 2020 12:57:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 39D2C6B006E for ; Wed, 28 Oct 2020 12:57:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CAF6F1EF2 for ; Wed, 28 Oct 2020 16:57:45 +0000 (UTC) X-FDA: 77421940890.10.note91_201310127286 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id A89CA16A0DE for ; Wed, 28 Oct 2020 16:57:45 +0000 (UTC) X-HE-Tag: note91_201310127286 X-Filterd-Recvd-Size: 4892 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 16:57:44 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id j129so5181342qke.5 for ; Wed, 28 Oct 2020 09:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zxgi7xd3nW4FDFVux6haRrdrCJvaqFEyqWtMMDIWgYY=; b=eWofOYiPw5raslm8yWSmDEwm/I/OMPVFw+0VduVEDahYCfRy1yswtr6sR1Pg/kenLL R03DZVGnmBJWhhFjsnQR4QiuVY3nJaLRrES5cmZvm0bRNyrAwWezG3L7l8+UdIqyus49 LINNaxfbFCakoHG0yD5FHsLcXhMzY+WpfQUIDFRnomSX+PG59G+pHRPJqMLCgdelEpZG 07W3oXzXJXs3omJoG1YIH6S3fhauMMlCn0CapNJ/QVH/EEBKI0o19EwatkaTOnkXUi2V hU9xEKAJFKdr1uoH4xOoA0pucS5Y3epFPk8cssZGA54e5xpUPnTTXvvc1B1+Xt5ENfgO Gz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zxgi7xd3nW4FDFVux6haRrdrCJvaqFEyqWtMMDIWgYY=; b=E72NztNYtIEJSgZKpU+2Hu+uH8UVpLw3WPbbYpJpMGW+nbjj8ZCKqi7QVWFl3DUc2d d9VBbyIaA0lzmryjXRtyHG81yi+RaxHoqPEyozYplw9zzXsgOBCG95aoLXvnwyMMGUOj 4ZFHEwYqhWUGbROV+wn+0jgzmB0lVAnHvz+2Q241gEVJ879kcnsat4L/85kpmurz/sKO itoqHiVL3N1YQVVcJJPLbFvLf9XmZn/cTJCiwKak67DzL/D1mDSkIHzkd7ybNiSc3IDi aGVo3x1UEYgVtLk/oboxOpg66pdJGEXYhZ/FhDacd5VFuekbApPv1Y9DVDk5V192dH7o NBdQ== X-Gm-Message-State: AOAM532S9G0vUodWy1/DGZNW+ByzCen3MP/H9TTQttKixtrLJCHvVh01 +suZwC85pDY8guuAOgJHVMN4etvrfkixY9xH1AKvnw== X-Google-Smtp-Source: ABdhPJy50POtHGn57238IQURdi1vWUPLZnjnOkGTn4fmZdTNYDz3IxwV1tq5IiPRk78U+K6fH4jLx8yuea6oPQZvVgw= X-Received: by 2002:a37:7b44:: with SMTP id w65mr8409031qkc.350.1603904264037; Wed, 28 Oct 2020 09:57:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Wed, 28 Oct 2020 17:57:33 +0100 Message-ID: Subject: Re: [PATCH RFC v2 17/21] kasan: simplify kasan_poison_kfree To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 3:20 PM Andrey Konovalov wrote: > > kasan_poison_kfree() is currently only called for mempool allocations > that are backed by either kmem_cache_alloc() or kmalloc(). Therefore, the > page passed to kasan_poison_kfree() is always PageSlab() and there's no > need to do the check. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/If31f88726745da8744c6bea96fb32584e6c2778c Reviewed-by: Dmitry Vyukov > --- > mm/kasan/common.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index a581937c2a44..b82dbae0c5d6 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -441,16 +441,7 @@ void __kasan_poison_kfree(void *ptr, unsigned long ip) > struct page *page; > > page = virt_to_head_page(ptr); > - > - if (unlikely(!PageSlab(page))) { > - if (ptr != page_address(page)) { > - kasan_report_invalid_free(ptr, ip); > - return; > - } > - kasan_poison_memory(ptr, page_size(page), KASAN_FREE_PAGE); > - } else { > - ____kasan_slab_free(page->slab_cache, ptr, ip, false); > - } > + ____kasan_slab_free(page->slab_cache, ptr, ip, false); > } > > void __kasan_kfree_large(void *ptr, unsigned long ip) > -- > 2.29.0.rc1.297.gfa9743e501-goog >