From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC20CC54EE9 for ; Thu, 8 Sep 2022 18:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BAED8D0001; Thu, 8 Sep 2022 14:14:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 143106B0073; Thu, 8 Sep 2022 14:14:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25C78D0001; Thu, 8 Sep 2022 14:14:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E05AD6B0072 for ; Thu, 8 Sep 2022 14:14:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1B4DAB1BB for ; Thu, 8 Sep 2022 18:14:09 +0000 (UTC) X-FDA: 79889717418.03.B39F211 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 6DA9D800A8 for ; Thu, 8 Sep 2022 18:14:09 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id a67so15962214ybb.3 for ; Thu, 08 Sep 2022 11:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=yIGQ1rsAiCTfDSyBYdyVPVyYlO9LImSP5xeSStH2FZ0=; b=pRUckrDB014z72ph6+Gz6wJWHEWKBfiaLi4wsYdQZDPkwzAG/b1AVpHgGh8RXCE+oq AQeaBo9euSonu1IHvOKnIOUfif2gLUjpuAdwul1l35/Ct3ruLEbUkux3Gfot9hCf+DYh W2c6fOkUxHaGwb6v23PHPtEVGkW0/borE1dH7CDUHyJdZNkosP18XXH7cuUPG/ZKtWkG BC0rHV9d5ZuFtPmBt2Vvl2xeLZrRZd69PahstEpaawCiJO2Xiyi1WgA9NwVdLalMrlir wYH8p4SuxorGTSSBGWHfpvJGm25XC/ikzKFvEOPb8sZj97ExgP2maYpg6Znoqs3w/ymX 7H1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=yIGQ1rsAiCTfDSyBYdyVPVyYlO9LImSP5xeSStH2FZ0=; b=vNap7NH+3GHZrvMSV1VIP6LUAqGd7vigYR/OM/4Nnmpox7C2HC6dGiuj+eqWqwY88b y+6apeSstRvlJNxXwWOBAHiuQvVwVLVaF6eYnfhARJX/ZDJXc8CEyHWmPLN3QFmkW4oh E0R37kk+PFfryB+uwWUNXnTzEI6tWKhQB/mGAR4MWX9BoNW4ML56p7wyZ2bG835x086O ghEXDifMZfHDGujTZ6qKYdPncpUpCiPLzRIHaIvfNdlKPGOxLiblIfVOwj28yJPpapmZ FR2rQxSZntgrCA78pTyXH5rImq+d2Z1QiscSnZ3+DKV6j0lGds1ndv8Uqga0C6MX1Jm+ K2Lg== X-Gm-Message-State: ACgBeo0HCq4BE6gs/6JUebAGPl8N7I55fS+dXqsgOMnvzqayHn/Ta3D7 Hdl65kbb8/R5ylRp2CBHF57MTMqqzMv7HdItnDUMRQ== X-Google-Smtp-Source: AA6agR7j8OY+h4Oql3K6L0ub3i+Dic+OMxkCNwt9XJdwoxGrEmWocMpg0Oz5l8/cyWBM/VTSKYC2kfOutoj2QFe/T1U= X-Received: by 2002:a5b:88a:0:b0:6ad:5eca:575b with SMTP id e10-20020a5b088a000000b006ad5eca575bmr6464622ybq.577.1662660848578; Thu, 08 Sep 2022 11:14:08 -0700 (PDT) MIME-Version: 1.0 References: <20220624173656.2033256-1-jthoughton@google.com> <20220624173656.2033256-10-jthoughton@google.com> In-Reply-To: From: James Houghton Date: Thu, 8 Sep 2022 11:13:56 -0700 Message-ID: Subject: Re: [RFC PATCH 09/26] hugetlb: add hugetlb_hgm_enabled To: Peter Xu Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Jue Wang , Manish Mishra , "Dr . David Alan Gilbert" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=pRUckrDB; spf=pass (imf30.hostedemail.com: domain of jthoughton@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662660849; a=rsa-sha256; cv=none; b=Vir3JF/vVtSVAMkDnKdk7LhyY4fJSsdlkKpjRgWgAQq3xXVG8Es9SFEmjU9MalGxq5YW1Z J/Fxz70nlzuUB9D8vlP7p89o8g3NSrvX1BwLDxkZ/ZfN9z9eMQywB76UFVU5N98bEWro// KGO4IjY4TXX2y9yDcZu7tTfHBbTPqAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662660849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yIGQ1rsAiCTfDSyBYdyVPVyYlO9LImSP5xeSStH2FZ0=; b=FeHQy25rOtXc8KvM5lNe8+wUvVInsGwxuaQSAK35EVkIoHP8UaiN/FqetMX1aGxa6qtyB1 EoBqxoXrpXbpppIpEIJR5Slk9snx2ZND1GR8gLFZ7ANccF1SuuYAwiEc8MWHeg0umkGPXl MxKWHhtB1kRTaAcBA6perI2grFzhKJA= X-Rspamd-Queue-Id: 6DA9D800A8 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=pRUckrDB; spf=pass (imf30.hostedemail.com: domain of jthoughton@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Stat-Signature: 55dd7nb1ub8wx695891gtyydmup9ic5g X-HE-Tag: 1662660849-468682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 8, 2022 at 11:07 AM Peter Xu wrote: > > On Fri, Jun 24, 2022 at 05:36:39PM +0000, James Houghton wrote: > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > > +{ > > + /* All shared VMAs have HGM enabled. */ > > + return vma->vm_flags & VM_SHARED; > > +} > > +#endif /* CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING */ > > Another nitpick: suggest to rename this to "hugetlb_***_supported()" (with > whatever the new name could be..), as long as it cannot be "disabled". :) > Will do. :) - James > -- > Peter Xu >