From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F93C433E6 for ; Wed, 31 Mar 2021 07:31:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0EA4D619E3 for ; Wed, 31 Mar 2021 07:31:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EA4D619E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 96AD46B0085; Wed, 31 Mar 2021 03:31:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 941286B0087; Wed, 31 Mar 2021 03:31:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E3026B0088; Wed, 31 Mar 2021 03:31:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 652B56B0085 for ; Wed, 31 Mar 2021 03:31:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1F025181AEF3E for ; Wed, 31 Mar 2021 07:31:29 +0000 (UTC) X-FDA: 77979349098.08.BD8C3D2 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf18.hostedemail.com (Postfix) with ESMTP id B1576200025C for ; Wed, 31 Mar 2021 07:31:27 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id ay2so7450548plb.3 for ; Wed, 31 Mar 2021 00:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5du6vxqJjDqpP0E7Hx0rrZrKyoS/A3+yjaNzND2Szag=; b=OE/itPyygmho513Og+3Dr1ziqFlGB3btca2JSNBveev1czD8zYVZzGYUImDIpzCSPD pGJKmK3PmdshakgjlcnpmjQh9iVC23blEJV1hHtBy6G7beQctjhPR8gQBZNFDJVgSjOJ kl9dAPOmJ9wa6uY2HGtlODyrZpnPNLaKoT+5fqocVokPq2SAiNhr0h8dCaiDnh+3kJZJ 8uqupx/TZrOd+XqMlRc8hGW7iUEA6IxpdlS6KqXLobx/PNRag5EGbwa9rVdci/ykvGmD vmozd5N1mk2sJwaIFNi3rw0KFoVE+MmZ5u2h3YSVE/JplRXn0fH+7scypyilgiysFjCo J/Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5du6vxqJjDqpP0E7Hx0rrZrKyoS/A3+yjaNzND2Szag=; b=KXq0ps/B0s7nzqWZT5Db1AXY/wa0n9E/wswUpaXEUx+7kijj7GMA0rM3RZrVB1jJMB q3FoJnb0xM3dP/SUkKWQXlDb4Z0dpAot4RTvr6fu0rNvP2NyUcLpfStfC21Wjsx6Djn0 tRYbXvUVUSevVLUWGnGnF2bsySeCUGjRp2S2OvuaI2MFcA6rNI6mQGSNm39UV3ehmw5V 8ft/84rIlQuSCBARk4xK4VtcN6kOMa+pJ9RBBeHC68MlmawuoaO2dQs34mImjheYRIEB eYRLul2V4pyeofg9ooEoGiPn7N2k8Rudi+RdGXCHiaoHuH8Vin7HbJVSMrqAeNqHn/4B zxEg== X-Gm-Message-State: AOAM530y/WwGOmkFcj7QgZO/yPeSh80vMpwOgaqIosa2PM+69tPs6OgV 7QOMb+Rwit/yqlZ3or2PDBgkztfsqbaxnuU3nGE= X-Google-Smtp-Source: ABdhPJx5zGJQCvb7TCdXmeCP+s6D4oyKFohI4hAtuQdzEDh1uv/ykSEQj7FNdNrmjmB0UsP0QzBwWWF9wmNp/J9NpG0= X-Received: by 2002:a17:902:be0c:b029:e6:f007:71d with SMTP id r12-20020a170902be0cb02900e6f007071dmr2040896pls.15.1617175887831; Wed, 31 Mar 2021 00:31:27 -0700 (PDT) MIME-Version: 1.0 References: <20210330175126.26500-1-rppt@kernel.org> <20210330181347.GQ351017@casper.infradead.org> In-Reply-To: From: Greentime Hu Date: Wed, 31 Mar 2021 15:30:51 +0800 Message-ID: Subject: Re: [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff To: Matthew Wilcox Cc: Mike Rapoport , Andrew Morton , Huang Ying , Mike Rapoport , Nick Hu , Vincent Chen , Linux Kernel Mailing List , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o9ugkzot4xgnjrfmr9ef67p3qctqahfg X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1576200025C Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-pl1-f175.google.com; client-ip=209.85.214.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617175887-198438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Greentime Hu =E6=96=BC 2021=E5=B9=B43=E6=9C=8831=E6=97= =A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:30=E5=AF=AB=E9=81=93=EF=BC=9A > > Matthew Wilcox =E6=96=BC 2021=E5=B9=B43=E6=9C=8831= =E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=882:14=E5=AF=AB=E9=81=93=EF=BC= =9A > > > > On Tue, Mar 30, 2021 at 08:51:26PM +0300, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > Commit cb9f753a3731 ("mm: fix races between swapoff and flush dcache"= ) > > > updated flush_dcache_page implementations on several architectures to= use > > > page_mapping_file() in order to avoid races between page_mapping() an= d > > > swapoff(). > > > > > > This update missed arch/nds32 and there is a possibility of a race th= ere. > > > > > > Replace page_mapping() with page_mapping_file() in nds32 implementati= on of > > > flush_dcache_page(). > > > > > > Fixes: cb9f753a3731 ("mm: fix races between swapoff and flush dcache"= ) > > > Signed-off-by: Mike Rapoport > > > > Reviewed-by: Matthew Wilcox (Oracle) > > Acked-by: Greentiime Hu Typo. Acked-by: Greentime Hu