From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46EAC433DF for ; Thu, 21 May 2020 22:10:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54666206F6 for ; Thu, 21 May 2020 22:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oZBWHO6M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54666206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DEA5780009; Thu, 21 May 2020 18:10:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D995580007; Thu, 21 May 2020 18:10:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB0C280009; Thu, 21 May 2020 18:10:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id B8CEB80007 for ; Thu, 21 May 2020 18:10:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7CE0F180AD81D for ; Thu, 21 May 2020 22:10:50 +0000 (UTC) X-FDA: 76842121860.21.dog82_75270a4ec71f X-HE-Tag: dog82_75270a4ec71f X-Filterd-Recvd-Size: 3396 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 22:10:50 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id f189so8907032qkd.5 for ; Thu, 21 May 2020 15:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cY8bWJYAziC6DykutTES7fh6tr7JoLymaKn0aTQJgAA=; b=oZBWHO6MlDik/xfnpMWKRcWYwij9zTcWmbH9JuSmErAy7WB07e1TiF4dmrbYGrUrqE qfRPZudJxSJMEBbPTN71bDZdMWPCrJkbvu8G7XGoSbB0Kx34lsholiAsXcWwqN10JtAU iOCFxhlFjbpIHLaFaQJOBJAm68LmJFbPxQgZuVSKrSYMQSv1COiw2SUduvBiHjvsxcll SIQaO4hysm74vwz4ag6lDgfbljYQ6gTEO0Fln/KDw5G3EyoU4W7ba+OEbrCIfHydiwYn pXBLSiowmepxk4ogSoo4Ab+GKnE6jOcIyJP+L+T59F2DnNwEODLueAcdNSCaAW5tjuuP lBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cY8bWJYAziC6DykutTES7fh6tr7JoLymaKn0aTQJgAA=; b=Cdz0wp0npY6mgi8V8S1nKtmv+MBDqcmxty7ffEvW083RPMAoqiZWgnEoPoXTxCjWW2 Aeq/gKa2KKMNTUMRVSbOin8vE3b2hNdAv6jsVLdamK3omKuDQARpE8arGUyNRIS2MkN7 aH0f5VLAcoqiXcRVxQHGNU4O8Z1PJqVt3ICISNU09eldhE/8d5GARl2TCV14pvjpyKPP mcjVjA5Yvs34vKDOmVmdNcijq5uGmagGpN/vi0a5gzUZiFhCXXMJeDa/jrmvpm08RPb+ /Sm2cA0q0gP1cQc7SXcKazs6PA7qQSwLDp77KDbfbQwWvuD6e/8l1wnnQceps0by3O2Y 2tkQ== X-Gm-Message-State: AOAM530zX8w/af0LTOlfPSd61CDHuveLjal50MKdSryeuuiZ3mlm+H2i q1rUJLFxLJcKmoXJmr2sMHWdiam+jpGDJOO9ASg= X-Google-Smtp-Source: ABdhPJzIXkJVvDhLwFX1ARUU8mtpCzq9VTmjBd6JQhlCMg9ID1AyioP6mhJJ2XBj6nVE6eoFrNsRgaLgO0TsCsULEdY= X-Received: by 2002:a05:620a:2049:: with SMTP id d9mr13093079qka.449.1590099049726; Thu, 21 May 2020 15:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20200521152301.2587579-1-hch@lst.de> <20200521152301.2587579-13-hch@lst.de> In-Reply-To: <20200521152301.2587579-13-hch@lst.de> From: Andrii Nakryiko Date: Thu, 21 May 2020 15:10:38 -0700 Message-ID: Subject: Re: [PATCH 12/23] bpf: handle the compat string in bpf_trace_copy_string better To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Networking , bpf , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 21, 2020 at 8:24 AM Christoph Hellwig wrote: > > User the proper helper for kernel or userspace addresses based on > TASK_SIZE instead of the dangerous strncpy_from_unsafe function. > > Signed-off-by: Christoph Hellwig > --- Acked-by: Andrii Nakryiko > kernel/trace/bpf_trace.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > [...]