From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE524C63697 for ; Sat, 21 Nov 2020 10:16:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C93222202 for ; Sat, 21 Nov 2020 10:16:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JF3p/OCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C93222202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0F1276B005C; Sat, 21 Nov 2020 05:16:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A27C6B005D; Sat, 21 Nov 2020 05:16:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED2D46B0068; Sat, 21 Nov 2020 05:16:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id BE39E6B005C for ; Sat, 21 Nov 2020 05:16:26 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5AD9B180AD82F for ; Sat, 21 Nov 2020 10:16:26 +0000 (UTC) X-FDA: 77508020772.28.beds76_1a10bb027353 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 3A9436D67 for ; Sat, 21 Nov 2020 10:16:26 +0000 (UTC) X-HE-Tag: beds76_1a10bb027353 X-Filterd-Recvd-Size: 5617 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Nov 2020 10:16:25 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id 92so8193054otd.5 for ; Sat, 21 Nov 2020 02:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CfD4qCQ+49oMsxdJc7IK/6WOEpohcQtenHzH8FlfyRE=; b=JF3p/OCNodcLdDTJcqO7kRZDP5iwZv+x0xXQK41LiD+SZKTO1SnD9F9TC3ONOFKuZG U4kABs3ZPIz7naEfwag/JiTvqG/9+wKV3HIQM/JyXRXZbLmnr9VNbqi6La5leghgCv9w TsG6VVC+LRSJW222Wda3AxWmLqjBK2bKcBCkoqvrKE2qLqoz1EGwEU5hPuDEqagSt5iA 5GZdeoJmodruZrfdZjri+bhkm7p/XQP78OfvW0H3afh1XJQlnJl6JCYE84SwDTPFNinm 50CwSd9Ln5buo9sziidETyMtEhq6hsXmLswyKqfmg3EGTVLJAjzxlfk7jIDsfMipzhuo xcsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CfD4qCQ+49oMsxdJc7IK/6WOEpohcQtenHzH8FlfyRE=; b=r/WbcAd0h6mbzkCGL026xW5NqJ+p9p4wr5DU1qvSj1FonMIPcTYLLmWtMnQnJ6+lPh i2KuA+sz8AyMwnSozUbnf0WQXNslzvFuhPrhgzUbgXXdxbE7L6F5U2G0b+vqw/tpogKU 6OXlOzpJfg1DqgbTTeIhdOLusNWoKFcK7dMyUKbHFdm71VEmhpPXYSdK0lNcoFt+uv2d p0z+uq46xORzuEnXqHmq/qeMckDlTnJ0dUAUrDjVMkQdMUIA0xlrD15DF0g6TRTXMve4 N8zmYZWOKdbnKCTvst2xObB/4uzkRgG+uxLRc18xkkxoeyCg6HUo0p+C+a4wRaTjFSEZ 0qnQ== X-Gm-Message-State: AOAM531E2STEWi1Uq4Un/qmkpq/okqxXykmswdhAJ1ugm8UFgMNXKfMC 6hDnnZCYN/U56z3R8mklM83zufCQZ4gXyYAB1kE= X-Google-Smtp-Source: ABdhPJwbWqIY6E2BNtMA32fQAIHCjlUN6aHKKi/wWDD0jzHnOSkXJPtriY6z17kkUPmnf3jQjaq/XzOLnrNEouBrIQ0= X-Received: by 2002:a05:6830:210a:: with SMTP id i10mr16558234otc.145.1605953785126; Sat, 21 Nov 2020 02:16:25 -0800 (PST) MIME-Version: 1.0 References: <20201119144146.1045202-1-daniel.vetter@ffwll.ch> <20201119144146.1045202-5-daniel.vetter@ffwll.ch> In-Reply-To: <20201119144146.1045202-5-daniel.vetter@ffwll.ch> From: Oded Gabbay Date: Sat, 21 Nov 2020 12:15:58 +0200 Message-ID: Subject: Re: [PATCH v6 04/17] misc/habana: Use FOLL_LONGTERM for userptr To: Daniel Vetter Cc: DRI Development , LKML , KVM list , linux-mm , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-samsung-soc , Linux Media Mailing List , Daniel Vetter , Jason Gunthorpe , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dan Williams , Omer Shpigelman , Ofir Bitton , Tomer Tayar , Moti Haimovski , Greg Kroah-Hartman , Pawel Piskorski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 19, 2020 at 4:41 PM Daniel Vetter wrot= e: > > These are persistent, not just for the duration of a dma operation. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Oded Gabbay > Cc: Omer Shpigelman > Cc: Ofir Bitton > Cc: Tomer Tayar > Cc: Moti Haimovski > Cc: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Pawel Piskorski > Signed-off-by: Daniel Vetter > --- > drivers/misc/habanalabs/common/memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/haban= alabs/common/memory.c > index 0b220221873d..d08c41b90fec 100644 > --- a/drivers/misc/habanalabs/common/memory.c > +++ b/drivers/misc/habanalabs/common/memory.c > @@ -1298,7 +1298,8 @@ static int get_user_memory(struct hl_device *hdev, = u64 addr, u64 size, > return -ENOMEM; > } > > - rc =3D pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE= , > + rc =3D pin_user_pages_fast(start, npages, > + FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, > userptr->pages); > > if (rc !=3D npages) { > -- > 2.29.2 > This patch and the previous one (03/17 misc/habana: Stop using frame_vector helpers) are both: Reviewed-by: Oded Gabbay Thanks, Oded