From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA07CC35257 for ; Fri, 2 Oct 2020 19:22:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22206206DB for ; Fri, 2 Oct 2020 19:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyCYGPD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22206206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D9716B005C; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AF96B005D; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09F206B0062; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id D24E56B005C for ; Fri, 2 Oct 2020 15:22:16 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 61EF9180AD807 for ; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) X-FDA: 77327956272.10.push76_6010b23271a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 2921116A0DE for ; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) X-HE-Tag: push76_6010b23271a6 X-Filterd-Recvd-Size: 7324 Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 19:22:15 +0000 (UTC) Received: by mail-oo1-f66.google.com with SMTP id z1so623205ooj.3 for ; Fri, 02 Oct 2020 12:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=pyCYGPD3z231H+FQCXNEMLBtwRoKmxKBpFEKm871TgQU8g0X8z2LzGq3oGkeS5tId6 2OjBG9lDxg08oGQpJZn5YUoFRjrDuVdqQVFb4w+hBOrxNG6DqBJwawSIiKC9egvCjB02 Xw0waBU/U8aGynIrCK89k3Jdpw7z3gEFzB4jasOXhXEyNbxDcZrLX7dRpFGKQoKw1Tws aLL3JDgghZLFX8ZY8jZDZOeRMejsM+55Cdtpn64aGJMuNlg/C9MwjlV2q4dNBpKlf7yk 7CMS1H3Bkbl6Ac+k8YwG1V0D40n/6TqKugG/Uh9B1bMTgFcoERjMQ390o1uoJ6zqs1ZP ObOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=lIghkGmEOox2GW/pLiSNgxfTXySGQyR1LKeoUDKC5UgKAVWZv3LU19TjIw2JsSDLMF rovmyj0/uOXE2KKN05Bp1pUqTl3KS4OvoiniQp40/404H9dk1n6P88wjtX1paj1twL2y OrUTbgcTm1y1bbShzXkZRuWrNP5V63Sv5IqzIeatbGA/QMrfBq/fOyw6tQMiXfXr9cWL WVjHo7fmi3GGfxFzNdNcphUwqGdV91VP/Ojt6CLnObc4RRTXWMadV318/feuGx88IfSa wwnRj3tGC+w1LuFBjqPrjVHIdPAyu0gzGn44ngYqeu0CaXb2yc5O5ivz+wdmByGm+NNv fgTQ== X-Gm-Message-State: AOAM5309eEjBrCVCiHBFYWhGjWv1AfrXOz5nvbOUP5s6V5C2xBWNwl0F AtpV/pcJM6uvPC5MZuybD0hY86kPAJvhSk4+IrI= X-Google-Smtp-Source: ABdhPJx7YX8zviFjrOEhTKLkYmCq2KlFovtI8luMYDcSxruAN3b9De/JFEEiXwNOCHvtvZ+X9imhz+Hlu9vqUFcQCHI= X-Received: by 2002:a4a:d509:: with SMTP id m9mr3027482oos.77.1601666534935; Fri, 02 Oct 2020 12:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: From: Oded Gabbay Date: Fri, 2 Oct 2020 22:21:47 +0300 Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Tomasz Figa Cc: Daniel Vetter , DRI Development , LKML , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Pawel Osciak , Marek Szyprowski , Andrew Morton , Omer Shpigelman , Tomer Tayar , Greg Kroah-Hartman , Pawel Piskorski , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-samsung-soc , Linux Media Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. > > > > So just simplify this. > > > > Signed-off-by: Daniel Vetter > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Tomasz Figa > > Cc: Andrew Morton > > Cc: Oded Gabbay > > Cc: Omer Shpigelman > > Cc: Tomer Tayar > > Cc: Greg Kroah-Hartman > > Cc: Pawel Piskorski > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-mm@kvack.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > > drivers/misc/habanalabs/common/memory.c | 3 +-- > > include/linux/mm.h | 2 +- > > mm/frame_vector.c | 4 ++-- > > 5 files changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > index 967a5cdc120e..ac452842bab3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > > goto err_free; > > } > > > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > > if (ret != npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n"); > > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > > index 6e9e05153f4e..9dd6c27162f4 100644 > > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > unsigned long first, last; > > unsigned long nr; > > struct frame_vector *vec; > > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > > > first = start >> PAGE_SHIFT; > > last = (start + length - 1) >> PAGE_SHIFT; > > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > vec = frame_vector_create(nr); > > if (!vec) > > return ERR_PTR(-ENOMEM); > > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > > if (ret < 0) > > goto out_destroy; > > /* We accept only complete set of PFNs */ > > For drivers/media/common/videobuf2/: > > Acked-by: Tomasz Figa > > Best regards, > Tomasz For drivers/misc/habanalabs: Acked-by: Oded Gabbay Thanks, Oded