From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FECC433E1 for ; Thu, 27 Aug 2020 19:14:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED73620707 for ; Thu, 27 Aug 2020 19:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CzK5MevC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED73620707 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94B598E0003; Thu, 27 Aug 2020 15:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FC486B0006; Thu, 27 Aug 2020 15:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839E08E0003; Thu, 27 Aug 2020 15:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 6D0AF6B0003 for ; Thu, 27 Aug 2020 15:14:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2EDC1365C for ; Thu, 27 Aug 2020 19:14:40 +0000 (UTC) X-FDA: 77197300320.28.iron39_0b183b32706f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id F09E36C05 for ; Thu, 27 Aug 2020 19:14:39 +0000 (UTC) X-HE-Tag: iron39_0b183b32706f X-Filterd-Recvd-Size: 6511 Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 19:14:39 +0000 (UTC) Received: by mail-yb1-f194.google.com with SMTP id u6so3578572ybf.1 for ; Thu, 27 Aug 2020 12:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8EbCOeZ1KrDUva8Qo9ruBWoAtdzcTodwXUPT6QjLJgQ=; b=CzK5MevCoTJjSYEKsR6BXPClIs48eH9pjn6p7fKUCBn5JS6ZcYj7+wuJVw63jDYkJm zWBhJ/lu6AJgQP7W+lQVNnVjfA1GhaNAwSoc/7j4N4ysvalHprcpTMCgTFCsERwCEK3J ZlUkGW7sKCTG7SMpWyt6WwFMcHSZIDUuxWzSSVTJ29v8jeP2+3X070RVHhD2opTeQPIu 5hqe5nAc2dApnbSaGk9LbKUyUgf6e6bDL5xmrdM7Hc0WVjjAQOXFc9/rV2MZYCdAan9+ 0wHMAE7RqUcmSgEQezkLSqEt+nozFbyVnJi0BzlX1QdVJrL37eqS7KWadSAmRYvSk+U/ ZaEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8EbCOeZ1KrDUva8Qo9ruBWoAtdzcTodwXUPT6QjLJgQ=; b=LZPIs6Wb/es25ViZIPrSDpUPP+ddnd/34+2sdIMWwwA2Y67yQ12sRb18KHAuFDvFiV SXMIl7JQjxp+ar675sjcYybNhkVe72Fhnbdc3HVXnHPo81hk4GnGjcgZ3Djur3ALHsnB 370GLi3iMFqLqqQyPoDp62WXvbCuqTgRgzkO8HIOCCrkQPjXLMHLQlXWeO8xe49xCVEK qb19PeHvpccpoZ0Ya4k/Y07O/vUJ8Dm2toty1WQglEAxe4Izmz0W6EfAHxr8tLF4/ZjW 83BU9pTJj6leRjxwqs7WqJhdNNZxqoM6hNgJZXv7T+1JwhhsLPQ3WgxPXqDMb6Bk7wXv sGJw== X-Gm-Message-State: AOAM532PhNfk0iZ/B2rIddeGheKtAL7PN8SEoGsoqUticrRSsq8ysap9 hI6y8Qiq1FK49x/wvJwOZTlf95OZ9auGzYPxKAY/fQ== X-Google-Smtp-Source: ABdhPJxkQYG/edhUcGiwy3weZ87oxUfXXeGP9hZPA0qzfNe8+TonDNIFV26AsiWzge2Pm7kQqIj8Thn+X/uM5A/BanI= X-Received: by 2002:a5b:744:: with SMTP id s4mr32088872ybq.26.1598555678461; Thu, 27 Aug 2020 12:14:38 -0700 (PDT) MIME-Version: 1.0 References: <20200827095429.GC29264@gaia> <20200827131045.GM29264@gaia> <20200827145642.GO29264@gaia> In-Reply-To: <20200827145642.GO29264@gaia> From: Evgenii Stepanov Date: Thu, 27 Aug 2020 12:14:26 -0700 Message-ID: Subject: Re: [PATCH 21/35] arm64: mte: Add in-kernel tag fault handler To: Catalin Marinas Cc: Andrey Konovalov , Vincenzo Frascino , Dmitry Vyukov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F09E36C05 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 7:56 AM Catalin Marinas wrote: > > On Thu, Aug 27, 2020 at 03:34:42PM +0200, Andrey Konovalov wrote: > > On Thu, Aug 27, 2020 at 3:10 PM Catalin Marinas wrote: > > > On Thu, Aug 27, 2020 at 02:31:23PM +0200, Andrey Konovalov wrote: > > > > On Thu, Aug 27, 2020 at 11:54 AM Catalin Marinas > > > > wrote: > > > > > On Fri, Aug 14, 2020 at 07:27:03PM +0200, Andrey Konovalov wrote: > > > > > > +static int do_tag_recovery(unsigned long addr, unsigned int esr, > > > > > > + struct pt_regs *regs) > > > > > > +{ > > > > > > + report_tag_fault(addr, esr, regs); > > > > > > + > > > > > > + /* Skip over the faulting instruction and continue: */ > > > > > > + arm64_skip_faulting_instruction(regs, AARCH64_INSN_SIZE); > > > > > > > > > > Ooooh, do we expect the kernel to still behave correctly after this? I > > > > > thought the recovery means disabling tag checking altogether and > > > > > restarting the instruction rather than skipping over it. > [...] > > > > Can we disable MTE, reexecute the instruction, and then reenable MTE, > > > > or something like that? > > > > > > If you want to preserve the MTE enabled, you could single-step the > > > instruction or execute it out of line, though it's a bit more convoluted > > > (we have a similar mechanism for kprobes/uprobes). > > > > > > Another option would be to attempt to set the matching tag in memory, > > > under the assumption that it is writable (if it's not, maybe it's fine > > > to panic). Not sure how this interacts with the slub allocator since, > > > presumably, the logical tag in the pointer is wrong rather than the > > > allocation one. > > > > > > Yet another option would be to change the tag in the register and > > > re-execute but this may confuse the compiler. > > > > Which one of these would be simpler to implement? > > Either 2 or 3 would be simpler (re-tag the memory location or the > pointer) with the caveats I mentioned. Also, does the slab allocator > need to touch the memory on free with a tagged pointer? Otherwise slab > may hit an MTE fault itself. Changing the memory tag can cause faults in other threads, and that could be very confusing. Probably the safest thing is to retag the register, single step and then retag it back, but be careful with the instructions that change the address register (like ldr x0, [x0]). > > > Perhaps we could somehow only skip faulting instructions that happen > > in the KASAN test module?.. Decoding stack trace would be an option, > > but that's a bit weird. > > If you want to restrict this to the KASAN tests, just add some > MTE-specific accessors with a fixup entry similar to get_user/put_user. > __do_kernel_fault() (if actually called) will invoke the fixup code > which skips the access and returns an error. This way KASAN tests can > actually verify that tag checking works, I'd find this a lot more > useful. > > -- > Catalin