From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04B4C433E0 for ; Mon, 22 Jun 2020 22:01:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91AAF20767 for ; Mon, 22 Jun 2020 22:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nKrUDlJ7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91AAF20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E13F6B0006; Mon, 22 Jun 2020 18:01:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26BE46B0007; Mon, 22 Jun 2020 18:01:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133216B000C; Mon, 22 Jun 2020 18:01:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id EA12A6B0006 for ; Mon, 22 Jun 2020 18:01:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 617BA1543B7 for ; Mon, 22 Jun 2020 22:01:05 +0000 (UTC) X-FDA: 76958218890.02.knot17_40035ad26e36 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 5CD5320001FE81D4 for ; Mon, 22 Jun 2020 22:00:51 +0000 (UTC) X-HE-Tag: knot17_40035ad26e36 X-Filterd-Recvd-Size: 4678 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 22:00:50 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id v19so11478536qtq.10 for ; Mon, 22 Jun 2020 15:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rbwmv8Z/FP9ApAgbdwjt0jN7D1r57JUmODU4nLA9Mcw=; b=nKrUDlJ7NDzZ8GaINJaqizcT2hUYM1B1AOlOLE5hLf2MkYHTa+JsOUWbm9L6OKsRO6 BAq2ynKZpJKaTqMDiZOyAsJXS8n8XbyM00GCctUp8qkzaHZETysYgvhuQt+8x9J/OMDQ NDa1SlTFEPPbJhY5rE4Dq09q/fIFj+83HTEat5Gz5lU4LYvx6OmHDEggXu/2if8NR8vi QzNYHmrG0xCS6HMsmMAIqEdAk0UMIqieoCUakd+ddd4S1GERmhDeQno+fVC1YEzDkG8f J5Jy+QRr8KhtDf7K029eNhajQyRVq4rAHT5wHjQ246Pyrmpl7dvHNxcYAQgI9A4AleDX UQZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rbwmv8Z/FP9ApAgbdwjt0jN7D1r57JUmODU4nLA9Mcw=; b=pItR7KIZIHVFzeR+iACA0d1Wg497EFqmR8kVpj0ZAmbOgYT0G4ujCUUd5us6qx1KmS AJcGXCweYvNnbstfT5QWTJ619PU8jXshTGPBEXdBte2/DWmZft2w2yqEU2zytNYa9l3c euxdyKUwSQL/P7LhVwMNyhYJ5KoRJg1oNaeRy8f+dTFE15iM1TMB0dtVFZUtvIcC5Xg+ JNTBhreJ7vY7qh68ZYXOC5FOD9EjtRMtYqIEK73+DoohT6TbQRf30Bb1rHTNPFETbVdd /3JmreOj3UeoTlZPAs57aUIQ+Ej6zBG6WEVe+KJq81lW8fxEH++D8117QGyCw8ZZuIZX e7Gg== X-Gm-Message-State: AOAM532QIniVymoIBg4MUlgLnyoOJ9MhhimP/Rng6gSp10dvryvzUJJY x7RdGFTVOu08jMwF0eDK+/g+SFkRJmx591LOgAI= X-Google-Smtp-Source: ABdhPJyQpreJkF/hhbWDo7VT/jh/R4iAx7O6bLCYL2yAbMWc51SRvtco/EIZHB+pJK+3kFoGtNuigG9tWLHVONVsNCE= X-Received: by 2002:ac8:5188:: with SMTP id c8mr18989475qtn.1.1592863250268; Mon, 22 Jun 2020 15:00:50 -0700 (PDT) MIME-Version: 1.0 References: <20200621043737.pb6JV%akpm@linux-foundation.org> <20a39fd4-622d-693c-c8d6-1fbab12af62a@gmail.com> <202006221445.36E03CCBE9@keescook> In-Reply-To: <202006221445.36E03CCBE9@keescook> From: Richard Weinberger Date: Tue, 23 Jun 2020 00:00:39 +0200 Message-ID: Subject: Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c) To: Kees Cook Cc: Randy Dunlap , Andrew Morton , Mark Brown , Michal Hocko , Stephen Rothwell , Linux Next Mailing List , linux-fsdevel , linux-mm@kvack.org, LKML , mm-commits@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , linux-um Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5CD5320001FE81D4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 22, 2020 at 11:51 PM Kees Cook wrote: > > On Mon, Jun 22, 2020 at 08:37:17AM -0700, Randy Dunlap wrote: > > On 6/20/20 9:37 PM, akpm@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2020-06-20-21-36 has been uploaded to > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > mmotm-readme.txt says > > > > > > README for mm-of-the-moment: > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > > more than once a week. > > > > drivers/misc/lkdtm/bugs.c has build errors when building UML for i386 > > (allmodconfig or allyesconfig): > > > > > > In file included from ../drivers/misc/lkdtm/bugs.c:17:0: > > ../arch/x86/um/asm/desc.h:7:0: warning: "LDT_empty" redefined > > #define LDT_empty(info) (\ > > > > In file included from ../arch/um/include/asm/mmu.h:10:0, > > from ../include/linux/mm_types.h:18, > > from ../include/linux/sched/signal.h:13, > > from ../drivers/misc/lkdtm/bugs.c:11: > > ../arch/x86/um/asm/mm_context.h:65:0: note: this is the location of the previous definition > > #define LDT_empty(info) (_LDT_empty(info)) > > The LKDTM test landed a while ago: > b09511c253e5 ("lkdtm: Add a DOUBLE_FAULT crash type on x86") > > and nothing has touched arch/x86/um/asm/desc.h nor > arch/x86/um/asm/mm_context.h in a while either. > > Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? True that, we can rip the file. -- Thanks, //richard