From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F37C433E2 for ; Mon, 20 Jul 2020 11:58:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8890622CF6 for ; Mon, 20 Jul 2020 11:58:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pzO5UY59" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8890622CF6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EBE6F6B0003; Mon, 20 Jul 2020 07:58:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6FC36B0005; Mon, 20 Jul 2020 07:58:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5DA96B0006; Mon, 20 Jul 2020 07:58:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id BE0496B0003 for ; Mon, 20 Jul 2020 07:58:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1AECD183F13B4 for ; Mon, 20 Jul 2020 11:58:35 +0000 (UTC) X-FDA: 77058306990.28.aunt89_3c1238326f24 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id DE8582DFAC8F for ; Mon, 20 Jul 2020 11:58:34 +0000 (UTC) X-HE-Tag: aunt89_3c1238326f24 X-Filterd-Recvd-Size: 3399 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 11:58:34 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id q2so4038997qkc.8 for ; Mon, 20 Jul 2020 04:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oyadEz0eZwOz4veMiu/99Xwk84Lj2bAOI1P6STGAbTM=; b=pzO5UY59E2I78nkbHVVchIb8xSq5dpsUcOpNS7Gkxof5sNSjCEODEhGzsvVVjAfJyl VSwzSp6U1Zs9krrRKUF/u2Bk2AkyMb7A4vyZNN5lBySozBpWv75kuuSymSQ75I0lOQIq /aNfumnu9UNKeQqzNIgsFnNCRnWlLEXCl5HKsdcBqoLY2AX4WupdTDUkutMtkReFDd/p 7rLcMb8CsQvVO2aMkGCvC0cISIr9opF8PILSUSavYLWpTTSmyGJ8atrT4DsGICF1czPS GjukeM8re+7Is53uuqLc1gz9fVVpsyasqxmhyXdVNJb4jwNSaNcNEMbvPaz5r/mI8alC KLmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oyadEz0eZwOz4veMiu/99Xwk84Lj2bAOI1P6STGAbTM=; b=e6jX9a61jTcsSgABQnsxgBYT+xESJRd+jWAM4XrjhEQL82l6TDtiEHQ14zYMMdia6P X9KyBLZuLriQXo04nafzhQ6PQ3e4zc0ZDHtOrE2IBGFKqe0l/evdyyxmXPDpcpqCtvpo WgV+cnnJx/Il48nzclfmtzJzT+4X1yMquQgMf8TytZuWmGwDvy3OVQ5dXAWe31rercCp A/19GvEPAVZSxBXng8IQbJLnSfCCJ7j6YuPzy/WZtFM4PoeRseVL9MWMbrdTEWrghaty 2968i5CFP0OO+GLa03YOXhToc/29+19mdsOXxne2wdX8CD8KBiCJuKeXEp8GIrtFJ6vS HDuA== X-Gm-Message-State: AOAM531ubE2PWf/MLd7DuGqJ4xdcKaKMWL+wj/j5CmH/WQFiTLLg4fDP 0OvlhYQSR15FrWNLcHEyd4kCDlVbQOgWfSDWXbg= X-Google-Smtp-Source: ABdhPJxZvpi5p/rGIGspu/X0VuST2fAly2yyAucRwLGlbJciYxHfYOGN4y9O3LRxtfeMHSSpDlexGGV5rTPgQNTp1kc= X-Received: by 2002:a37:9147:: with SMTP id t68mr20753351qkd.34.1595246313907; Mon, 20 Jul 2020 04:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-5-hch@lst.de> In-Reply-To: <20200720075148.172156-5-hch@lst.de> From: Richard Weinberger Date: Mon, 20 Jul 2020 13:58:22 +0200 Message-ID: Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , linux-mtd@lists.infradead.org, device-mapper development , linux-block@vger.kernel.org, LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , linux-mm@kvack.org, cgroups mailinglist Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DE8582DFAC8F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Chrstoph, On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > Set up a readahead size by default. This changes behavior for mtd, > ubifs, and vboxsf to actually enabled readahead, the lack of which > very much looks like an oversight. UBIFS doesn't enable readahead on purpose, please see: http://www.linux-mtd.infradead.org/doc/ubifs.html#L_readahead -- Thanks, //richard