From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8334DC10DCE for ; Tue, 24 Mar 2020 03:55:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4564020714 for ; Tue, 24 Mar 2020 03:55:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S8Cd6POG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4564020714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C309B6B00C5; Mon, 23 Mar 2020 23:55:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE1F36B00C7; Mon, 23 Mar 2020 23:55:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACFBD6B00C8; Mon, 23 Mar 2020 23:55:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 933DC6B00C5 for ; Mon, 23 Mar 2020 23:55:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AD39F2F246 for ; Tue, 24 Mar 2020 03:55:26 +0000 (UTC) X-FDA: 76628891052.03.metal73_126508dbb185a X-HE-Tag: metal73_126508dbb185a X-Filterd-Recvd-Size: 3374 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 03:55:26 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id r5so10783546ilq.6 for ; Mon, 23 Mar 2020 20:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JJRiCmmFo9bGphYyrKjEyWWgr0u7dOf9nHP+uKUbtDc=; b=S8Cd6POGQacUcbCxlO8CxTUwlxw6LJhhsJp/pyb6SFxlm5TWM2e7sybSjUbcDgHGol Orgbf1NasyXOSautsMjC9++j4UBcptZe+dIBB/Z92S6QFUoHTTvAMkCZDFZndimnx5df Cmt/H6XqybzjPTmPMGyaHYxKZHoY0hhjKkpchPFXDo3pFWG1Nh5+HI3oRss7cjIvJpZi ezWnNQ+d5IT2C4Y+q7r7Oy+6twpZu3ZznRfJKEMGOqoGgrlSJ/nQQu1StCUmqbkkuO+R epwEBV5XNN0OLNMs2wDUgITFVW2+yuBuPARQ82QThxObgyuvuHlkY2iuFf87HNpUgvJG C+1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JJRiCmmFo9bGphYyrKjEyWWgr0u7dOf9nHP+uKUbtDc=; b=HA/aNyqvEmnn0vQxfuGbKyzyTBCao6C7QtSuJbIfpdI79fTtiSGg00wS39aOXHEts5 HDhsi4UHU1B0kzDQktwB2dLELgYjl6t8levOaKORVt6bVIfa/qZINg01nZwhn3mIxALC qZqxyMeNht0RooVkFVvBx1C8M0FDJCFcCEnXtFtk9N0Dsst0R5TGfL1qh6gLDnvLzjBc UW6CRicoPTn991nzMnKSHyPQ4gPUDETBgW4Xgd+mfnPsmuFE3oXxF49IZaUVcTmGZOQi BP2zmCbywBD3xJS3DK0InwtUUkPLWYWDAHM8snJGN/PTxsDHNjoXdPnut/v+2/ImqC0v 7Ttw== X-Gm-Message-State: ANhLgQ2t/tJNpDEaaAPNXrutJe+EOKIDYA9w5kXgEs6ed48ASjYyfkTh b13VBquLNl53pi6RRqfXKi7+he68oFz69xX8Rg== X-Google-Smtp-Source: ADFU+vvy25FlBHzV45OfLqgeUNkBSHgZlcSIyqJt2Mqmwpk3Hwtz2AOdfP4pjjgwuo1xi15o+zbGdI47ccK4I7bQhMc= X-Received: by 2002:a92:250e:: with SMTP id l14mr24408278ill.201.1585022125313; Mon, 23 Mar 2020 20:55:25 -0700 (PDT) MIME-Version: 1.0 References: <1584885427-4952-1-git-send-email-kernelfans@gmail.com> <08df8238-d894-a748-05c0-ff4fd90d2984@gmail.com> In-Reply-To: <08df8238-d894-a748-05c0-ff4fd90d2984@gmail.com> From: Pingfan Liu Date: Tue, 24 Mar 2020 11:55:14 +0800 Message-ID: Subject: Re: [PATCH] mm/rmap: fix the handling of device private page in try_to_unmap_one() To: Balbir Singh Cc: Linux-MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Michal Hocko , John Hubbard , "Kirill A . Shutemov" , Aneesh Kumar , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 24, 2020 at 8:04 AM Balbir Singh wrote: > > On 23/3/20 12:57 am, Pingfan Liu wrote: > > For zone_device, migration can only happen on is_device_private_page(page). > > Correct the logic in try_to_unmap_one(). > > !DEVICE_PRIVATE implies it's a cache coherent page and we shouldn't bail > out - Could you clarify what issue your fixing? As I replied to Michal, I tried to fix the code logic, but not really hit a bug. Thanks, Pingfan