Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling

From: Matteo Croce <mcroce@linux.microsoft.com>
To: netdev@vger.kernel.org, linux-mm@kvack.org
Cc: Ayush Sawal <ayush.sawal@chelsio.com>,
	Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
	 Rohit Maheshwari <rohitm@chelsio.com>,
	"David S. Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Marcin Wojtas <mw@semihalf.com>,
	Russell King <linux@armlinux.org.uk>,
	 Mirko Lindner <mlindner@marvell.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	 Tariq Toukan <tariqt@nvidia.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>,
	 Boris Pismenny <borisp@nvidia.com>,
	Arnd Bergmann <arnd@arndb.de>,
	 Andrew Morton <akpm@linux-foundation.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	 Vlastimil Babka <vbabka@suse.cz>, Yu Zhao <yuzhao@google.com>,
	Will Deacon <will@kernel.org>,  Fenghua Yu <fenghua.yu@intel.com>,
	Roman Gushchin <guro@fb.com>, Hugh Dickins <hughd@google.com>,
	 Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	 Jonathan Lemon <jonathan.lemon@gmail.com>,
	Alexander Lobakin <alobakin@pm.me>,
	 Cong Wang <cong.wang@bytedance.com>, wenxu <wenxu@ucloud.cn>,
	 Kevin Hao <haokexin@gmail.com>,
	Jakub Sitnicki <jakub@cloudflare.com>,
	 Marco Elver <elver@google.com>,
	Willem de Bruijn <willemb@google.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	 Yunsheng Lin <linyunsheng@huawei.com>,
	Guillaume Nault <gnault@redhat.com>,
	linux-kernel@vger.kernel.org,  linux-rdma@vger.kernel.org,
	bpf@vger.kernel.org,  Matthew Wilcox <willy@infradead.org>,
	Eric Dumazet <edumazet@google.com>,
	 David Ahern <dsahern@gmail.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	 Saeed Mahameed <saeedm@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
	Paolo Abeni <pabeni@redhat.com>,
	 Sven Auhagen <sven.auhagen@voleatech.de>
Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling
Date: Thu, 3 Jun 2021 20:45:19 +0200	[thread overview]
Message-ID: <CAFnufp2Qbq53rT17eZD97tm3o5OFJeHEDAyaW8VhVcy4u+KeNQ@mail.gmail.com> (raw)
In-Reply-To: <20210521161527.34607-4-mcroce@linux.microsoft.com>

On Fri, May 21, 2021 at 6:16 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:
> +bool page_pool_return_skb_page(void *data)
> +{
> +       struct page_pool *pp;
> +       struct page *page;
> +
> +       page = virt_to_head_page(data);
> +       if (unlikely(page->pp_magic != PP_SIGNATURE))
> +               return false;
> +
> +       pp = (struct page_pool *)page->pp;
> +
> +       /* Driver set this to memory recycling info. Reset it on recycle.
> +        * This will *not* work for NIC using a split-page memory model.
> +        * The page will be returned to the pool here regardless of the
> +        * 'flipped' fragment being in use or not.
> +        */
> +       page->pp = NULL;
> +       page_pool_put_full_page(pp, virt_to_head_page(data), false);

Here I could just use the cached "page" instead of calling
virt_to_head_page() once again.

-- 
per aspera ad upstream