Re: [kwiboo-linux-rockchip:rockchip-5.1-v4l2-from-5.3-v5.1.5 77/88] drivers/media/common/videobuf2/videobuf2-dma-sg.c:338:8: error: implicit declaration of function 'vm_map_pages'

From: Souptick Joarder <jrdr.linux@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Jonas Karlman <jonas@kwiboo.se>,
	 Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [kwiboo-linux-rockchip:rockchip-5.1-v4l2-from-5.3-v5.1.5 77/88] drivers/media/common/videobuf2/videobuf2-dma-sg.c:338:8: error: implicit declaration of function 'vm_map_pages'
Date: Sun, 26 May 2019 20:58:53 +0530	[thread overview]
Message-ID: <CAFqt6zZbZBhbsZNJj23DjyANfJHFLNQ_hG2bytd0EbHuHkrhEA@mail.gmail.com> (raw)
In-Reply-To: <201905261747.2U99rlcY%lkp@intel.com>

Hi Jonas,

On Sun, May 26, 2019 at 2:59 PM kbuild test robot <lkp@intel.com> wrote:
>
> tree:   https://github.com/Kwiboo/linux-rockchip rockchip-5.1-v4l2-from-5.3-v5.1.5
> head:   478d6e4e03edc3c39e4e9096777533a65b2714d6
> commit: d86645f8d79fcc8209e0ec9367a9170e51900938 [77/88] videobuf2/videobuf2-dma-sg.c: convert to use vm_map_pages()
> config: x86_64-randconfig-i1-05231812 (attached as .config)
> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
> reproduce:
>         git checkout d86645f8d79fcc8209e0ec9367a9170e51900938
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/media/common/videobuf2/videobuf2-dma-sg.c: In function 'vb2_dma_sg_mmap':
> >> drivers/media/common/videobuf2/videobuf2-dma-sg.c:338:8: error: implicit declaration of function 'vm_map_pages' [-Werror=implicit-function-declaration]
>      err = vm_map_pages(vma, buf->pages, buf->num_pages);
>            ^~~~~~~~~~~~
>    cc1: some warnings being treated as errors

Same here. Looking into
https://github.com/Kwiboo/linux-rockchip/blob/rockchip-5.1-v4l2-from-5.3-v5.1.5/mm/memory.c
vm_map_pages() API is missing which is merged into 5.2-rc1.
Is the below patch merged into https://github.com/Kwiboo/linux-rockchip ?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.2-rc1&id=a667d7456f189e3422725dddcd067537feac49c0

>
> vim +/vm_map_pages +338 drivers/media/common/videobuf2/videobuf2-dma-sg.c
>
>    327
>    328  static int vb2_dma_sg_mmap(void *buf_priv, struct vm_area_struct *vma)
>    329  {
>    330          struct vb2_dma_sg_buf *buf = buf_priv;
>    331          int err;
>    332
>    333          if (!buf) {
>    334                  printk(KERN_ERR "No memory to map\n");
>    335                  return -EINVAL;
>    336          }
>    337
>  > 338          err = vm_map_pages(vma, buf->pages, buf->num_pages);
>    339          if (err) {
>    340                  printk(KERN_ERR "Remapping memory, error: %d\n", err);
>    341                  return err;
>    342          }
>    343
>    344          /*
>    345           * Use common vm_area operations to track buffer refcount.
>    346           */
>    347          vma->vm_private_data    = &buf->handler;
>    348          vma->vm_ops             = &vb2_common_vm_ops;
>    349
>    350          vma->vm_ops->open(vma);
>    351
>    352          return 0;
>    353  }
>    354
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation