From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECC2C83004 for ; Tue, 28 Apr 2020 05:52:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99DB5206A5 for ; Tue, 28 Apr 2020 05:52:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iPpk6l/j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99DB5206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0743C8E0005; Tue, 28 Apr 2020 01:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 024F18E0001; Tue, 28 Apr 2020 01:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7D1A8E0005; Tue, 28 Apr 2020 01:52:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id D00938E0001 for ; Tue, 28 Apr 2020 01:52:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8D2DC4DAC for ; Tue, 28 Apr 2020 05:52:49 +0000 (UTC) X-FDA: 76756194858.03.shade25_18a16ad4b735e X-HE-Tag: shade25_18a16ad4b735e X-Filterd-Recvd-Size: 4464 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Apr 2020 05:52:49 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id k28so15834385lfe.10 for ; Mon, 27 Apr 2020 22:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3FFyhFGwSR5hCCAOzKWLB8ijhIIWqMIumwJnODZevkI=; b=iPpk6l/jcA1BeDumj4n6myfu973lYILM4XQEUj2U9UO9NMB5cveMhC0qpE7+ppX0Bl NwwXr3ZGwsusuav6BpzkvqFgO+dDUQglvmVXTDQ34IUs8a2xp5D4asH6xNcUEEJimtrk 4mtm5HgQpZnnJB3kKT+YlVYWlQz4UCEN0OFbe/rh+0C7PyKRYbDsrVajTzK6hSclaXf9 o1Q7WzNZJ0dH3MybAy06ZSF5gjc5YwjwPRYVGKunKe3DPdG91fHg0qpIwDWdOtTqhqnc iqMeT2xCdTZTQFZQroCmrRgQNoR1D0MlyHpyegg+Vs7bRSY3iiysohCImS46eC/xpdrW JKcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3FFyhFGwSR5hCCAOzKWLB8ijhIIWqMIumwJnODZevkI=; b=Kn1sYtAZnNXJHzgH5mm1QzT08dLX/k8c/iA7/tC9FE21c+y4wpK43siMpJSLKFvLQS 7t8Uxhb1gW6lJ20WwdA6Obgssr/mBP6yMVe/3KVTWAlLYoH1kmdtTN36iFLWcNIwBfZs dZNbQMQRPgLoBNyA6kuT/tbkIVm1yHxKafikXB8lgAUFvDahE8mH8p8zpHs43bNqyxeC ZUcEFxUFOx/PgU7ibXmQSjWC9H8JZ1i51QNeAgKifLUjQbEoEwLG2NikpydPuqaj5zEh Y9KIXj/3KyGAWsfhgnJXNAUWkJs3MMYFt2G13pKmUySDBxIaQnm/OBlaIEkaflxBXxOA OUvA== X-Gm-Message-State: AGi0Pua4xWIaNdUMebcgLlTNyklLEMIfHd4ZPOVfUXM7BDguHzYjAlM6 dNx+Zpmocabx5CJza1D2fzBO+0e/WnFrEeZt2WgW9Q== X-Google-Smtp-Source: APiQypLsGvxVV4G5Cnrl0vPMdgLPCcQHgc3r4oAY763aqzMS5nENJMiQ8OSQP6fW4gw42184cs8u8oZQg2fi/pBykaA= X-Received: by 2002:ac2:5dc6:: with SMTP id x6mr17919772lfq.108.1588053167164; Mon, 27 Apr 2020 22:52:47 -0700 (PDT) MIME-Version: 1.0 References: <20200428032745.133556-1-jannh@google.com> <20200428032745.133556-3-jannh@google.com> In-Reply-To: From: Jann Horn Date: Tue, 28 Apr 2020 07:52:20 +0200 Message-ID: Subject: Re: [PATCH 2/5] coredump: Fix handling of partial writes in dump_emit() To: Linus Torvalds , Alexander Viro Cc: Andrew Morton , Christoph Hellwig , Linux Kernel Mailing List , Linux-MM , linux-fsdevel , "Eric W . Biederman" , Oleg Nesterov , Russell King , Linux ARM , Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Rich Felker , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 28, 2020 at 5:36 AM Linus Torvalds wrote: > On Mon, Apr 27, 2020 at 8:28 PM Jann Horn wrote: > > > > After a partial write, we have to update the input buffer pointer. > > Interesting. It seems this partial write case never triggers (except > for actually killing the core-dump). > > Or did you find a case where it actually matters? > > Your fix is obviously correct, but it also makes me go "that function > clearly never actually worked for partial writes, maybe we shouldn't > even bother?" Hmm, yeah... I can't really think of cases where write handlers can spuriously return early without having a pending signal, and a second write is likely to succeed... I just know that there are some things that are notorious for returning short *reads* (e.g. pipes, sockets, /proc/$pid/maps). Al's commit message refers to pipes specifically; but even at commit 2507a4fbd48a, I don't actually see where pipe_write() could return a short write without a page allocation failure or something like that. So maybe you're right and we should just get rid of it...