From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: osalvador@techadventures.net
Cc: mhocko@kernel.org, n-horiguchi@ah.jp.nec.com,
Linux Memory Management List <linux-mm@kvack.org>,
osalvador@suse.de, Steven Sistare <steven.sistare@oracle.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
willy@infradead.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
mingo@kernel.org, dan.j.williams@intel.com, ying.huang@intel.com
Subject: Re: [PATCH v3] x86/e820: put !E820_TYPE_RAM regions into memblock.reserved
Date: Fri, 15 Jun 2018 12:02:17 -0400 [thread overview]
Message-ID: <CAGM2reYA=jqL7KO6j9Tcjxyeb_=7aCfyekdO_aaRSZYv7_WeVg@mail.gmail.com> (raw)
In-Reply-To: <20180615143308.GA26321@techadventures.net>
> Hi Pavel,
>
> I think this makes a lot of sense.
> Since Naoya is out until Wednesday, maybe I give it a shot next week and see if I can gather some numbers.
Hi Oscar,
Thank you for the offer to do this. Since, sched_clock() is not yet
initialized at the time zero_resv_unavail() is called, it is difficult
to measure it during boot. But, I had x86 early boot timestamps
patches handy, so I could measure, thus decided to submit the patch.
http://lkml.kernel.org/r/20180615155733.1175-1-pasha.tatashin@oracle.com
Thank you,
Pavel
>
> >
> > Thank you,
> > Pasha
> >
> > >
> > > > ---
> > > > arch/x86/kernel/e820.c | 15 ++++++++++++---
> > > > 1 file changed, 12 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> > > > index d1f25c831447..c88c23c658c1 100644
> > > > --- a/arch/x86/kernel/e820.c
> > > > +++ b/arch/x86/kernel/e820.c
> > > > @@ -1248,6 +1248,7 @@ void __init e820__memblock_setup(void)
> > > > {
> > > > int i;
> > > > u64 end;
> > > > + u64 addr = 0;
> > > >
> > > > /*
> > > > * The bootstrap memblock region count maximum is 128 entries
> > > > @@ -1264,13 +1265,21 @@ void __init e820__memblock_setup(void)
> > > > struct e820_entry *entry = &e820_table->entries[i];
> > > >
> > > > end = entry->addr + entry->size;
> > > > + if (addr < entry->addr)
> > > > + memblock_reserve(addr, entry->addr - addr);
> > > > + addr = end;
> > > > if (end != (resource_size_t)end)
> > > > continue;
> > > >
> > > > + /*
> > > > + * all !E820_TYPE_RAM ranges (including gap ranges) are put
> > > > + * into memblock.reserved to make sure that struct pages in
> > > > + * such regions are not left uninitialized after bootup.
> > > > + */
> > > > if (entry->type != E820_TYPE_RAM && entry->type != E820_TYPE_RESERVED_KERN)
> > > > - continue;
> > > > -
> > > > - memblock_add(entry->addr, entry->size);
> > > > + memblock_reserve(entry->addr, entry->size);
> > > > + else
> > > > + memblock_add(entry->addr, entry->size);
> > > > }
> > > >
> > > > /* Throw away partial pages: */
> > > > --
> > > > 2.7.4
> > >
> > > --
> > > Michal Hocko
> > > SUSE Labs
> > >
> >
>
> Best Regards
> Oscar Salvador
>
next prev parent reply other threads:[~2018-06-15 16:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 0:54 kernel panic in reading /proc/kpageflags when enabling RAM-simulated PMEM Naoya Horiguchi
2018-06-05 1:18 ` Matthew Wilcox
2018-06-05 7:35 ` Naoya Horiguchi
2018-06-06 5:16 ` Naoya Horiguchi
2018-06-06 8:04 ` Oscar Salvador
2018-06-06 8:53 ` Oscar Salvador
2018-06-06 9:06 ` Naoya Horiguchi
2018-06-06 9:24 ` Naoya Horiguchi
2018-06-07 6:22 ` Naoya Horiguchi
2018-06-07 6:59 ` Oscar Salvador
2018-06-07 9:49 ` Oscar Salvador
2018-06-07 10:02 ` Naoya Horiguchi
2018-06-11 9:05 ` Naoya Horiguchi
2018-06-13 5:41 ` [PATCH v1] mm: zero remaining unavailable struct pages (Re: kernel panic in reading /proc/kpageflags when enabling RAM-simulated PMEM) Naoya Horiguchi
2018-06-13 8:40 ` Oscar Salvador
2018-06-14 4:56 ` Naoya Horiguchi
2018-06-13 9:07 ` Michal Hocko
2018-06-14 5:16 ` Naoya Horiguchi
2018-06-14 5:38 ` Oscar Salvador
2018-06-14 6:34 ` [PATCH v2] x86/e820: put !E820_TYPE_RAM regions into memblock.reserved Naoya Horiguchi
2018-06-14 7:21 ` Oscar Salvador
2018-06-14 11:24 ` Oscar Salvador
2018-06-15 0:58 ` Naoya Horiguchi
2018-06-14 21:30 ` Oscar Salvador
2018-06-15 1:09 ` Naoya Horiguchi
2018-06-15 7:29 ` [PATCH v3] " Naoya Horiguchi
2018-06-15 8:41 ` Michal Hocko
2018-06-15 14:00 ` Pavel Tatashin
2018-06-15 14:10 ` Michal Hocko
2018-06-15 14:33 ` Oscar Salvador
2018-06-15 16:02 ` Pavel Tatashin [this message]
2018-06-18 23:36 ` Andrew Morton
2018-06-19 0:49 ` Pavel Tatashin
2018-07-02 20:05 ` Pavel Tatashin
2018-07-02 20:28 ` Andrew Morton
2018-07-02 20:31 ` Pavel Tatashin
2018-06-14 7:00 ` [PATCH v1] mm: zero remaining unavailable struct pages (Re: kernel panic in reading /proc/kpageflags when enabling RAM-simulated PMEM) Michal Hocko
2018-06-15 1:07 ` Naoya Horiguchi
2018-06-15 8:39 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reYA=jqL7KO6j9Tcjxyeb_=7aCfyekdO_aaRSZYv7_WeVg@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=steven.sistare@oracle.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).