From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: Jia He <hejianet@gmail.com>
Cc: linux@armlinux.org.uk,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Hocko" <mhocko@suse.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Mel Gorman" <mgorman@suse.de>,
will.deacon@arm.com, mark.rutland@arm.com, hpa@zytor.com,
"Daniel Jordan" <daniel.m.jordan@oracle.com>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Gioh Kim" <gi-oh.kim@profitbricks.com>,
"Steven Sistare" <steven.sistare@oracle.com>,
neelx@redhat.com, erosca@de.adit-jv.com,
"Vlastimil Babka" <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
"Linux Memory Management List" <linux-mm@kvack.org>,
james.morse@arm.com, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
steve.capper@arm.com, tglx@linutronix.de, mingo@redhat.com,
gregkh@linuxfoundation.org,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
kemi.wang@intel.com, "Petr Tesařík" <ptesarik@suse.com>,
yasu.isimatu@gmail.com, aryabinin@virtuozzo.com,
nborisov@suse.com, "Wei Yang" <richard.weiyang@gmail.com>,
jia.he@hxt-semitech.com
Subject: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
Date: Mon, 2 Jul 2018 23:03:01 -0400 [thread overview]
Message-ID: <CAGM2rebfdacH5imNtU+6bEOCGLhgpp=Kc9o9ooJx-os6keNkDw@mail.gmail.com> (raw)
In-Reply-To: <bfe24a3b-c982-9532-c05b-f42ebb77bbba@gmail.com>
Can you put it into memblock.c
> Do you think it looks ok if I add the inline prefix?
I would say no, this function is a too complex, and is not in some
critical path to be always inlined.
I would put it into memblock.c, and have #ifdef
CONFIG_HAVE_MEMBLOCK_PFN_VALID around it.
Thank you,
Pavel
next prev parent reply other threads:[~2018-07-03 3:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 2:29 [PATCH v9 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64 Jia He
2018-06-29 2:29 ` [PATCH v9 1/6] arm: arm64: introduce CONFIG_HAVE_MEMBLOCK_PFN_VALID Jia He
2018-06-29 18:08 ` Pavel Tatashin
2018-06-29 2:29 ` [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64 Jia He
2018-06-29 17:07 ` Pavel Tatashin
2018-07-06 1:38 ` Jia He
2018-06-29 18:13 ` Pavel Tatashin
2018-07-02 11:38 ` Michal Hocko
2018-07-03 1:55 ` Jia He
2018-07-03 3:03 ` Pavel Tatashin [this message]
2018-06-29 2:29 ` [PATCH v9 3/6] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn() Jia He
2018-06-29 2:29 ` [PATCH v9 4/6] mm/memblock: introduce memblock_search_pfn_regions() Jia He
2018-06-29 2:29 ` [PATCH v9 5/6] arm: arm64: introduce pfn_valid_region() Jia He
2018-06-29 2:29 ` [PATCH v9 6/6] mm: page_alloc: reduce unnecessary binary search in early_pfn_valid() Jia He
2018-07-02 11:40 ` [PATCH v9 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64 Michal Hocko
2018-07-02 12:06 ` Pavel Tatashin
2018-07-03 2:00 ` Jia He
2018-07-03 2:11 ` Jia He
2018-07-03 7:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2rebfdacH5imNtU+6bEOCGLhgpp=Kc9o9ooJx-os6keNkDw@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.m.jordan@oracle.com \
--cc=erosca@de.adit-jv.com \
--cc=gi-oh.kim@profitbricks.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=hejianet@gmail.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jia.he@hxt-semitech.com \
--cc=kemi.wang@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=nborisov@suse.com \
--cc=neelx@redhat.com \
--cc=pombredanne@nexb.com \
--cc=ptesarik@suse.com \
--cc=richard.weiyang@gmail.com \
--cc=steve.capper@arm.com \
--cc=steven.sistare@oracle.com \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).