From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993E1C432C3 for ; Thu, 28 Nov 2019 14:06:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56F2C217AB for ; Thu, 28 Nov 2019 14:06:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m8iDlsGn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56F2C217AB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA5E06B0535; Thu, 28 Nov 2019 09:06:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7E9C6B0536; Thu, 28 Nov 2019 09:06:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D931B6B0537; Thu, 28 Nov 2019 09:06:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id C5DC06B0535 for ; Thu, 28 Nov 2019 09:06:11 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 8D4855DE3 for ; Thu, 28 Nov 2019 14:06:11 +0000 (UTC) X-FDA: 76205860542.23.rock17_8d4de347c872c X-HE-Tag: rock17_8d4de347c872c X-Filterd-Recvd-Size: 7645 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 14:06:10 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id f129so11805248wmf.2 for ; Thu, 28 Nov 2019 06:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xk4CNdXOC8Cvj5Vm2CrI4lS6DRCcFTX4pmKmO6WKK38=; b=m8iDlsGnrn0H5iCrih8bpbN+yeFFqWqecjF+h8aiBO1wy2JIgtfT1gdVoywUABCNZt 4zN5jc419IKla4uoU9ypKJEzFR1u3qp35iRv5ru29k67NS3Smxapw2YtLtx1h6XAksaR SPjDeiGgrYPRH8xHjkA6CBRtsgOq5HsBENZZWtyq6V3U/E4uoZewLOOtdV6rcGclfJQ8 Nqkj0T5xA7Nryu2v8ISk+mdAPi/Xy+kcscIGm9QP1BmuMzWMIPJHYSXbKAQ6+RSQ9HC0 K1ZgARd8aydzimmzxZDW2mBBrp024hKw1puBA4ng1qnRBPLCKQS+g6K4pVh9x796kMvn GpNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xk4CNdXOC8Cvj5Vm2CrI4lS6DRCcFTX4pmKmO6WKK38=; b=BnhGaGaaY8Rvi+ZXVBf00/JXpIR8o5HLh4eLnE1L8tmdQdd/3qNrhrPnGpgEwSUzU2 8N9Cc5lyxmbViFAslxfb+7NIWl6DQLQJ/xuB408xlndaAm81eMcuqVmvEkmnBqRfAeyT /9Ap1py8slZmuS63DWjKew0oKMJiNS4OdCrqpaRMRqabwYWvpaqf1x7Shw0eDKsF8zmW TbwuM0VkgZKx4eU/C7MzyhvsjuvmejuhLyeS1qiIpYKSupvNN4Q1oouivlaM3bFHo6CZ 3oaYtjPD/u75RnNMHkIRE0k5Hnxuzpc7EiGHPhgOI5A/iOD8SY7UJSC3LSlkCvcSy1SR D1+w== X-Gm-Message-State: APjAAAX1X41wozCFF/JQK2LEJKyBaXhQAxCPA6tSIU+30S7LInPd91Z5 V66d9A+cftGRmXDpnZTwW48+WPgt1pm0jdq0DJTNxw== X-Google-Smtp-Source: APXvYqz4DMk9DINurXad/Tuf1OxUnZXrxVfHVpS6fcaCcDc7yVlBDqEl5O2+zkjkTemq/ecw6FRGzFif5Ml2l5m5wAg= X-Received: by 2002:a05:600c:1:: with SMTP id g1mr9703856wmc.131.1574949969059; Thu, 28 Nov 2019 06:06:09 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-10-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 28 Nov 2019 15:05:53 +0100 Message-ID: Subject: Re: [PATCH RFC v3 09/36] kmsan: add KMSAN bits to struct page and struct task_struct To: Marco Elver Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Christoph Hellwig , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , hch@infradead.org, darrick.wong@oracle.com, David Miller , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , jasowang@redhat.com, Marek Szyprowski , Mark Rutland , "Martin K . Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 28, 2019 at 2:44 PM Marco Elver wrote: > > On Fri, 22 Nov 2019 at 12:26, wrote: > > > > Each struct page now contains pointers to two struct pages holding KMSA= N > > metadata (shadow and origins) for the original struct page. > > > > Each task_struct contains a struct kmsan_task_state used to track the > > metadata of function parameters and return values for that task. > > > > Signed-off-by: Alexander Potapenko > > Cc: Jens Axboe > > Cc: Andy Lutomirski > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: Christoph Hellwig > > Cc: linux-mm@kvack.org > > --- > > > > Change-Id: Ie329527e558dd60307fb88b2da151f7f4db951ac > > --- > > include/linux/mm_types.h | 9 +++++++++ > > include/linux/sched.h | 5 +++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > > index 2222fa795284..c87c5416a802 100644 > > --- a/include/linux/mm_types.h > > +++ b/include/linux/mm_types.h > > @@ -216,6 +216,15 @@ struct page { > > not kmapped, ie. highmem) */ > > #endif /* WANT_PAGE_VIRTUAL */ > > > > +#ifdef CONFIG_KMSAN > > + /* > > + * Bits in struct page are scarce, so the LSB in *shadow is use= d to > > + * indicate whether the page should be ignored by KMSAN or not. > > + */ > > + struct page *shadow; > > + struct page *origin; > > +#endif > > + > > #ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS > > int _last_cpupid; > > #endif > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index 72b20f33c56e..ba705f66f78c 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > This file does not exist at this point in the series, and the build > would fail for all configs. This can cause problems for 'git bisect' > users etc. I thought we can move this patch past the KMSAN runtime then, but then the runtime won't be able to use the newly added fields. > I would just merge this patch with patch 10. Ack. > Thanks, > -- Marco > > > > #include > > #include > > #include > > @@ -1173,6 +1174,10 @@ struct task_struct { > > unsigned int kasan_depth; > > #endif > > > > +#ifdef CONFIG_KMSAN > > + struct kmsan_task_state kmsan; > > +#endif > > + > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > > /* Index of current stored address in ret_stack: */ > > int curr_ret_stack; > > -- > > 2.24.0.432.g9d3f5f5b63-goog > > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg