From: Alexander Potapenko <glider@google.com>
To: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
kasan-dev <kasan-dev@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
wsd_upstream <wsd_upstream@mediatek.com>,
chinwen.chang@mediatek.com, nicholas.tang@mediatek.com
Subject: Re: [PATCH v3 2/3] kasan: integrate the common part of two KASAN tag-based modes
Date: Tue, 22 Jun 2021 11:27:51 +0200 [thread overview]
Message-ID: <CAG_fn=UTfR9yKrkdRDjxFn=vgR_B7kzytm9WDWT14Gh0PLXyJg@mail.gmail.com> (raw)
In-Reply-To: <20210620114756.31304-3-Kuan-Ying.Lee@mediatek.com>
> diff --git a/mm/kasan/report_tags.h b/mm/kasan/report_tags.h
> new file mode 100644
> index 000000000000..1cb872177904
> --- /dev/null
> +++ b/mm/kasan/report_tags.h
Why don't you make it a C file instead?
> +const char *kasan_get_bug_type(struct kasan_access_info *info)
If this function has to be in the header, it should be declared as
static inline.
But I don't think it has to be there in the first place.
next prev parent reply other threads:[~2021-06-22 9:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 11:47 [PATCH v3 0/3] kasan: add memory corruption identification support for hw tag-based kasan Kuan-Ying Lee
2021-06-20 11:47 ` [PATCH v3 1/3] kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to CONFIG_KASAN_TAGS_IDENTIFY Kuan-Ying Lee
2021-06-22 9:28 ` Alexander Potapenko
2021-06-22 13:54 ` Andrey Konovalov
2021-06-20 11:47 ` [PATCH v3 2/3] kasan: integrate the common part of two KASAN tag-based modes Kuan-Ying Lee
2021-06-22 9:27 ` Alexander Potapenko [this message]
2021-06-22 9:48 ` Marco Elver
2021-06-22 13:54 ` Andrey Konovalov
2021-06-23 3:17 ` Kuan-Ying Lee
2021-06-20 11:47 ` [PATCH v3 3/3] kasan: add memory corruption identification support for hardware tag-based mode Kuan-Ying Lee
2021-06-22 9:29 ` Alexander Potapenko
2021-06-22 13:54 ` Andrey Konovalov
2021-06-23 4:12 ` Kuan-Ying Lee
2021-06-21 12:45 ` [PATCH v3 0/3] kasan: add memory corruption identification support for hw tag-based kasan Marco Elver
2021-06-26 10:13 ` Kuan-Ying Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=UTfR9yKrkdRDjxFn=vgR_B7kzytm9WDWT14Gh0PLXyJg@mail.gmail.com' \
--to=glider@google.com \
--cc=Kuan-Ying.Lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=chinwen.chang@mediatek.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=nicholas.tang@mediatek.com \
--cc=ryabinin.a.a@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).