From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C463C43215 for ; Tue, 3 Dec 2019 13:38:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55C88207DD for ; Tue, 3 Dec 2019 13:38:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mgsPTCM2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55C88207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 05A966B053C; Tue, 3 Dec 2019 08:38:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0318B6B053D; Tue, 3 Dec 2019 08:38:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8A506B053E; Tue, 3 Dec 2019 08:38:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id D27266B053C for ; Tue, 3 Dec 2019 08:38:27 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 74550824D1BF for ; Tue, 3 Dec 2019 13:38:27 +0000 (UTC) X-FDA: 76223934654.01.bead79_2caba44c94519 X-HE-Tag: bead79_2caba44c94519 X-Filterd-Recvd-Size: 6148 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 13:38:26 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id g206so2996905wme.1 for ; Tue, 03 Dec 2019 05:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qVTvKSy/sO/F9fRYm5Md8hpe5IyLrpZHD5pwor+S7xw=; b=mgsPTCM2Q+sfrH2TNL+bfr4u3T+MK1lN1U61PQQj6aFCK5HFWIqEBWoQCYdB/BMZAv jQyD7km8Of52flygkAyWIGUpu6AioBtcbk9hLBLL2dVatfNgLl7MFT8ZV8V9NBqmOpS2 rGMdRqUkTVeKz+klbm6HvGIfkAYfqYIdmEg6ur7NG9lemMBv4LlvAGcGCpnFbzrTd4YR RsovfjYbKLa654K6konJDQZW2Qml7TkeisO5Pr2ZWLioy+KHhxluSCAA/aBqOijf5hvB JcYByUdlOtyTllIj/fakkIjFo/xfKhE3LusoqYe+c7zgwGgEoz/I6hS1oBCPL6Id83JI DjTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qVTvKSy/sO/F9fRYm5Md8hpe5IyLrpZHD5pwor+S7xw=; b=dTHJFFxIC2F2GX3zCwM4BkmjVmcHFqseTx+aI45sIS6hqzUljxdClEmuEBnXFd/QMq VexEG2scHHq45456W4dfe53RqmWzie0hfzM02GulTo+eiYR98BXAm7OcFMZzYhmJKezx /lHW5hKcW+9EoIhtxxjxu97fvajFYxNJKKsV0wqiCRSGJQPD7THvZz6uVKfYheRP/59X W3bEaNK1vHC9OVUEKMUZaJjIC0kmOz1u9IH3By3nb/A2T5vHUiOuuyvBZST54w2pSj85 CM8Wk6/CYqxHnbSBKo+RINVUFRDh03uz/yEIsmy4pKdVJzC1lS7WJShHtCfJj3NrrzEA 8M/Q== X-Gm-Message-State: APjAAAVv3gXo7fW8SAjIi1j+a1wPn8Xe4VrGwzAiHHjvUmGoz6EINhPm xfpymkYwAKkuYwxeFbFd5WeFhbrEsY0pUwSDqP2uLQ== X-Google-Smtp-Source: APXvYqzOkfJqKaE9ON5uxoV6QD/JOXiQSsrNfHoUx2Kgv/xyWiv1YASTVb873cJKnfK5fAyKB9IKj6oeAUz4ruyoFY4= X-Received: by 2002:a1c:a98e:: with SMTP id s136mr33859823wme.140.1575380303877; Tue, 03 Dec 2019 05:38:23 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-35-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 3 Dec 2019 14:38:12 +0100 Message-ID: Subject: Re: [PATCH RFC v3 34/36] kmsan: disable physical page merging in biovec To: Marco Elver Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Christoph Hellwig , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 3, 2019 at 1:54 PM Marco Elver wrote: > > On Fri, 22 Nov 2019 at 12:28, wrote: > > > > KMSAN metadata for consequent physical pages may be inconsequent, > > therefore accessing such pages together may lead to metadata > > corruption. > > We disable merging pages in biovec to prevent such corruptions. > > > > Signed-off-by: Alexander Potapenko > > To: Alexander Potapenko > > Cc: Jens Axboe > > Cc: Andy Lutomirski > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: Christoph Hellwig > > Cc: linux-mm@kvack.org > > --- > > > > Change-Id: Id2f2babaf662ac44675c4f2790f4a80ddc328fa7 > > --- > > block/blk.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/block/blk.h b/block/blk.h > > index 47fba9362e60..9ee271a22423 100644 > > --- a/block/blk.h > > +++ b/block/blk.h > > @@ -78,6 +78,13 @@ static inline bool biovec_phys_mergeable(struct requ= est_queue *q, > > phys_addr_t addr1 =3D page_to_phys(vec1->bv_page) + vec1->bv_of= fset; > > phys_addr_t addr2 =3D page_to_phys(vec2->bv_page) + vec2->bv_of= fset; > > > > +#ifdef CONFIG_KMSAN > > Prefer 'if (IS_ENABLED(CONFIG_KMSAN))'. WBD in v4. > Thanks, > -- Marco --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg