From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DDFC388F9 for ; Wed, 11 Nov 2020 15:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A102520657 for ; Wed, 11 Nov 2020 15:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lW1TBKqi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A102520657 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB7496B0075; Wed, 11 Nov 2020 10:09:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17176B0078; Wed, 11 Nov 2020 10:09:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7526B007B; Wed, 11 Nov 2020 10:09:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 8432A6B0075 for ; Wed, 11 Nov 2020 10:09:09 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 122633626 for ; Wed, 11 Nov 2020 15:09:09 +0000 (UTC) X-FDA: 77472470418.30.bear60_400f7f0272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id C474E180B3C8B for ; Wed, 11 Nov 2020 15:09:08 +0000 (UTC) X-HE-Tag: bear60_400f7f0272fe X-Filterd-Recvd-Size: 5019 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 15:09:08 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id d9so1914233qke.8 for ; Wed, 11 Nov 2020 07:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AP20IjKPEiFXMZmCcqvgPxuG9Q2kK77mjoFZj0OZZoQ=; b=lW1TBKqiHfp1CIKpViQDUNAHCra8fhHaB43Vddd/gI2W6QjdTQ+C67NLugPEf5ywNV Hdh6WNIxkyUUkRBOFLwF7FjlqCfMB26gdW/rPHiyJT700zYb1hIW0NsgrsjiRl4aiZpe vTcUx4kFlZWPphLXajq2J0oCwnONR7VKEX10VlcSdL0ohHQnyQlLTyrU7sm8tM2wGOQb THLhNxZFSVFETbZhXdG0nEX/QBsA9QWnbB3fi4zhhe8OCIxUBGBzHxeA9bt49chsWB6E 8siXfeXF9hcTeik8luSgil6mber5Bp7rWpCq/hCmBxaJNKEmYhLgm7Im1Rl3RQp9Xotz Xd/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AP20IjKPEiFXMZmCcqvgPxuG9Q2kK77mjoFZj0OZZoQ=; b=cXvm4+5e3mwpVtEBa80n9f4kSHWeC5FUDuy1LdhK1em/ISj2sp0LXaTj0p5Fl+OAK0 hfu+VbCavDhnRtSAtuIDYaSemoNNz44xfWf+4HVPibmbLFWr/i/+hk4QRM8tRNVrWXfI vm8bUgVO75H9TNhWT+rN1IJgQdbMYxvZZGetqVntC8pqoVtSGb5qEN4yVySxeDzkdva5 5X0d1eN7ZtCj3/5JWrjCpDcjoShMyGP1ZKa7mV2LpW96JoIi+G0EkViIl8vGBwMlQFS4 R6ynloAoI+/ppAbvl9UZ6NFxUfYwDtxZnAU0rMIeF2mCoFXGrbl+6khQ3xs8sM3Qaozo QhrA== X-Gm-Message-State: AOAM533TdE2SjJ2+Q+57ujsFCgISjrrJMKNR9JDBDG1rDfa//ZsxjSDv b/vQR2HOVKkKNS+a7FdlJzQYawHrVaRZw2v7+5nlhQ== X-Google-Smtp-Source: ABdhPJwsaubt8h4fnMz+2Pvlw6c7i/aa/2FkCSOslDuvZkkXLEsLDI1RcIJEdJeC8ltaKWZIJiSOlSTnfnq4X1GSiHI= X-Received: by 2002:a37:4552:: with SMTP id s79mr19382613qka.6.1605107347099; Wed, 11 Nov 2020 07:09:07 -0800 (PST) MIME-Version: 1.0 References: <49f7f2c12b0d5805f9a7b7092b986bbc2dd077a1.1605046192.git.andreyknvl@google.com> In-Reply-To: <49f7f2c12b0d5805f9a7b7092b986bbc2dd077a1.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 16:08:55 +0100 Message-ID: Subject: Re: [PATCH v9 21/44] kasan: kasan_non_canonical_hook only for software modes To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > kasan_non_canonical_hook() is only applicable to KASAN modes that use > shadow memory, and won't be needed for hardware tag-based KASAN. > > No functional changes for software modes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver > --- > Change-Id: Icc9f5ef100a2e86f3a4214a0c3131a68266181b2 > --- > mm/kasan/report.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 5d5733831ad7..594bad2a3a5e 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -403,7 +403,8 @@ bool kasan_report(unsigned long addr, size_t size, bo= ol is_write, > return ret; > } > > -#ifdef CONFIG_KASAN_INLINE > +#if (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) && = \ > + defined(CONFIG_KASAN_INLINE) > /* > * With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the hig= h > * canonical half of the address space) cause out-of-bounds shadow memor= y reads Perhaps this comment also needs to be updated. > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg