From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB8AC5517A for ; Wed, 11 Nov 2020 15:06:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD2A320679 for ; Wed, 11 Nov 2020 15:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HvYqEhf5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD2A320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 296066B0075; Wed, 11 Nov 2020 10:06:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 246136B0078; Wed, 11 Nov 2020 10:06:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15B586B007B; Wed, 11 Nov 2020 10:06:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id D5FF36B0075 for ; Wed, 11 Nov 2020 10:06:30 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7DC5E180AD80F for ; Wed, 11 Nov 2020 15:06:30 +0000 (UTC) X-FDA: 77472463740.12.pen77_2f00915272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 4EC6A18000289 for ; Wed, 11 Nov 2020 15:06:30 +0000 (UTC) X-HE-Tag: pen77_2f00915272fe X-Filterd-Recvd-Size: 6862 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 15:06:29 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id l2so1944737qkf.0 for ; Wed, 11 Nov 2020 07:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=58st//mhI/fJn9QMBMlM7AWMjgnTnsXCK83D1v/z6LQ=; b=HvYqEhf59pq4f5pCn918VmdSxoS0ERCk5B4CQHxKSV84bR5tT9WmR3Tck6UMnlXFMk tN4c83qMgVm6c+DC2akoYwVQzBz+dDB/nKSaRioSE9QMkPCKisCbAwRMpoAn0G/hWIwm laQy2lXazX+bY9fQX/bdfu7xCCkwC+YirMaz5x9ze8MlStNsYCVpT0eabCCJXtvaTwT7 rZFi04H6XOmW6SCS8S2MmmolS2bAxy6jU7+kot7P4LlkmIeL7nCmLv2YoB0ejm8Q84Tf ySZCb5TTp9izjUeikvpU3ahdXUmR+2W4T0adHg6Mwr4g8ldOHVkZxt9GyTuGCjzJQAg4 Y/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=58st//mhI/fJn9QMBMlM7AWMjgnTnsXCK83D1v/z6LQ=; b=OcTaW9nZ2Kn3j0/fw0D45rjHMRbojt99idfbEyNddhCa30nTPRtPZC8MAj0Gq2ztK6 bEMBMG6mBGpLR1of7vo6bkkE2sdzwASWMKpK3d5FCvv5wp6Nc384UO0FvHgKhhk1j/t1 1QsMii83BqDP3NeEEmfxIpk4RR031cTLi32VtiDGTBtQNXIQqvG8s20NspsGojf+ZZYK 2kwLGVB7B9ISPR0UzRa5lR6bDdE9AqgPEJcyTigoP6F6Hnwn2dctr6fsvglLE/zZ5VpX TInhTaMmBCnlAZQr+DNLqcGibnzTYqHdBKJiEc9CAVPBXp6CmUm5ZVqu2DJmPTZURx+b tk7g== X-Gm-Message-State: AOAM532Ljmt6PjDRf1YRF8rJ/FmzkI5QtS9VA4FJpNMS5FfUDD8cJBhC jdTwIGCSlJ4uHtR4OzOsg1Nj4zxyIOi2iUjORqsm6w== X-Google-Smtp-Source: ABdhPJzFZWCdVRVlixYqm2kPKSCFkMUfnC6cT7kRx4slKaZWhrjCJZliqDp0sjDUD4M+UcUb4fOC+c6dljTQxYN1nqE= X-Received: by 2002:a37:4552:: with SMTP id s79mr19370022qka.6.1605107188820; Wed, 11 Nov 2020 07:06:28 -0800 (PST) MIME-Version: 1.0 References: <1034f823921727b3c5819f6d2cdfc64251476862.1605046192.git.andreyknvl@google.com> In-Reply-To: <1034f823921727b3c5819f6d2cdfc64251476862.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 16:06:16 +0100 Message-ID: Subject: Re: [PATCH v9 19/44] kasan: rename addr_has_shadow to addr_has_metadata To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000091, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > Change-Id: I03706fe34b38da7860c39aa0968e00001a7d1873 > --- > mm/kasan/kasan.h | 2 +- > mm/kasan/report.c | 6 +++--- > mm/kasan/report_generic.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index d0cf61d4d70d..f9366dfd94c9 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -146,7 +146,7 @@ static inline const void *kasan_shadow_to_mem(const v= oid *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_shadow(const void *addr) > +static inline bool addr_has_metadata(const void *addr) > { > return (addr >=3D kasan_shadow_to_mem((void *)KASAN_SHADOW_START)= ); > } > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index af9138ea54ad..2990ca34abaf 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -361,7 +361,7 @@ static void __kasan_report(unsigned long addr, size_t= size, bool is_write, > untagged_addr =3D reset_tag(tagged_addr); > > info.access_addr =3D tagged_addr; > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > info.first_bad_addr =3D find_first_bad_addr(tagged_addr, = size); > else > info.first_bad_addr =3D untagged_addr; > @@ -372,11 +372,11 @@ static void __kasan_report(unsigned long addr, size= _t size, bool is_write, > start_report(&flags); > > print_error_description(&info); > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > print_tags(get_tag(tagged_addr), info.first_bad_addr); > pr_err("\n"); > > - if (addr_has_shadow(untagged_addr)) { > + if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_a= ddr)); > pr_err("\n"); > print_shadow_for_address(info.first_bad_addr); > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index b543a1ed6078..16ed550850e9 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -118,7 +118,7 @@ const char *get_bug_type(struct kasan_access_info *in= fo) > if (info->access_addr + info->access_size < info->access_addr) > return "out-of-bounds"; > > - if (addr_has_shadow(info->access_addr)) > + if (addr_has_metadata(info->access_addr)) > return get_shadow_bug_type(info); > return get_wild_bug_type(info); > } > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg