From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8C3C388F9 for ; Wed, 11 Nov 2020 14:15:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C7BF20756 for ; Wed, 11 Nov 2020 14:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JqgXE+q+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C7BF20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 291056B0078; Wed, 11 Nov 2020 09:15:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 242506B007E; Wed, 11 Nov 2020 09:15:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10A4D6B0081; Wed, 11 Nov 2020 09:15:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id D87B16B0078 for ; Wed, 11 Nov 2020 09:15:21 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 70FC0181AC9CB for ; Wed, 11 Nov 2020 14:15:21 +0000 (UTC) X-FDA: 77472334842.25.flag24_47086b7272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 4168C1804E3A9 for ; Wed, 11 Nov 2020 14:15:21 +0000 (UTC) X-HE-Tag: flag24_47086b7272fe X-Filterd-Recvd-Size: 7957 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 14:15:20 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id 199so1714112qkg.9 for ; Wed, 11 Nov 2020 06:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UkBccG0kAG6ptvne6HOJOUn3nzbGkGD7oWbn2QDoT/s=; b=JqgXE+q+00P9Y1z90FNa74Dsyd6Cxp1hRSPb3NykRt/kjD1VZpRDyhinfVhTiLfKyV 17UYy+lbjEZqPtJ3dAJMWb5Y8VmUpzCPchbsHFa5QuDtxCRilNQvGImE864dj39ZjYZg 83CruSkbJwFsQi6BCkJHUMT0UzEPz0pwEcXqw4y8hraT0ajvm19A38jZLr+QuSjfbeFU lDi6s1hsAnt+oTGBc16nLH3zacHRIk4haa8/iXkGzZ5U69DBNtSpht5CyzWLA/XCDehz Unrl4hwdMdQm0vB0mdxGzkYnIydnXzwRKNz7scNbmu8PhJ49yYANg5TXXBJVKLuvj774 Wjgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UkBccG0kAG6ptvne6HOJOUn3nzbGkGD7oWbn2QDoT/s=; b=OtuQYlKC7WTVENMS6uo3aYVVBNvfRCUk/Qlqq5ikAOdxeafTQJfT/wFc6kM47yVYxl YS/MK8nQwKBxlSTvW/dChHFt09VwtswxIq8FTefQFgyJeeDjVlx+zIDmy3S6s5aHmSjY TDe5jq+rbe2iA335d1IK5z5r8lgpRPH+ggH35o909MYWkPgBDo6JhX4gOxXqJM2bmfH8 9m+touLijBoGvxFAQ2q+v5INKjbNrH7u5QGGawWNvj8b1f/Agk1p8jNb0dcu7uU+l/ZQ Nh9Sklp+BA16Wr6mC/4JZYqRozJCkB/ONcZ0wiemXleq7JzUnGnXCkYjP5CLPWpDxds4 sd2A== X-Gm-Message-State: AOAM533disRBVq+z4/M5YiNBmd4lg/pfCD56x8SiZDLR437NAYR7ayYy qYw5FQKiOIwD3HullJRr/nWnIyix7bOa3Sc5RokvtA== X-Google-Smtp-Source: ABdhPJxss+SD9uXirC0ROcyc6x5toqLCMrF+hoA1k8PUQ4YaZqCR3gQKgTS2hXBC5pD0sbFNPh9jEEQVsORw1SK8F0k= X-Received: by 2002:a37:4552:: with SMTP id s79mr19121371qka.6.1605104119855; Wed, 11 Nov 2020 06:15:19 -0800 (PST) MIME-Version: 1.0 References: <37a9648ffa16572583a7513323cc9be88a726eb1.1605046192.git.andreyknvl@google.com> In-Reply-To: <37a9648ffa16572583a7513323cc9be88a726eb1.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 15:15:08 +0100 Message-ID: Subject: Re: [PATCH v9 11/44] kasan: rename report and tags files To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > Rename generic_report.c to report_generic.c and tags_report.c to > report_sw_tags.c, as their content is more relevant to report.c file. > Also rename tags.c to sw_tags.c to better reflect that this file contains > code for software tag-based mode. > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > Change-Id: If77d21f655d52ef3e58c4c37fd6621a07f505f18 > --- > mm/kasan/Makefile | 16 ++++++++-------- > mm/kasan/report.c | 2 +- > mm/kasan/{generic_report.c =3D> report_generic.c} | 0 > mm/kasan/{tags_report.c =3D> report_sw_tags.c} | 0 > mm/kasan/{tags.c =3D> sw_tags.c} | 0 > 5 files changed, 9 insertions(+), 9 deletions(-) > rename mm/kasan/{generic_report.c =3D> report_generic.c} (100%) > rename mm/kasan/{tags_report.c =3D> report_sw_tags.c} (100%) > rename mm/kasan/{tags.c =3D> sw_tags.c} (100%) > > diff --git a/mm/kasan/Makefile b/mm/kasan/Makefile > index 7cc1031e1ef8..f1d68a34f3c9 100644 > --- a/mm/kasan/Makefile > +++ b/mm/kasan/Makefile > @@ -6,13 +6,13 @@ KCOV_INSTRUMENT :=3D n > # Disable ftrace to avoid recursion. > CFLAGS_REMOVE_common.o =3D $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_generic.o =3D $(CC_FLAGS_FTRACE) > -CFLAGS_REMOVE_generic_report.o =3D $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_init.o =3D $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_quarantine.o =3D $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_report.o =3D $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_report_generic.o =3D $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_report_sw_tags.o =3D $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_shadow.o =3D $(CC_FLAGS_FTRACE) > -CFLAGS_REMOVE_tags.o =3D $(CC_FLAGS_FTRACE) > -CFLAGS_REMOVE_tags_report.o =3D $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_sw_tags.o =3D $(CC_FLAGS_FTRACE) > > # Function splitter causes unnecessary splits in __asan_load1/__asan_sto= re1 > # see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D63533 > @@ -23,14 +23,14 @@ CC_FLAGS_KASAN_RUNTIME +=3D -DDISABLE_BRANCH_PROFILIN= G > > CFLAGS_common.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > CFLAGS_generic.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > -CFLAGS_generic_report.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > CFLAGS_init.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > CFLAGS_quarantine.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > CFLAGS_report.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > +CFLAGS_report_generic.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > +CFLAGS_report_sw_tags.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > CFLAGS_shadow.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > -CFLAGS_tags.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > -CFLAGS_tags_report.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > +CFLAGS_sw_tags.o :=3D $(CC_FLAGS_KASAN_RUNTIME) > > obj-$(CONFIG_KASAN) :=3D common.o report.o > -obj-$(CONFIG_KASAN_GENERIC) +=3D init.o generic.o generic_report.o shado= w.o quarantine.o > -obj-$(CONFIG_KASAN_SW_TAGS) +=3D init.o shadow.o tags.o tags_report.o > +obj-$(CONFIG_KASAN_GENERIC) +=3D init.o generic.o report_generic.o shado= w.o quarantine.o > +obj-$(CONFIG_KASAN_SW_TAGS) +=3D init.o report_sw_tags.o shadow.o sw_tag= s.o > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 7b8dcb799a78..fff0c7befbfe 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * This file contains common generic and tag-based KASAN error reporting= code. > + * This file contains common KASAN error reporting code. > * > * Copyright (c) 2014 Samsung Electronics Co., Ltd. > * Author: Andrey Ryabinin > diff --git a/mm/kasan/generic_report.c b/mm/kasan/report_generic.c > similarity index 100% > rename from mm/kasan/generic_report.c > rename to mm/kasan/report_generic.c > diff --git a/mm/kasan/tags_report.c b/mm/kasan/report_sw_tags.c > similarity index 100% > rename from mm/kasan/tags_report.c > rename to mm/kasan/report_sw_tags.c > diff --git a/mm/kasan/tags.c b/mm/kasan/sw_tags.c > similarity index 100% > rename from mm/kasan/tags.c > rename to mm/kasan/sw_tags.c > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg