From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5F9C43331 for ; Fri, 27 Mar 2020 17:03:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D0DF206E6 for ; Fri, 27 Mar 2020 17:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YeXWn+IF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D0DF206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A19C6B000E; Fri, 27 Mar 2020 13:03:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352A26B0010; Fri, 27 Mar 2020 13:03:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 267F66B0032; Fri, 27 Mar 2020 13:03:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 0E1436B000E for ; Fri, 27 Mar 2020 13:03:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E8D7E612C for ; Fri, 27 Mar 2020 17:03:46 +0000 (UTC) X-FDA: 76641764052.02.arm26_5b2dc96899f0e X-HE-Tag: arm26_5b2dc96899f0e X-Filterd-Recvd-Size: 5778 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 17:03:46 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id z5so12162486wml.5 for ; Fri, 27 Mar 2020 10:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=naLeaJ5w/uDfJraEYpeh1Bnj29nVLU95GRPvW8pGUHk=; b=YeXWn+IFQ/1zo2pEE3IqNZHi9rrX8pO8QGiYraVgSWxzwgxJUhMhqVBXXOo7zvJp72 +mPtABargfcCJ/uLZqgGfpcGRkiNGwG9ceKKGc1y1sDRMgwDY1WtEEk6jxYFW1mCTh6H hOAdsUyNoaJLtBR/gk8z5ZQkcyIobrUpeujKyMV0ppPr99Ib9z0okWpk93LlHBaOeZ+9 taBr3v45nfPLgwjwByTwEKjVGKvH02l8Ys65L7xkAALgeV+CMBBYOxbdZy9rt1iPiE8t wqAoyfpfBIpmIKB7EC8jVLhpefsB2vTO3sk7LJoagdJYhr/guSCeMDBF7U0/yTDfMaJI 8axQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=naLeaJ5w/uDfJraEYpeh1Bnj29nVLU95GRPvW8pGUHk=; b=pHHYIUlfZZmqMtjg0FizijaD+1gkrwShs+SnYOSG5o3r9L13XaMJcqQ8DHH98xWTHN Pldjlx+ZdOxH43hmbryQa9Y0RJQOlElaTmxAtr/x5klb9RPDaJrx3NQmpnBsCyY3mGdz aFyJJvQEWMufViEnD1W7rBrXmn2YAQOO1O3qgNUcDtMZn1Vyt+EG8DDxRghdgZ6OOCjA HCYxA6puycILKFRRcFG15HHlQO4gLugmmfvEjEZCDuV8TKIJ1Q3k2643sGrpwV70TAZA s9xgKX33RIwIIGCDhyUaVpN+c9sI13Z0IVPUWV0vULqNETTppMSa1dtd3hQ2MUoBTK6L w2hQ== X-Gm-Message-State: ANhLgQ38z9Tz8q+8mOAiR2bwT7zw7tILUY8N0C9XR9FxL/fIDxH/u1fP HWgb1BE5RwaPHVlx6Qpwy0bLp3attgadHKhuMfxpJQ== X-Google-Smtp-Source: ADFU+vuCGd67S74aVQUX52E7AwHNeyRuKibky2k4M6xUQqDDjPGBK31vgy9quljBOg3e2Hb1Imx1GJIYgNMf1ktSBxU= X-Received: by 2002:a1c:491:: with SMTP id 139mr6561982wme.21.1585328624655; Fri, 27 Mar 2020 10:03:44 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-35-glider@google.com> <20200325161905.GA19868@lst.de> In-Reply-To: <20200325161905.GA19868@lst.de> From: Alexander Potapenko Date: Fri, 27 Mar 2020 18:03:32 +0100 Message-ID: Subject: Re: [PATCH v5 34/38] kmsan: dma: unpoison memory mapped by dma_direct_map_page() To: Christoph Hellwig Cc: Marek Szyprowski , Robin Murphy , Vegard Nossum , Dmitry Vyukov , Marco Elver , Andrey Konovalov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , David Miller , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Mark Rutland , "Martin K . Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:19 PM Christoph Hellwig wrote: > > On Wed, Mar 25, 2020 at 05:12:45PM +0100, glider@google.com wrote: > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > index a8560052a915f..63dc1a594964a 100644 > > --- a/kernel/dma/direct.c > > +++ b/kernel/dma/direct.c > > @@ -367,6 +367,7 @@ dma_addr_t dma_direct_map_page(struct device *dev, = struct page *page, > > &dma_addr, size, *dev->dma_mask, dev->bus_dm= a_limit); > > return DMA_MAPPING_ERROR; > > } > > + kmsan_handle_dma(page_address(page) + offset, size, dir); > > This needs to go into dma_map_page so that it also covers IOMMUs. > dma_map_sg_atttrs will also need similar treatment. Thanks, will be done in v6! > Also the page > doesn't have to be mapped into kernel address space, you probably > want to pass the page to kmsan_handle_dma and throw in a highmem > check there. Do you mean comparing the address to TASK_SIZE, or is there a more portable way to check that? --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg