From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA247C388F9 for ; Wed, 11 Nov 2020 15:07:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2FBCD20679 for ; Wed, 11 Nov 2020 15:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hqeRokbo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FBCD20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 924586B006C; Wed, 11 Nov 2020 10:07:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D5056B0074; Wed, 11 Nov 2020 10:07:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E96B6B007B; Wed, 11 Nov 2020 10:07:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 4AC3D6B006C for ; Wed, 11 Nov 2020 10:07:17 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E463B181AEF00 for ; Wed, 11 Nov 2020 15:07:16 +0000 (UTC) X-FDA: 77472465672.12.bird48_450044a272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id BCEAD1805408D for ; Wed, 11 Nov 2020 15:07:16 +0000 (UTC) X-HE-Tag: bird48_450044a272fe X-Filterd-Recvd-Size: 5720 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 15:07:16 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id d28so1888633qka.11 for ; Wed, 11 Nov 2020 07:07:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=O5pvpxuaPFHh8IqCLJNTeWU2Zvn2pUlMlw4POTGBASw=; b=hqeRokbo7sPY3P1/uwmI8InkTxMKbd3lPThkpSrdaecxnnxeylVyPEgZjswZNULOOB /KM8kYn7Diy+Pfc4nLfhVsrWDSUQO8i4aYMLw0bscYl241tKbeEfvPUeQK9jn1P2Zn6T Ldesog2g26mUj58ztmXe6CgFz5zyJm23w5oFHQpiYLD6Gc/5dp/Rb+s+3tBszM9Rxrpw 1fvjHNEP3cH9Bgtwf+Div8lOHqD/+X7+EoWWzL88NHF7D5tSXkkGDtHl7qjP9jmslWut FrBFVldwZ6OcTn3128O01I370GXt8N9H3Axog5W9be2OhmbeJdJlE1D0vvA5sNyvHipz QL6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O5pvpxuaPFHh8IqCLJNTeWU2Zvn2pUlMlw4POTGBASw=; b=Wf5me4HIUsw2wqH0wR2elE94hvwcAsoXyncBN5EZ9ncdxfiDmflLJuazvkPD+s+iVI Tp+INbo5e4Ik7+OuPRFTTC3bZNj/xVg30dpmAe6zDeRjly9I/crJDuU6GSPAfvQQ26h2 EBkTGh2UH9QL/yb9qa5xJHtzs5pMzz6Y3FET9Hvl0BUd4pjU+Vuy5S46Ll0Ch/QhU8Wd v/ZcvJRPr290H90tDjFULYVR2a22ZVDj0oUTD8aDx+tEiG1l0yYM4GApsurY6NqdDxmr QfVwslQRDukXLAmSKjXPu6aYtUMyd3XoszDeeHDqy3gHj9ecxSDf+kOh9H2SPdajqNjO VnaA== X-Gm-Message-State: AOAM532PGLf2105wXxfJ0M90suuvOU54QBd7wPMzK2mRdxwPEpn7iL04 FBisFULzLRXdq4UoKUhZNUZRxE7Zrm4Gt6h3ziArsg== X-Google-Smtp-Source: ABdhPJw+mQrX8gWbQl25CCzTZuP5dydceNRRhAx+AnWkx854Rh3hUI+viNi+wHubXntXriZd2B8OMJJf2JvEmv6AdT4= X-Received: by 2002:a37:bf04:: with SMTP id p4mr26492170qkf.326.1605107235287; Wed, 11 Nov 2020 07:07:15 -0800 (PST) MIME-Version: 1.0 References: <47785f5259ba9ed493d2ac94ec7c2492fa5c1f14.1605046192.git.andreyknvl@google.com> In-Reply-To: <47785f5259ba9ed493d2ac94ec7c2492fa5c1f14.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 16:07:03 +0100 Message-ID: Subject: Re: [PATCH v9 20/44] kasan: rename print_shadow_for_address to print_memory_metadata To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000217, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > Change-Id: I18397dddbed6bc6d365ddcaf063a83948e1150a5 > --- > mm/kasan/report.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 2990ca34abaf..5d5733831ad7 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -252,7 +252,7 @@ static int shadow_pointer_offset(const void *row, con= st void *shadow) > (shadow - row) / SHADOW_BYTES_PER_BLOCK + 1; > } > > -static void print_shadow_for_address(const void *addr) > +static void print_memory_metadata(const void *addr) > { > int i; > const void *shadow =3D kasan_mem_to_shadow(addr); > @@ -338,7 +338,7 @@ void kasan_report_invalid_free(void *object, unsigned= long ip) > pr_err("\n"); > print_address_description(object, tag); > pr_err("\n"); > - print_shadow_for_address(object); > + print_memory_metadata(object); > end_report(&flags); > } > > @@ -379,7 +379,7 @@ static void __kasan_report(unsigned long addr, size_t= size, bool is_write, > if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_a= ddr)); > pr_err("\n"); > - print_shadow_for_address(info.first_bad_addr); > + print_memory_metadata(info.first_bad_addr); > } else { > dump_stack(); > } > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg