From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFE0C433E0 for ; Tue, 12 Jan 2021 08:26:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7A7622D2C for ; Tue, 12 Jan 2021 08:26:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7A7622D2C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE76E8D0073; Tue, 12 Jan 2021 03:26:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D95CC8D0051; Tue, 12 Jan 2021 03:26:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C84F98D0073; Tue, 12 Jan 2021 03:26:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id B34068D0051 for ; Tue, 12 Jan 2021 03:26:06 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7714B180AD817 for ; Tue, 12 Jan 2021 08:26:06 +0000 (UTC) X-FDA: 77696440332.16.swim79_0612b2d27513 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 5A0FE100E6903 for ; Tue, 12 Jan 2021 08:26:06 +0000 (UTC) X-HE-Tag: swim79_0612b2d27513 X-Filterd-Recvd-Size: 3904 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 08:26:05 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id j26so1056560qtq.8 for ; Tue, 12 Jan 2021 00:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u66Zz7BdRS7VV/vrWqqvG+i4Lg5S/n1M+J8zEYi5Ao4=; b=eYTicqMf968rsvZwqKjvQuowXZ1ZvCoYJ8cS57jF1fuYYcFHVXL0X8f2FXmKQaaseX Yj8sKvIfxE4xePzg/R3A/UvyS3tK3BxCfqwPBdGAyk+q9iYGZUJrLmR5MSrZTB5cD12I wK/mWGe4VbAx5cxeyAPmw82u/UVJFBhp23dXPcCJCLiOlIWWs5w4onEwCHo5DYe/Trzu ls7hIgmsNb3KTdS9LmtMr2Qfy3jjPfX2jnrICj2LUMA7DjSawuDB8QfsVFDmlsEmCthh jLUu7O7i/oCY/H+8llOL40lX2tjodU5LcDjjk211N4yUCBz/3ZxrkQ/mmZE8DyDDNmKl HIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u66Zz7BdRS7VV/vrWqqvG+i4Lg5S/n1M+J8zEYi5Ao4=; b=QY0QGA9FxXy4E2HUyUVfKveCxWxhLWlVE7IdIsW2hMLedtYQmkCcWtxf45MNAvHo/U LJQGDzJLoZT9cCaC0fZWw1kKSwQRfVz6eRQ7mQ8ufLSJon6+hV0eIUNnsHFxdMEd9yVf J/1VnNzJywq0Gx+cvUcH9vLGVHOV9I7fOAi0TnML3PfkpZ/9YWG4+jQoqFFRCLu8kNo0 ImXN39/mvcXVmSVnKFlV/8QOv+laxnqhbpG2XWtB0suxV3r7gN9WkGL+NOmfkJr/rNx7 cOsPqaYmDZO/XkblRc8mhIWx81/XDFKWvG99cM0c4n22El8MQknf+/81QvMEWD3KlCdM DG3Q== X-Gm-Message-State: AOAM531A7RER5RpKFdqhBGI0T6lzILo6MnT32l/t5W+/O8NWvQ9T+PuT mdYM4L5VZN3oLf+xxnngM86eqXYjuQPaa9JYQMts1A== X-Google-Smtp-Source: ABdhPJx0J5IDwFVF1k2QxS7V6i8xM+pxfMUSucnpGXb232MF3bwGZWdb89rCjAGill1SbeO56GioOR585B0L87SrwBw= X-Received: by 2002:ac8:6f32:: with SMTP id i18mr3418479qtv.175.1610439964938; Tue, 12 Jan 2021 00:26:04 -0800 (PST) MIME-Version: 1.0 References: <9a4f47fe8717b4b249591b307cdd1f26c46dcb82.1609871239.git.andreyknvl@google.com> In-Reply-To: <9a4f47fe8717b4b249591b307cdd1f26c46dcb82.1609871239.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 12 Jan 2021 09:25:53 +0100 Message-ID: Subject: Re: [PATCH 08/11] kasan: adopt kmalloc_uaf2 test to HW_TAGS mode To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Marco Elver , Andrew Morton , Will Deacon , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nit: s/adopt/adapt in the title. > +again: > ptr1 = kmalloc(size, GFP_KERNEL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr1); > > @@ -384,6 +386,13 @@ static void kmalloc_uaf2(struct kunit *test) > ptr2 = kmalloc(size, GFP_KERNEL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2); > > + /* > + * For tag-based KASAN ptr1 and ptr2 tags might happen to be the same. > + * Allow up to 4 attempts at generating different tags. > + */ > + if (!IS_ENABLED(CONFIG_KASAN_GENERIC) && ptr1 == ptr2 && counter++ < 4) > + goto again; > + Looks like we are leaking memory allocated for ptr2 here?