From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB7BC432C0 for ; Wed, 27 Nov 2019 14:56:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4146720678 for ; Wed, 27 Nov 2019 14:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Swernf/T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4146720678 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC1AD6B04B1; Wed, 27 Nov 2019 09:56:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C73416B04B2; Wed, 27 Nov 2019 09:56:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B62106B04B3; Wed, 27 Nov 2019 09:56:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 9F4866B04B1 for ; Wed, 27 Nov 2019 09:56:54 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 6C250180AD811 for ; Wed, 27 Nov 2019 14:56:54 +0000 (UTC) X-FDA: 76202359548.12.turn10_5955959230014 X-HE-Tag: turn10_5955959230014 X-Filterd-Recvd-Size: 6840 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 14:56:53 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id y11so23920461wrt.6 for ; Wed, 27 Nov 2019 06:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2Srf8vo3nETT10NJsk3vIsk12ZpD6HyhqXq0xOjRZvY=; b=Swernf/TOfpYXHFtQzD+jH35VYTRHDDywnRbgaDXM3XlL5jJHoB2/K8kEPNtDHLzzc NFCXK326ePRBfKQ4wnOcsEM/aJzis8Nbdhy/D/ct6llnAAGK2bS2Nqlwiphr4squXyiJ mo9XqhFvKn+rJG1cxUGQUaEfA/Yxd45AGlKETXfmXO8/vgJf4MPk34AUyIa7n0Ns/jdm JHRZAxTsxdFHUhcpZ4GgcceSZgwa6TyuJ9Yo5sfitiieuvROj5V0YKGNbKPLbtp+bSht aXpSxYBSgZI7YwQQJ4h6X4QRS+b9PowkyISkHWUejWWMwsSV92EbyHt3rmbKYFWNRaV2 GHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2Srf8vo3nETT10NJsk3vIsk12ZpD6HyhqXq0xOjRZvY=; b=LxG4m9SqBTNYSX38AeJPPvq8y3n5PV739mwgaySB2hZD1scmsUhQ8hU0eDCmzLnvTZ xrcVo1VA2btbGPXIAF6nE9cyuUC7IcIapdqiXo0j3MIRpL3Gl1roi/tN20Y4znJ8ilpa TDLLVE63oLAZkoppZQPAgE1Vf1UT4hlmsFg02If+j4wkC5+BFdyoeRJ/Uz17MF6fWVSE ff9Rtr6YyVKDWQhNUXiP1tFnrLhebCftw7ZGOJmNhNCogAgg+2d1LvEhiEjq2GuQOPv1 tNpAj9fsTb3D0hijInEeAjeKRudiWSQzJ6C02L2RFrntVIWz2mrHRBuEKdQB1PlFtod8 v07Q== X-Gm-Message-State: APjAAAWK0hk46ZuhvCdgtBcQaiAEen+0eyXAqX5BBMN8hNwSHZIlFOow 5ZLZJOiSES3RjPDFEEJDpb52H6nkCsGzSHXD/toq+A== X-Google-Smtp-Source: APXvYqz9dY3bhVFwy4Nk4WZcNQiVDaxEh9oo3glCebHXjmu2Gkx1LfTf4A9CLdTa2XDWZXG0vyNroJ9+Ve+gv9B2/eE= X-Received: by 2002:adf:e911:: with SMTP id f17mr45113167wrm.300.1574866612051; Wed, 27 Nov 2019 06:56:52 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-4-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 27 Nov 2019 15:56:40 +0100 Message-ID: Subject: Re: [PATCH RFC v3 03/36] kasan: stackdepot: move filter_irq_stacks() to stackdepot.c To: Marco Elver Cc: Vegard Nossum , Dmitry Vyukov , Andrey Ryabinin , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , hch@infradead.org, Christoph Hellwig , darrick.wong@oracle.com, David Miller , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , jasowang@redhat.com, Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K . Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 27, 2019 at 3:23 PM Marco Elver wrote: > > On Fri, 22 Nov 2019 at 12:26, wrote: > [...] > > diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h > > index 3efa97d482cb..24d49c732341 100644 > > --- a/include/linux/stackdepot.h > > +++ b/include/linux/stackdepot.h > > @@ -19,4 +19,6 @@ depot_stack_handle_t stack_depot_save(unsigned long *= entries, > > unsigned int stack_depot_fetch(depot_stack_handle_t handle, > > unsigned long **entries); > > > > +unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr= _entries); > > + > > #endif > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > > index 6d1123123e56..eb95197b8743 100644 > > --- a/lib/stackdepot.c > > +++ b/lib/stackdepot.c > > @@ -20,6 +20,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -314,3 +315,25 @@ depot_stack_handle_t stack_depot_save(unsigned lon= g *entries, > > return retval; > > } > > EXPORT_SYMBOL_GPL(stack_depot_save); > > + > > +static inline int in_irqentry_text(unsigned long ptr) > > +{ > > + return (ptr >=3D (unsigned long)&__irqentry_text_start && > > + ptr < (unsigned long)&__irqentry_text_end) || > > + (ptr >=3D (unsigned long)&__softirqentry_text_start && > > + ptr < (unsigned long)&__softirqentry_text_end); > > +} > > + > > +unsigned int filter_irq_stacks(unsigned long *entries, > > + unsigned int nr_entries) > > +{ > > + unsigned int i; > > + > > + for (i =3D 0; i < nr_entries; i++) { > > + if (in_irqentry_text(entries[i])) { > > + /* Include the irqentry function into the stack= . */ > > + return i + 1; > > + } > > + } > > + return nr_entries; > > +} > > Does this need an EXPORT_SYMBOL_GPL ? Yes, makes sense. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg