From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F243C5519F for ; Thu, 12 Nov 2020 15:59:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F3CA221E9 for ; Thu, 12 Nov 2020 15:59:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="adOBV9vU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3CA221E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF8DF6B005D; Thu, 12 Nov 2020 10:59:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCF826B0068; Thu, 12 Nov 2020 10:59:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5B56B006E; Thu, 12 Nov 2020 10:59:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id A1CF46B005D for ; Thu, 12 Nov 2020 10:59:48 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 50D618249980 for ; Thu, 12 Nov 2020 15:59:48 +0000 (UTC) X-FDA: 77476226856.12.grass04_3912ca727307 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 3A17F1800E93A for ; Thu, 12 Nov 2020 15:59:48 +0000 (UTC) X-HE-Tag: grass04_3912ca727307 X-Filterd-Recvd-Size: 5545 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 15:59:47 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id v143so5708708qkb.2 for ; Thu, 12 Nov 2020 07:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4jCOmZMfeGT0TXCdgSotnEbRECtZNT/yP78oj9y32ro=; b=adOBV9vUMW+wa1UMSZKmUYiV+rRIraVU+W5WWTyE15tii2COEt5s1IccjYh1mY68A1 Ek2ViBTLYQtP26NJ6VsCw1klYQV31enkWJKN+c/YfingjG6AUCv96mPFnOGeox1ZHAmW MHwH0JThb7lG2U+iN0lNrZm8MDr2F38wRUtYQspHYauZi2+z8X4JdZF8XZsfMtUgKK7p DA72bQhzJ7w3OqFOeob7Djpkdrnte3cjSrTLKfEZrInICmbqH29lckCpdFBPdEyR6ODX B5QEZWZRwqNh0h24KKbrONYuBL0Kv2knueSS6yhaQIvh0g/O5EUef/EUJascFIZhHWGN QG3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4jCOmZMfeGT0TXCdgSotnEbRECtZNT/yP78oj9y32ro=; b=DN4yIvFh+J32jMBMPS8uBzd2WXIZ/NBGC1DuW8eUZCk713vEWw/7VJJxcS/YHWjwBj lk70OLxa6rnNq28T9IXDoSM+hPR55Dw3EpnhD3kisbpn4xneYqc6e4sCEnVpX/sn3Qbi 8QdVYetzV/6SmFSYHxkzXBorrPW2k0VkbRADHqa2Fcx2HazcNVYqk3ELUDRyL7f5MEaS Pgo+xaQYXvzHAIoOLXY+sBb0lNIxK0sG9k/Rnvxxxv54H+Ju3zKeHFbFMyi8za0C5hvi mcQ0a2COm55BDQJ0VoovMKknEl+NAE8DhdXi4RfJHGmA9D10HEekMP2Zu8pv5Dpg76lG gezg== X-Gm-Message-State: AOAM533qdbcJW0E6Mn5t2Tl7XzJg5hS4D+WlNKnN9CO1S7PN9sCPuTP6 jrOCRk6RzBe6yipfU81g8UvAa1er4i/FfF5ZAyc9tw== X-Google-Smtp-Source: ABdhPJxFf5p6ggFclyyqMlQ1hU/zZuctmzK10pHxDVC/fJWkQ5dzeaoAwVmoVkHpC44DejNUOBKtMelXFEBJbwtznj4= X-Received: by 2002:a05:620a:211b:: with SMTP id l27mr441705qkl.352.1605196786695; Thu, 12 Nov 2020 07:59:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Thu, 12 Nov 2020 16:59:35 +0100 Message-ID: Subject: Re: [PATCH v9 44/44] kselftest/arm64: Check GCR_EL1 after context switch To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.002575, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:12 PM Andrey Konovalov w= rote: > > From: Vincenzo Frascino > > This test is specific to MTE and verifies that the GCR_EL1 register > is context switched correctly. > > It spawn 1024 processes and each process spawns 5 threads. Each thread Nit: "spawns" > + srand(time(NULL) ^ (pid << 16) ^ (tid << 16)); > + > + prctl_tag_mask =3D rand() % 0xffff; Nit: if you want values between 0 and 0xffff you probably want to use bitwise AND. > + > +int execute_test(pid_t pid) > +{ > + pthread_t thread_id[MAX_THREADS]; > + int thread_data[MAX_THREADS]; > + > + for (int i =3D 0; i < MAX_THREADS; i++) > + pthread_create(&thread_id[i], NULL, > + execute_thread, (void *)&pid); It might be simpler to call getpid() in execute_thread() instead. > +int mte_gcr_fork_test() > +{ > + pid_t pid[NUM_ITERATIONS]; > + int results[NUM_ITERATIONS]; > + pid_t cpid; > + int res; > + > + for (int i =3D 0; i < NUM_ITERATIONS; i++) { > + pid[i] =3D fork(); > + > + if (pid[i] =3D=3D 0) { pid[i] isn't used anywhere else. Did you want to keep the pids to ensure that all children finished the work? If not, we can probably go with a scalar here. > + for (int i =3D 0; i < NUM_ITERATIONS; i++) { > + wait(&res); > + > + if(WIFEXITED(res)) > + results[i] =3D WEXITSTATUS(res); > + else > + --i; Won't we get stuck in this loop if fork() returns -1 for one of the process= es? > + } > + > + for (int i =3D 0; i < NUM_ITERATIONS; i++) > + if (results[i] =3D=3D KSFT_FAIL) > + return KSFT_FAIL; > + > + return KSFT_PASS; > +} > + --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg