From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7A1C54EE9 for ; Sat, 17 Sep 2022 13:35:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62948D0002; Sat, 17 Sep 2022 09:35:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9FD8D0001; Sat, 17 Sep 2022 09:35:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8B2D8D0002; Sat, 17 Sep 2022 09:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9387A8D0001 for ; Sat, 17 Sep 2022 09:35:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 63F05C0B0D for ; Sat, 17 Sep 2022 13:35:06 +0000 (UTC) X-FDA: 79921673412.24.C5333EC Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf26.hostedemail.com (Postfix) with ESMTP id 047321400D1 for ; Sat, 17 Sep 2022 13:35:05 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id z6so7725890wrq.1 for ; Sat, 17 Sep 2022 06:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=pkEmitpPxttXVrpaoXcyyBb0DXbZJ4MfwB1UQBeB4Cs=; b=qbRXEL4zHM3yGua4NVlehiIP+BhPgK6DA5XjrXFMVDQDH/g92j3jQf3chqSXiALt7V 3wJtFcqTL3R2XTOUxO+0/GyFYhuqY2OtEZm43Y4i3drArYiiRv0U7AEsJtmdmg0zmSwc gPqzfVyMKXkhhCnc9a6w+unr/TkIyESTmovLB2qcFXJ4Ux0PFWAhRuZL5+bneyltPOy6 Cjvvs99IovHeWnQDFzhImtP2QRvNvXUQO3ndrvCHdLtg9tdmXFmHWl1mkdzhZ+1G72Xi qmjJVPh+Gg732G2DOc5VlSg12BQp8aa2ViTc00qhdQrBJaenBjWNvNb/PFkuvTiQa/CW tk3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=pkEmitpPxttXVrpaoXcyyBb0DXbZJ4MfwB1UQBeB4Cs=; b=EZ7pSsk+OtixKs55+W+7ILf+ttAg9fVnvbaCgpaZB8rTARRC/VIEbvf4SbvqL261UK ByXpFAPeutH6uQwfbGkJ/TODSk4BcOKpzcDV+R1LQlswdRRzkWGq++ht0GgL4a2rLwtz sBJdriu9qDA7UvUVuIxC2UAsmZtn1008DRhyWqkBPDDD41HwYNIOr7N3sttNYbPqPXcs cjJlaYsSqXmL2LPChT0D8cnGW5seuqELEL5o4j+WPB4qrHcX5hvVMufYr0B+Waur5aqY tIWJrenOWkMX93dnzxN8MS4VQoD2UnISP9AHAOZeoHpuwTZF6vAghvSDFRlhQehBuwBO IgaQ== X-Gm-Message-State: ACrzQf0XI9Gobwd03YU1f3bKN71FYbli8pq4qdSizqD8NHgpCYSKtLLk SjFotSSwX/1t3aXs7d1kd4XDr9gs/mMyn8jJvQ== X-Google-Smtp-Source: AMsMyM4gE5I3IlyBp0J79uc7L+wMEfIaoZ07VvSB9hb3Ma751C01ggmVhpzAE8qEQZegCZTZaHZq1lPKZ45O7RIjrJg= X-Received: by 2002:a05:6000:70e:b0:22a:c7f5:c5f7 with SMTP id bs14-20020a056000070e00b0022ac7f5c5f7mr5751144wrb.333.1663421704553; Sat, 17 Sep 2022 06:35:04 -0700 (PDT) MIME-Version: 1.0 References: <1663407558-21316-1-git-send-email-kaixuxia@tencent.com> <20220917111230.114618-1-sj@kernel.org> In-Reply-To: <20220917111230.114618-1-sj@kernel.org> From: Kaixu Xia Date: Sat, 17 Sep 2022 21:34:52 +0800 Message-ID: Subject: Re: [PATCH] mm/damon: rename damon_pageout_score() to damon_cold_score() To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, LKML , Kaixu Xia Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663421706; a=rsa-sha256; cv=none; b=yo8pVPJoiBrUgiGH1kvxuIurZ4OJSjTPYZ5oSXpCmS9kjdkyRyePYzWxp5rEAxydRfJI/b VPProylUTzPTOx+0HUjwz6iF1XRNEEM1Ut90uxaeFT1ijXtPmY3dFmvttzCyGHCOPgku53 +Lw2UV1NfNt95jZIOfvsD+j+74XoLQA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qbRXEL4z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663421706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pkEmitpPxttXVrpaoXcyyBb0DXbZJ4MfwB1UQBeB4Cs=; b=5jUIIxZCrsmg1z/25NEW/e/dxqutpOuCrmJELQYzVKcjaUX2lYfOT+ym2+bB6nC8qkILDb 5CUP9lWXbXlJySJtkLJYj5lU7kmyY26np6gB8qFWAgzRVZQdEtVKjDyWu44GSVqcQQDMMz H2auD88PrnrexdK54M5YEQkGWxy2BX4= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 047321400D1 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qbRXEL4z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com X-Stat-Signature: 3sdrbg3riw1ay94qawrwbwjzgwgyp7aq X-HE-Tag: 1663421705-737668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 17, 2022 at 7:12 PM SeongJae Park wrote: > > On Sat, 17 Sep 2022 17:39:18 +0800 xiakaixu1987@gmail.com wrote: > > > From: Kaixu Xia > > > > In the beginning there is only one damos_action 'DAMOS_PAGEOUT' > > that need to get the coldness score of a region for a scheme, > > which using damon_pageout_score() to do that. But now there are > > also other damos_action actions need the coldness score, so > > rename it to damon_cold_score() to make more sense. > > Good idea. > > > > > Signed-off-by: Kaixu Xia > > --- > > mm/damon/ops-common.c | 2 +- > > mm/damon/ops-common.h | 2 +- > > mm/damon/paddr.c | 5 ++--- > > mm/damon/vaddr.c | 2 +- > > 4 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > > index 9310df72e1c5..75409601f934 100644 > > --- a/mm/damon/ops-common.c > > +++ b/mm/damon/ops-common.c > > @@ -130,7 +130,7 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > > return hotness; > > } > > > > -int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, > > +int damon_cold_score(struct damon_ctx *c, struct damon_region *r, > > struct damos *s) > > { > > int hotness = damon_hot_score(c, r, s); > > diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h > > index 52329ff361cd..8d82d3722204 100644 > > --- a/mm/damon/ops-common.h > > +++ b/mm/damon/ops-common.h > > @@ -12,7 +12,7 @@ struct page *damon_get_page(unsigned long pfn); > > void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr); > > void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr); > > > > -int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, > > +int damon_cold_score(struct damon_ctx *c, struct damon_region *r, > > struct damos *s); > > int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > > struct damos *s); > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > > index dfeebffe82f4..e495146e49e9 100644 > > --- a/mm/damon/paddr.c > > +++ b/mm/damon/paddr.c > > @@ -287,11 +287,10 @@ static int damon_pa_scheme_score(struct damon_ctx *context, > > { > > switch (scheme->action) { > > case DAMOS_PAGEOUT: > > - return damon_pageout_score(context, r, scheme); > > + case DAMOS_LRU_DEPRIO: > > + return damon_cold_score(context, r, scheme); > > case DAMOS_LRU_PRIO: > > return damon_hot_score(context, r, scheme); > > - case DAMOS_LRU_DEPRIO: > > - return damon_pageout_score(context, r, scheme); > > I'm not a big fan of switch-case fall-through, and want to keep the order of > cases here more similar to that in damos_action definition. Let's change only > the function name. > Ok, I'll follow that in the next version. Thanks, Kaixu > Other than that, > > Reviewed-by: SeongJae Park > > > Thanks, > SJ > > > default: > > break; > > } > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > > index f53c2ff2bcc8..ea94e0b2c311 100644 > > --- a/mm/damon/vaddr.c > > +++ b/mm/damon/vaddr.c > > @@ -673,7 +673,7 @@ static int damon_va_scheme_score(struct damon_ctx *context, > > > > switch (scheme->action) { > > case DAMOS_PAGEOUT: > > - return damon_pageout_score(context, r, scheme); > > + return damon_cold_score(context, r, scheme); > > default: > > break; > > } > > -- > > 2.27.0 > > > >