From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, herbert@gondor.apana.org.au
Cc: chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org,
linux-kernel@vger.kernel.org, sjenning@redhat.com,
vitaly.wool@konsulko.com, Barry Song <v-songbaohua@oppo.com>,
davem@davemloft.net, hannes@cmpxchg.org,
linux-crypto@vger.kernel.org, linux-mm@kvack.org,
zhouchengming@bytedance.com, nphamcs@gmail.com,
yosryahmed@google.com
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable
Date: Fri, 8 Mar 2024 19:57:38 +0800 [thread overview]
Message-ID: <CAGsJ_4wMGNDcgc3pqSUicYoH7Z_miczkT=uwZU+yhDF0fd57Rg@mail.gmail.com> (raw)
In-Reply-To: <20240222081135.173040-1-21cnbao@gmail.com>
Hi Andrew,
On Thu, Feb 22, 2024 at 4:11 PM Barry Song <21cnbao@gmail.com> wrote:
>
> From: Barry Song <v-songbaohua@oppo.com>
>
> In zswap, if we use zsmalloc, we cannot sleep while we map the
> compressed memory, so we copy it to a temporary buffer. By
> knowing the alg won't sleep can help zswap to avoid the
> memcpy.
> Thus we introduce an API in crypto to expose if acomp is async,
> and zswap can use it to decide if it can remove copying to the
> tmp buffer.
>
> -v6:
> * add acked-by of Herbert, Thanks!
> * remove patch 3/3 from the series, as that one will go
> through crypto
Can you please pull this into mm-tree? This used to have 3 patches.
3/3 was separated according to Herbert's requirements and has
been in a crypto tree.
crypto: scomp - remove memcpy if sg_nents is 1 and pages are lowmem
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=77292bb8ca
Two drivers fixes(patch 1 needs) have also been in crypto tree:
crypto: hisilicon/zip - fix the missing CRYPTO_ALG_ASYNC in cra_flags
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=db8ac88385
crypto: iaa - fix the missing CRYPTO_ALG_ASYNC in cra_flags
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=30dd94dba35
So it should be quite safe to pull this series into mm-tree now.
>
> Barry Song (2):
> crypto: introduce: acomp_is_async to expose if comp drivers might
> sleep
> mm/zswap: remove the memcpy if acomp is not sleepable
>
> include/crypto/acompress.h | 6 ++++++
> mm/zswap.c | 6 ++++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> --
> 2.34.1
Thanks
Barry
next prev parent reply other threads:[~2024-03-08 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 8:11 [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable Barry Song
2024-02-22 8:11 ` [PATCH v6 1/2] crypto: introduce: acomp_is_async to expose if comp drivers might sleep Barry Song
2024-02-24 16:52 ` Chris Li
2024-02-22 8:11 ` [PATCH v6 2/2] mm/zswap: remove the memcpy if acomp is not sleepable Barry Song
2024-02-24 16:53 ` Chris Li
2024-03-08 11:57 ` Barry Song [this message]
2024-03-09 3:23 ` [PATCH v6 0/2] zswap: " Andrew Morton
2024-03-09 3:58 ` Barry Song
2024-03-09 4:36 ` Andrew Morton
2024-03-09 4:42 ` Andrew Morton
2024-03-09 4:56 ` Barry Song
2024-03-09 5:08 ` Barry Song
2024-03-08 12:11 ` Johannes Weiner
2024-03-19 11:00 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGsJ_4wMGNDcgc3pqSUicYoH7Z_miczkT=uwZU+yhDF0fd57Rg@mail.gmail.com' \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=chrisl@kernel.org \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=v-songbaohua@oppo.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).