From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BB2C4360C for ; Thu, 26 Sep 2019 13:10:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 120E2222BE for ; Thu, 26 Sep 2019 13:10:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M0MOZVUz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 120E2222BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C0578E000C; Thu, 26 Sep 2019 09:10:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 971CA8E0001; Thu, 26 Sep 2019 09:10:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ADE58E000C; Thu, 26 Sep 2019 09:10:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 6A2BF8E0001 for ; Thu, 26 Sep 2019 09:10:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 01A0440D3 for ; Thu, 26 Sep 2019 13:10:16 +0000 (UTC) X-FDA: 75977105232.14.tax17_3aef13e866115 X-HE-Tag: tax17_3aef13e866115 X-Filterd-Recvd-Size: 5732 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Sep 2019 13:10:04 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id h144so6329722iof.7 for ; Thu, 26 Sep 2019 06:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FZIPxOACSyBTtRH5A7Lgyz9YR30y4W13jpD2I+1mgJM=; b=M0MOZVUz4t6WU55SoJjNSOp7QYn65o/NCOkDutq5p4891fxVHa6jIYc0GzSPoE5NgC Y/F31CMUMd8X4Qdqfc4MGmYyhNuR+uHG233WadTHQa0xsWxFJv5rl8RVwaE3bu3pB7qr wri0795JXn4yi9BdL9A4kIX8Eq3Xd1Myt3BkKJ+99RFh8if3n6D0lMDd1/A4PUTHHLSY mi041pBhTLwJRt9cj7XQ/sDkCPZZAFKFgXm6Ri5VzL7A0Gk1JZg/oHQRycR2/sZb03c2 lzEE4rwwCW+uRuqgQOz+nrJU3ZVzQbE+b9nB1IS53yKZV5lYYrQXdFhuW1+ZKBjhKOVA lysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FZIPxOACSyBTtRH5A7Lgyz9YR30y4W13jpD2I+1mgJM=; b=JzaNkLtUMpUMIdNnh2C729PEzAYzTtIE/GluD91VSM0acVpVnLu2N8o+dN4cWIhbEQ +6ramyNdL55n6kkkhTFYDluyT7UCba3y3Zylsf4xWa4VVb7AMt4h+Lqpijehnewsa4Ir NPWgLb9KaoOwLBehX8j4kLc4xlxa4EJuCLAxnVCkJOahAhzshNuOp0RjRZ5VZkwbcjlu KPvrknLWfNfSfqLWpNaWQZjf/Rbf/AKOyqarqWICR7hdHSWhBMQMelip8fcM2ln7e9KZ xkhnYtwhFIqDZkY+XprT/Zxn4Oiug46jgFGPQ0/aku9EYf1PZDszgldie8zANXFk0gec 1gLA== X-Gm-Message-State: APjAAAVrx0T44S9UCfGxMxCGUkCmqgwTBZU3wsT3PUniJW5ypN6XT1hA da28pktlGrfLMEvYmf2PQZZ6QPCSzEIgZfmiyDw= X-Google-Smtp-Source: APXvYqzlyCi4JSGY6XghEeQ/E8vAIH7ViuIHrzxvUyMsua1GZWLVjXjlSiGwrvjIiebbaCWFI8rRhtB8cjRotnhYNKg= X-Received: by 2002:a6b:d601:: with SMTP id w1mr3118098ioa.158.1569503404009; Thu, 26 Sep 2019 06:10:04 -0700 (PDT) MIME-Version: 1.0 References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> In-Reply-To: From: Adam Ford Date: Thu, 26 Sep 2019 08:09:52 -0500 Message-ID: Subject: Re: [PATCH v2 00/21] Refine memblock API To: Fabio Estevam Cc: Mike Rapoport , Rich Felker , linux-ia64@vger.kernel.org, Petr Mladek , linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , Linux Kernel Mailing List , Max Filippov , Guo Ren , Michael Ellerman , sparclinux@vger.kernel.org, Christoph Hellwig , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Richard Weinberger , x86@kernel.org, Russell King , kasan-dev , Geert Uytterhoeven , Mark Salter , Dennis Zhou , Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, devicetree , linux-xtensa@linux-xtensa.org, linux-um@lists.infradead.org, The etnaviv authors , linux-m68k@lists.linux-m68k.org, Rob Herring , Greentime Hu , xen-devel@lists.xenproject.org, Stafford Horne , Guan Xuetao , arm-soc , Michal Simek , Tony Luck , Linux Memory Management List , Greg Kroah-Hartman , USB list , linux-mips@vger.kernel.org, Paul Burton , Vineet Gupta , linux-alpha@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , openrisc@lists.librecores.org, Chris Healy Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 25, 2019 at 10:17 AM Fabio Estevam wrote: > > On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > > > I tried cma=256M and noticed the cma dump at the beginning didn't > > change. Do we need to setup a reserved-memory node like > > imx6ul-ccimx6ulsom.dtsi did? > > I don't think so. > > Were you able to identify what was the exact commit that caused such regression? I was able to narrow it down the 92d12f9544b7 ("memblock: refactor internal allocation functions") that caused the regression with Etnaviv. I also noticed that if I create a reserved memory node as was done one imx6ul-ccimx6ulsom.dtsi the 3D seems to work again, but without it, I was getting errors regardless of the 'cma=256M' or not. I don't have a problem using the reserved memory, but I guess I am not sure what the amount should be. I know for the video decoding 1080p, I have historically used cma=128M, but with the 3D also needing some memory allocation, is that enough or should I use 256M? adam