From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D92C47257 for ; Fri, 8 May 2020 19:02:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A935521974 for ; Fri, 8 May 2020 19:02:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A935521974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F9D58E0006; Fri, 8 May 2020 15:02:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AA398E0005; Fri, 8 May 2020 15:02:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF6B8E0006; Fri, 8 May 2020 15:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 5104C8E0005 for ; Fri, 8 May 2020 15:02:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0EB17181AEF1D for ; Fri, 8 May 2020 19:02:28 +0000 (UTC) X-FDA: 76794472776.15.swing30_4fadbe3b7272d X-HE-Tag: swing30_4fadbe3b7272d X-Filterd-Recvd-Size: 3918 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 May 2020 19:02:27 +0000 (UTC) Received: from mail-ej1-f70.google.com ([209.85.218.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jX8GQ-0005LV-48 for linux-mm@kvack.org; Fri, 08 May 2020 19:02:26 +0000 Received: by mail-ej1-f70.google.com with SMTP id dx16so1082860ejb.10 for ; Fri, 08 May 2020 12:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3K8W/xyCm3pY7h2xvaxoZVF5ExAZpZK/UzoZ8wN3Uls=; b=OcDss/rt1AcBqT4MLt5Fxpu2+jd5/RW4RfVhYyD/DsIHWLfLNaYkSL5vFrukcp+2QE rxBS21XxVjRdpPRsXIhVIEUB2Bm0S6DVQ0xJ0HBn86g7Nl9J18mdN/Fq8ix62wjkJII2 pQBoiFXJSyephTLGYWe2La8maODl5lcEV7yXMVroSMMWaDqKtOG3F+WbZ0i38n8UO5kp 7TReOkgTht9rRAB3uGHFQBf4QjgLLOGEh9KIzbUiv3oXhTGbV4TVJegoPwiWSEJmJpFu yBeem7edN35eY0tKS3piw1dcjwlX6FHtl5l2vkm3U8Whdc7x6bKuAakL558nrpwKTsFF LTYA== X-Gm-Message-State: AGi0Pua40zBJokDLbdj7jBXOWQGbFSlbZEBZF7IseuPTnEdcky6VZPIk KyylfbCa5AML1Hnc7mJmjYtEdBQcOIQZvXFiXVwqiMDTRuPHI9+vFd9ENmMcwNfH75n2hmVSxkV rho0QUg2EmW3XZlO6G6SSTFCyCQLFNbxdu8K14Q6PINcz X-Received: by 2002:a05:6402:6d5:: with SMTP id n21mr3574001edy.82.1588964545609; Fri, 08 May 2020 12:02:25 -0700 (PDT) X-Google-Smtp-Source: APiQypL+It7P9ir85DDzToWoA7YkY+2Z8BcQsFBl1nhtQZIU3wFa15GhLaAD9J4WEPKApGNJ2gMQId51G5ozqQpimjE= X-Received: by 2002:a05:6402:6d5:: with SMTP id n21mr3573982edy.82.1588964545399; Fri, 08 May 2020 12:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20200507215946.22589-1-gpiccoli@canonical.com> <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org> In-Reply-To: From: Guilherme Piccoli Date: Fri, 8 May 2020 16:01:48 -0300 Message-ID: Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl To: David Rientjes Cc: "Guilherme G. Piccoli" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gavin Guo , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 8, 2020 at 3:31 PM David Rientjes wrote: > It doesn't make sense because it's only being done here for the entire > system, there are also per-node sysfs triggers so you could do something > like iterate over the nodemask of all nodes with memory and trigger > compaction manually and then nothing is emitted to the kernel log. > > There is new statsfs support that Red Hat is proposing that can be used > for things like this. It currently only supports KVM statistics but > adding MM statistics is something that would be a natural extension and > avoids polluting both the kernel log and /proc/vmstat. Thanks for the review. Is this what you're talking about [0] ? Very interesting! Also, I agree about the per-node compaction, it's a good point. But at the same time, having the information on the number of manual compaction triggered is interesting, at least for some users. What if we add that as a per-node stat in zoneinfo? Cheers, Guilherme [0] lore.kernel.org/kvm/20200427141816.16703-1-eesposit@redhat.com