From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BCEC3F68F for ; Fri, 14 Feb 2020 20:51:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B2CC2467D for ; Fri, 14 Feb 2020 20:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XC8kv3Wy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B2CC2467D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDB006B0692; Fri, 14 Feb 2020 15:51:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8A7F6B0693; Fri, 14 Feb 2020 15:51:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC63A6B0694; Fri, 14 Feb 2020 15:51:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 9471A6B0692 for ; Fri, 14 Feb 2020 15:51:46 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2C14A181AEF1A for ; Fri, 14 Feb 2020 20:51:46 +0000 (UTC) X-FDA: 76489929012.23.hen64_49984bc281a03 X-HE-Tag: hen64_49984bc281a03 X-Filterd-Recvd-Size: 6289 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 20:51:45 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id l9so10709684oii.5 for ; Fri, 14 Feb 2020 12:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OUZEy9409pppSXljzrVzSPjPdAQw80MGvX16nfBY0dg=; b=XC8kv3Wy0OyQoREJOWp1L8cEyQ1FThdUzVe8SxPcm6z+yNRZQ+w+96qmHNRFnE0zFg 0hrWiuwrQwnBJGouFTTXBqkYyEhKJxCYJDtYNeEe9OWB3N1pVH0I00UjWuZYf2/Znysx SPzGijZ1p4bQOVDd742sL44fHmIGY83rZEZ2IxU9hePz7S6GslxhIsa+CXggRmpc3fmn /IDtI1izIrcvu5l6OVgLMW7UONPNSOyuf+GFqyD3aH8X8c4RM4ZrT35d2x1EPfZD/4g4 KCBAVALHP9sq7Szy9JydAPABAeA6ts9S2QwivSYQFWXMO/vdM6Vhmxc63Y0/zub5qTZN 5B0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OUZEy9409pppSXljzrVzSPjPdAQw80MGvX16nfBY0dg=; b=ISUgJCQtPMter0B8wMPTH6y4qvxjdbv2lWnjsHzgjEVdLO8QauWah86Q25EAfmyrDe wiPNlTI7R0ikjOCW+QwgvytbhGOhZUS37O3xvtSlg/8enpWykzw7NhoaJ6ywXi6DGjTQ 8JN71GU6ZQvxiUIGBLfn+XV4I1K7XTadFsXXbOLmJ9Dnj4gwBYUZwwm6qYWVEuFGV4jL D7MOMStSxzPUAC+kBRO+vP9JW6qTMKjWbEzs/CLCdZ96Mega3VQzkSvHss0r+2sLpfsW KRzExYDJuRf4hPs7MAMwscb1DJ9HFFH43qcdmqLyMgVO0uVlHqqDlMtC/NovaxXVHHi9 M3TQ== X-Gm-Message-State: APjAAAVM9HwWMrnQKtUUVkO15lMtQ8IKC4jR/5/Swzd85Q58JAnF1avV 48EQysXUuVBk2scCBBO/5sudxK38XCLsAKnmS08HbA== X-Google-Smtp-Source: APXvYqzu3C9V7D+AKDrsqCeye+pwVxWPDK+1pbaapoGpynmu2dpDODFT4oXrbdidRtdJXmKi1nMiF5ljl7HP+schbaM= X-Received: by 2002:a54:4086:: with SMTP id i6mr3197997oii.65.1581713504693; Fri, 14 Feb 2020 12:51:44 -0800 (PST) MIME-Version: 1.0 References: <20200214062647.A2Mb_X-mP%akpm@linux-foundation.org> <8e1e8f6e-0da1-e9e0-fa1b-bfd792256604@infradead.org> <7ff9e944-1c6c-f7c1-d812-e12817c7a317@oracle.com> In-Reply-To: <7ff9e944-1c6c-f7c1-d812-e12817c7a317@oracle.com> From: Mina Almasry Date: Fri, 14 Feb 2020 12:51:33 -0800 Message-ID: Subject: Re: mmotm 2020-02-13-22-26 uploaded (mm/hugetlb.c) To: Mike Kravetz Cc: Randy Dunlap , Andrew Morton , broonie@kernel.org, "open list:FILESYSTEMS (VFS and infrastructure)" , open list , linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 9:18 AM Mike Kravetz wrot= e: > > + Mina > > Andrew, you might want to remove those hugetlb cgroup patches from mmotm > as they are not yet fully reviewed and have some build issues. > > -- > Mike Kravetz Up to you guys but I just sent you a patch ("hugetlb: fix CONFIG_CGROUP_HUGETLB ifdefs") that should fix this build issue. > > On 2/14/20 8:29 AM, Randy Dunlap wrote: > > On 2/13/20 10:26 PM, Andrew Morton wrote: > >> The mm-of-the-moment snapshot 2020-02-13-22-26 has been uploaded to > >> > >> http://www.ozlabs.org/~akpm/mmotm/ > >> > >> mmotm-readme.txt says > >> > >> README for mm-of-the-moment: > >> > >> http://www.ozlabs.org/~akpm/mmotm/ > >> > >> This is a snapshot of my -mm patch queue. Uploaded at random hopefull= y > >> more than once a week. > >> > > > > on x86_64: > > > > CC mm/hugetlb.o > > In file included from ../include/linux/kernel.h:15:0, > > from ../include/linux/list.h:9, > > from ../mm/hugetlb.c:6: > > ../mm/hugetlb.c: In function =E2=80=98dump_resv_map=E2=80=99: > > ../mm/hugetlb.c:301:30: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98reservation_counter=E2=80=99 > > rg->from, rg->to, rg->reservation_counter, rg->css); > > ^ > > ../include/linux/printk.h:304:33: note: in definition of macro =E2=80= =98pr_err=E2=80=99 > > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > > ^~~~~~~~~~~ > > ../mm/hugetlb.c:301:55: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98css=E2=80=99 > > rg->from, rg->to, rg->reservation_counter, rg->css); > > ^ > > ../include/linux/printk.h:304:33: note: in definition of macro =E2=80= =98pr_err=E2=80=99 > > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > > ^~~~~~~~~~~ > > ../mm/hugetlb.c: In function =E2=80=98check_coalesce_bug=E2=80=99: > > ../mm/hugetlb.c:320:10: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98reservation_counter=E2=80=99 > > if (nrg->reservation_counter && nrg->from =3D=3D rg->to && > > ^~ > > ../mm/hugetlb.c:321:10: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98reservation_counter=E2=80=99 > > nrg->reservation_counter =3D=3D rg->reservation_counter && > > ^~ > > ../mm/hugetlb.c:321:37: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98reservation_counter=E2=80=99 > > nrg->reservation_counter =3D=3D rg->reservation_counter && > > ^~ > > ../mm/hugetlb.c:322:10: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98css=E2=80=99 > > nrg->css =3D=3D rg->css) { > > ^~ > > ../mm/hugetlb.c:322:21: error: =E2=80=98struct file_region=E2=80=99 has= no member named =E2=80=98css=E2=80=99 > > nrg->css =3D=3D rg->css) { > > ^~ > > > > > > Full randconfig file is attached. > >