From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B09C11D1C for ; Thu, 20 Feb 2020 19:23:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29B69208C4 for ; Thu, 20 Feb 2020 19:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aTmzlFn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29B69208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A24DA6B0005; Thu, 20 Feb 2020 14:23:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D57F6B0006; Thu, 20 Feb 2020 14:23:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 912186B0007; Thu, 20 Feb 2020 14:23:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 79A636B0005 for ; Thu, 20 Feb 2020 14:23:11 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 37AEF824556B for ; Thu, 20 Feb 2020 19:23:11 +0000 (UTC) X-FDA: 76511478582.03.blow16_55f7df0910b1e X-HE-Tag: blow16_55f7df0910b1e X-Filterd-Recvd-Size: 5087 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 19:23:10 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id j20so4773286otq.3 for ; Thu, 20 Feb 2020 11:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bk1eIitMT2MS22kRJrkHf2a6nr5vMQhVA+AkCVP3xms=; b=aTmzlFn5tqMffO4aaSdqSmOjwnlwPlhLBMDWmHM5hEgVohGoR95LIESWPin+FgU3m5 6SBKmIyXfz3mR7ZJGUztrCkEqttjywHypYPY01n74LbVdLtnW3lI3mGg/tCdRKylIrWc Jq7asmZQKCD4pm93CxVIrFT9tn3nfGJqSSm8Vsd6HIo/Kcxe7LRKiOXtJ1R+KmDSgYri yOJUHQv1/vVwu32bZ3WZIRFgjHFVUSuwrRUtJOBVFSUsAgNS/5PGnC2AW02w3iZZp4zg Ia0U7nlOur/8FVS0Sgvy3hruRsr6xz+P5Rcb6cHozsula5vu8Q6sy6WkorjtHYEKafsR OD5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bk1eIitMT2MS22kRJrkHf2a6nr5vMQhVA+AkCVP3xms=; b=ZHjkXe0eTUm52SefVouHNENC+zwGwYAn68I/kzUZC1FlOJL5U/CWuadxj3tcJOJZpM yGRFHeXufp1n/W9RBGrBFFRZgTe2BtlkuhEzU+Pf5dihluqB5UhUJWaU5LfLfcJsy8mO HIKcJF3x0oo2EV5stLdJHyj65Kc5YlMPZtszeHaDF6B7sDXimEMeidABeWD408hQAqYE hUQ1xFaQtZ7pFQe+tUqQGf76vq14eRgcD1h829TV7i/XR0wYEXyLvRdw8jkgkSBwSZ9I hdtnCK1Vb1MbcYvf13mbzqokjyWuFjoVuQ7CrZTGoJP1Km70t9j5LL8u74RCqwjOqZUY ckZw== X-Gm-Message-State: APjAAAUm5zjy0vQH8FI2md3n7zCvg9nsQS2TYp4sKnHbezV4k+lF9FHn yYw7GjKEdc921j28VUTLUUwtirckG52FAVrsNkzbFA== X-Google-Smtp-Source: APXvYqzc0r7mnwBlUc3tSqHO71Kmj09WeY278uUEiCztDiRqODK1P9Hy8XAqcMq8l4Nh1mPh3JVbkAAfzAHEF3HNj0E= X-Received: by 2002:a9d:7b4e:: with SMTP id f14mr24990667oto.355.1582226589659; Thu, 20 Feb 2020 11:23:09 -0800 (PST) MIME-Version: 1.0 References: <20200211213128.73302-1-almasrymina@google.com> <20200211151906.637d1703e4756066583b89da@linux-foundation.org> <20200219130648.83e6810848774c6fd649c445@linux-foundation.org> In-Reply-To: <20200219130648.83e6810848774c6fd649c445@linux-foundation.org> From: Mina Almasry Date: Thu, 20 Feb 2020 11:22:58 -0800 Message-ID: Subject: Re: [PATCH v12 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter To: Andrew Morton Cc: Mike Kravetz , shuah , David Rientjes , Shakeel Butt , Greg Thelen , open list , Linux-MM , linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000040, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 19, 2020 at 1:06 PM Andrew Morton wrote: > > On Wed, 19 Feb 2020 11:05:41 -0800 Mina Almasry wrote: > > > On Tue, Feb 11, 2020 at 3:19 PM Andrew Morton wrote: > > > > > > On Tue, 11 Feb 2020 13:31:20 -0800 Mina Almasry wrote: > > > > > > > These counters will track hugetlb reservations rather than hugetlb > > > > memory faulted in. This patch only adds the counter, following patches > > > > add the charging and uncharging of the counter. > > > > > > We're still pretty thin on review here, but as it's v12 and Mike > > > appears to be signed up to look at this work, I'll add them to -next to > > > help move things forward. > > > > > > > Hi Andrew, > > > > Since the patches were merged into -next there have been build fixes > > and test fixes and some review comments. Would you like me to submit > > *new* patches to address these, or would you like me to squash the > > fixes into my existing patch series and submit another iteration of > > the patch series? > > What you did worked OK ;) > > Please check the end result next time I release a kernel. Thanks Andrew! Things definitely moved along after the patchseries got into -next :D By my count I think all my patches outside of the tests patch have been acked or reviewed. When you have a chance I have a couple of questions: 1. For the non-tests patch, anything pending on those preventing eventual submission to linus's tree? 2. For the tests patch, I only have a Tested-by from Sandipan. Is that good enough? If the worst comes to worst and I don't get a review on that patch I would rather (if possible) that 'tests' patch can be dropped while I nag folks for a review, rather than block submission of the entire patch series. I ask because it's been out for review for some time and it's the one I got least discussion on so I'm not sure I'll have a review by the time it's needed. Thanks again!