From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED47C43334 for ; Tue, 28 Jun 2022 20:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B05AE6B0071; Tue, 28 Jun 2022 16:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5C96B0072; Tue, 28 Jun 2022 16:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A4E78E0001; Tue, 28 Jun 2022 16:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8BE326B0071 for ; Tue, 28 Jun 2022 16:04:09 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 60A91823AA for ; Tue, 28 Jun 2022 20:04:09 +0000 (UTC) X-FDA: 79628721018.31.4B32676 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by imf14.hostedemail.com (Postfix) with ESMTP id CAD80100031 for ; Tue, 28 Jun 2022 20:04:08 +0000 (UTC) Received: by mail-vk1-f170.google.com with SMTP id 37so2615947vkl.7 for ; Tue, 28 Jun 2022 13:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p/B/lKMrNzso4spSPSsCwZNEn4kBXQBTjSLYuB7ZnRI=; b=mxjGCIOfoAmyxfccoTVGTAkTulE4wTRYdtQ0NYkKSucODYFSn4CXTYOLJsAq9ElhQv uunT5HmitaiA9fw9pTRw0VGQqrXPDlrqRAWNugtfmQXGziYg9gYeZs/TcsE04j56wCa2 DqZcs9mpLd//uRQnfjfJT6O8MfdNpyP0L0YeDVwJO3wKKgrFDZG38eg5ER9ruT/SoC8B YU6irY89WDJqBvR5ysy4PjbUMhRh4gb7q3K/6V76QdXMaSpuVoA2r7ArJDwTANaVswum V1GRSDLx3CpAHnRP+ZMBe1GL/5GRQWwAOPU91cU+NXDLLFoN0yN9rY2XvKzXKfJJ/w8b sxvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p/B/lKMrNzso4spSPSsCwZNEn4kBXQBTjSLYuB7ZnRI=; b=MAQEY1x5PAmSizl44acanh2q3trJb0gXPdMX2TIULqrCAwy6I/MN0Alr4anGLXJxps NqetUpgvFu9IJIAvj4fKGNVcz739gUKrL41K1l4nMWM1WRk8WHGAcp0CMLFMH29aVO34 M/w8SQQsR4Vzn1AaTEr3evxvmh83LTUPcJsgl0oXtMjgjHRhIdS7RUMR6zlupB0EK1X1 oLWrj9yT8nDRVNA3jy7Z+xFzRQdU162qTpsXa6Ag7cWUvZkYmxnVOIDkfMdyddGwat9w od8wCLzzTufH3G8LZbx4hGvL1BTrRxQoquagH8ODvbgwm8xsMFkzhYTV6BOPjNlNeHGR ErtQ== X-Gm-Message-State: AJIora8ltthJRKZvR3OweT2v67wqf5jFTqzZsUVkV6fxGQtN2WVq25j4 LRFfnvy24fkCSHasUWpNahWOY2x2cNdlaBdtKFidMQ== X-Google-Smtp-Source: AGRyM1vPxcUSK6LIJdPh1va54HjoTAEorgGghWfusEMooGmXSA3C+Yy0DGKnB8TyAI3/Iaynh2pv8HFkBaKtY3sFGr8= X-Received: by 2002:a1f:aac7:0:b0:35e:1c45:def with SMTP id t190-20020a1faac7000000b0035e1c450defmr2577667vke.35.1656446647926; Tue, 28 Jun 2022 13:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20220624173656.2033256-1-jthoughton@google.com> <20220624173656.2033256-6-jthoughton@google.com> In-Reply-To: From: Mina Almasry Date: Tue, 28 Jun 2022 13:03:55 -0700 Message-ID: Subject: Re: [RFC PATCH 05/26] hugetlb: add CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING To: "manish.mishra" Cc: James Houghton , Mike Kravetz , Muchun Song , Peter Xu , David Hildenbrand , David Rientjes , Axel Rasmussen , Jue Wang , "Dr . David Alan Gilbert" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656446649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p/B/lKMrNzso4spSPSsCwZNEn4kBXQBTjSLYuB7ZnRI=; b=GiDCPjZDXFE1T4sOtKDvOkcFEz8WE5aHVAVWGg9hLpSW5i1ChJj6UBOja4XkbjxNdi2TxI A4enJeTEngkJOo9gR/pfAz2pq70RhLSzcXs0Db4aGkM+Nf8YXUWMa2VYBVrj9lqxTOQdt+ oaLYgftyDYHodTf7/lZyF9RVL9yyLNc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mxjGCIOf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=almasrymina@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656446649; a=rsa-sha256; cv=none; b=LbCW7sVPeiRa7NOpX965bL5GntlEqabNPoLANVbYYbrDTxR091evYTZibTIXf1QgKA0BLH S0erggJ1P3tYIbrO2hN6OSQAmvsS9UU0uyOY8h0D/X1YYxa0TiCeMh8FXfUcAm11HJEhkO JZX8xe6QlSi0Dbje8fZh1gffTAYemU4= X-Rspamd-Queue-Id: CAD80100031 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mxjGCIOf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of almasrymina@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=almasrymina@google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tu9rfxyduhh8c995mobrk4d8re6fxkab X-HE-Tag: 1656446648-337759 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 27, 2022 at 5:29 AM manish.mishra wrote: > > > On 24/06/22 11:06 pm, James Houghton wrote: > > This adds the Kconfig to enable or disable high-granularity mapping. It > > is enabled by default for architectures that use > > ARCH_WANT_GENERAL_HUGETLB. > > > > There is also an arch-specific config ARCH_HAS_SPECIAL_HUGETLB_HGM which > > controls whether or not the architecture has been updated to support > > HGM if it doesn't use general HugeTLB. > > > > Signed-off-by: James Houghton > reviewed-by:manish.mishra@nutanix.com Mostly minor nits, Reviewed-by: Mina Almasry > > --- > > fs/Kconfig | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/fs/Kconfig b/fs/Kconfig > > index 5976eb33535f..d76c7d812656 100644 > > --- a/fs/Kconfig > > +++ b/fs/Kconfig > > @@ -268,6 +268,13 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > > to enable optimizing vmemmap pages of HugeTLB by default. It can then > > be disabled on the command line via hugetlb_free_vmemmap=off. > > > > +config ARCH_HAS_SPECIAL_HUGETLB_HGM Nit: would have preferred just ARCH_HAS_HUGETLB_HGM, as ARCH implies arch-specific. > > + bool > > + > > +config HUGETLB_HIGH_GRANULARITY_MAPPING > > + def_bool ARCH_WANT_GENERAL_HUGETLB || ARCH_HAS_SPECIAL_HUGETLB_HGM Nit: would have preferred to go with either HGM _or_ HIGH_GRANULARITY_MAPPING (or whatever new name comes up), rather than both, for consistency's sake. > > + depends on HUGETLB_PAGE > > + > > config MEMFD_CREATE > > def_bool TMPFS || HUGETLBFS > >