From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6B4C56201 for ; Tue, 10 Nov 2020 18:58:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E67E220780 for ; Tue, 10 Nov 2020 18:58:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vhj+Cj3Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E67E220780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C3F96B0036; Tue, 10 Nov 2020 13:58:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 675E26B005C; Tue, 10 Nov 2020 13:58:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B30F6B005D; Tue, 10 Nov 2020 13:58:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 2F4686B0036 for ; Tue, 10 Nov 2020 13:58:44 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CA5CC180AD801 for ; Tue, 10 Nov 2020 18:58:43 +0000 (UTC) X-FDA: 77469420126.16.bears02_3e0f32f272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 9C8B1100E6917 for ; Tue, 10 Nov 2020 18:58:43 +0000 (UTC) X-HE-Tag: bears02_3e0f32f272f7 X-Filterd-Recvd-Size: 3760 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:58:43 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id za3so19154558ejb.5 for ; Tue, 10 Nov 2020 10:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xY+OYzm36HZ2hizRqFw7LNCZnSuEE495c5e+Ma5DQ2c=; b=Vhj+Cj3Q1ccxlLI6gcrPUEJwiIBfusiKaYvL7ob4w/12LPgA6zNtZ5pjxrYV9aeEAk W1zmVui1It7Km0JFET7bFmNdb0PKdc6sFCfEDiF5OlDbln+C1U7a4bS9PIuLO8TT3aLi Yt16OOHKvIVQ/rxDEM2sOieKmo+PDp8ZZNjjQWiZWOMx6OPrhRa4eefqDwzjRjIuhIER V7VURrtzQVUtioPnjMfH0sb4Ce6hpl9vDtvqlI8QdTOSt8scL+EOlEbmiSvYT9BO3Wyg JrnfGWN/p+Ba8KhlLYLQynf/RAFKjBkmn8l8BAEZsPIrVXEmiE/Q+KXdnDoagWaFoiFp WXqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xY+OYzm36HZ2hizRqFw7LNCZnSuEE495c5e+Ma5DQ2c=; b=Ud7zexMb2TKVNfhqMyoeKJy0pz+Y1N2mp8V25d+pOIFiFLE640IbevYD8/0uWHhwTT TDh9KAaaahGq/04SLRsDWOkQzH/9OajgSscQl3NSCsczjarqbCsqvyOUi5+Y6tAPJX1i DGyiJBgAVcayAVGI0RZpAoXtscH9BsFcR7TiFU1r5fpFcAgdaKhyNW5m/UbxSJA8S1tD 2ZwGTExhKccCw2v6QkBMzl+i6pouNLu+4IDC+a2i9TXKm9AQ3yo+ZxTezF/s8OX+us9u /r8v5FOgJPQkdi/68IqA9CyzBvws2e0AMW5TsLICu9S8yBdeoFSAKGlIx5GKx4SfFRZ/ Na+w== X-Gm-Message-State: AOAM532Hj4q17Rh2/NERKqUpe5c/os0PZ+6qaXf25CKk9/2ZKkzaKEyA OMp9PT16pLpwBBP4xJEC+KNmxYPRIEtyFNWFGgI= X-Google-Smtp-Source: ABdhPJxwDJhG09qcVrcjklXnfM/k9mQpcKMuMSWu2ZjJvkfUOmfZW+dNKN4so2UwpPmnYJYYSHiJ1Ue3oFsUeG2s1X0= X-Received: by 2002:a17:906:814:: with SMTP id e20mr21018873ejd.514.1605034720962; Tue, 10 Nov 2020 10:58:40 -0800 (PST) MIME-Version: 1.0 References: <20201110181250.264394-1-shy828301@gmail.com> <20201110181250.264394-4-shy828301@gmail.com> <20201110181636.GJ17076@casper.infradead.org> In-Reply-To: <20201110181636.GJ17076@casper.infradead.org> From: Yang Shi Date: Tue, 10 Nov 2020 10:58:29 -0800 Message-ID: Subject: Re: [v2 PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing To: Matthew Wilcox Cc: Michal Hocko , Zi Yan , Song Liu , Mel Gorman , Jan Kara , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:16 AM Matthew Wilcox wrote: > > On Tue, Nov 10, 2020 at 10:12:48AM -0800, Yang Shi wrote: > > @@ -2142,6 +2151,10 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm, > > int page_lru = page_is_file_lru(page); > > unsigned long start = address & HPAGE_PMD_MASK; > > > > + if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && > > + is_shared_exec_page(vma, page)) > > + goto out; > > Why include the IS_ENABLED() check? Once the ~50 patches I have pending > go in, shared executable THPs can exist without this option. And can't > we have executables on tmpfs today without this option too? Aha, yes, thanks for reminding. I had the patches baked in my tree before your patches were posted. We could have executables on tmpfs w/o that config. Will remove it. Thanks.