From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DB0C433E0 for ; Mon, 11 Jan 2021 21:21:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2338822D00 for ; Mon, 11 Jan 2021 21:21:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2338822D00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4230E8D0054; Mon, 11 Jan 2021 16:21:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D3C58D0051; Mon, 11 Jan 2021 16:21:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E8CE8D0054; Mon, 11 Jan 2021 16:21:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 188DD8D0051 for ; Mon, 11 Jan 2021 16:21:27 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D413E8245571 for ; Mon, 11 Jan 2021 21:21:26 +0000 (UTC) X-FDA: 77694765372.20.fold38_590c25227510 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id B46ED180C07A3 for ; Mon, 11 Jan 2021 21:21:26 +0000 (UTC) X-HE-Tag: fold38_590c25227510 X-Filterd-Recvd-Size: 5436 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 21:21:26 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id x16so430412ejj.7 for ; Mon, 11 Jan 2021 13:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+AfvfCqsfaWkYAg6+USDuxUF1iByJwAHFmuzpuqID3o=; b=JNXA4eh+XvS7VbDRQow9rDSG63sK6s8viFtRvPQKLPQc5znp1NdUI+ZUf2P+tJOUmN msc82S/JFuJGrRoM96c06ABMd8qdGoW8j1IEzQwCVlvHzQ2imnfCuaccwTzaM35r4yoC 5ctGnMEryb+INkdAhzu1jnFQyEdFzL61rGkEb8VgJhPqyb/vETkhRofHD5JvBPLdcmwG j2JTXkJXSUQe4tun8gWbG4BaJx0oaPce60HdcO4m20+mGHVYG4kNbNbYYspvtF5AVi+w Zf2O2+H+VDOqksZzd2mznPvSOVOObBMI1J3ePh8ZKuDRL33S3wmmaqGxZ8ADVTGHjlO/ uJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+AfvfCqsfaWkYAg6+USDuxUF1iByJwAHFmuzpuqID3o=; b=YOdDnb2kPMrgsS75568hRCTTGzjuSXZ7YdZxIMMwI/2Xt67dIBlyhvTxsUhbRz01+Y FtDhtanFzbQ2bXa6tHxaeKw3o/aB9VDfjS/0XOK9KdtWb/LEUoS5uhee3DCFPlr9kMKL JfphWHX9GtPEXxltLBq3YzJtCFaeP4Aro4T89XbW21Hg/Sb7X3v5ubhZB89esfWsYMtM 8c0ciDb41+PRQNfWFz8GtiPwI+P+WdBzNOfCGmlGcGsxRYXf4uEp9Duhil2oDQjDPKi+ LpMtYJZm+FXTtFLjUaJnplH4ZfgGIQiLVSv56fMN1hv+ogJrGOwBwPmY6Iswc/JejhQ1 1YiA== X-Gm-Message-State: AOAM531QQrFjj8z5vb4gdhI9II2Ke/73EQgHgxKHmEuWcemA0euRAR0q Ki5vuZmjNgviRdZBXXiRhvEGgPBqLToIxXfsiEY= X-Google-Smtp-Source: ABdhPJyFOrpHE8t0ZJOiqnyBKrLl6Kg5x7EcGRv1wS/EVN/VXJyRmG8bui3pJBKEPi/eo+tz32T94OYlqAGygy6os8k= X-Received: by 2002:a17:906:1a4e:: with SMTP id j14mr879710ejf.507.1610400084987; Mon, 11 Jan 2021 13:21:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Mon, 11 Jan 2021 13:21:12 -0800 Message-ID: Subject: Re: [PATCH] mm: vmscan: support equal reclaim for anon and file pages To: Sudarshan Rajagopalan Cc: Linux MM , Linux Kernel Mailing List , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 12:59 PM Sudarshan Rajagopalan wrote: > > When performing memory reclaim support treating anonymous and > file backed pages equally. > Swapping anonymous pages out to memory can be efficient enough > to justify treating anonymous and file backed pages equally. > > Signed-off-by: Sudarshan Rajagopalan > Cc: Andrew Morton > --- > mm/vmscan.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 257cba79a96d..ec7585e0d5f5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -169,6 +169,8 @@ struct scan_control { > */ > int vm_swappiness = 60; > > +bool balance_anon_file_reclaim = false; I think the same effect could be achieved by adjusting swappiness. The "swappiness" can go to 200 now. Please check the document at Documentation/admin-guide/sysctl/vm.rst, it says: This control is used to define the rough relative IO cost of swapping and filesystem paging, as a value between 0 and 200. At 100, the VM assumes equal IO cost and will thus apply memory pressure to the page cache and swap-backed pages equally; lower values signify more expensive swap IO, higher values indicates cheaper. > + > static void set_task_reclaim_state(struct task_struct *task, > struct reclaim_state *rs) > { > @@ -201,6 +203,13 @@ static DECLARE_RWSEM(shrinker_rwsem); > static DEFINE_IDR(shrinker_idr); > static int shrinker_nr_max; > > +static int __init cmdline_parse_balance_reclaim(char *p) > +{ > + balance_anon_file_reclaim = true; > + return 0; > +} > +early_param("balance_reclaim", cmdline_parse_balance_reclaim); > + > static int prealloc_memcg_shrinker(struct shrinker *shrinker) > { > int id, ret = -ENOMEM; > @@ -2291,9 +2300,11 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > > /* > * If there is enough inactive page cache, we do not reclaim > - * anything from the anonymous working right now. > + * anything from the anonymous working right now. But when balancing > + * anon and page cache files for reclaim, allow swapping of anon pages > + * even if there are a number of inactive file cache pages. > */ > - if (sc->cache_trim_mode) { > + if (!balance_anon_file_reclaim && sc->cache_trim_mode) { > scan_balance = SCAN_FILE; > goto out; > } > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > >