From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B74C433DB for ; Fri, 29 Jan 2021 17:34:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2950564DD8 for ; Fri, 29 Jan 2021 17:34:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2950564DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A14308D0006; Fri, 29 Jan 2021 12:34:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EB268D0001; Fri, 29 Jan 2021 12:34:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 928F88D0006; Fri, 29 Jan 2021 12:34:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 7C7118D0001 for ; Fri, 29 Jan 2021 12:34:43 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4A5F0181AEF30 for ; Fri, 29 Jan 2021 17:34:43 +0000 (UTC) X-FDA: 77759512446.23.hall82_22013be275aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 2351E37606 for ; Fri, 29 Jan 2021 17:34:43 +0000 (UTC) X-HE-Tag: hall82_22013be275aa X-Filterd-Recvd-Size: 4547 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 Jan 2021 17:34:42 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id z22so11457771edb.9 for ; Fri, 29 Jan 2021 09:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Omw5Ys8o3vFL1EfQiRnB9qvp9jJo/sSZIBuGwWy4rQw=; b=P0udmoE4cNOfopGGDdUneugQsQ/x1aX+JDuhmR0HowCh/+jrrZGT2l7oaPkNT9lnYH bzg6zxVIcGudkcFcuY5TF5P8XLde+LRySzA5DOaAtkYCU1l6IRJdbmObU7g0RxyCrARy QbdDYAY5Ky2ij5Vy+Ge8Du2yFvoXqGMXowlM8E2DAfcD6u2z0esPkAAoiNZusd43i9zd K5kiUvDV+xHSZpYgIXgilfjFPZHdbBau5ttK3/s/KShoF+EAjmddHnpaZGWH7uO7ccfc hsnURnsttDRemCYnJQR9/bmiMNZCpbj1I76rNb5p1UYnKgqXkru9zjBRkBQ2okGMAkiH RO7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Omw5Ys8o3vFL1EfQiRnB9qvp9jJo/sSZIBuGwWy4rQw=; b=ucID2OFoo8v8dVzOLWiAknO+2ACP35tuQmvA08CAtzctrD8f8kaU9rvFfGih9c6qCX 9doR5v22P16CxO32PONHRpjaYkf344a3UEQj3b1zOgwo2MgXPyOjxvnhrWTKQaTpe8Ns pH5+PKBJc3vdG/IOE6YM6XmgQcitctal3xMa1DPaAOSvp7MruBYTtkro+kcfY0ukkNsF OlNgNA5sR9fxdZimej8zGrDhFqgCA0cIWmqAFQ3AjfsQlAutwo79bFiFVezkZVgVpd9d H50u8PZvPn+G8tAIh63FcDI5tuhfsR9O6L2GbMOzjXJAIcxsAV/KS3h7YJloGy5HGUkI 3k0A== X-Gm-Message-State: AOAM532J1y2K/bycgFVq84FrTbm4zVWj4HsTZARwANoNaSRzTMcnZ6xc Skiq6psaPFhtIyAxHyGM9am/bcG+0cVfw/fu508= X-Google-Smtp-Source: ABdhPJzJ9q7GFSTWtDLwX7jFAbH8oqLzoNJhAF7eKIMW47rYuGUgnjAMcsfVYtTT854WgHhPgyCIDk2+eJs4bi/x/ss= X-Received: by 2002:a50:e8c1:: with SMTP id l1mr6358721edn.168.1611941681756; Fri, 29 Jan 2021 09:34:41 -0800 (PST) MIME-Version: 1.0 References: <20210127233345.339910-1-shy828301@gmail.com> <20210127233345.339910-10-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Fri, 29 Jan 2021 09:34:29 -0800 Message-ID: Subject: Re: [v5 PATCH 09/11] mm: vmscan: don't need allocate shrinker->nr_deferred for memcg aware shrinkers To: Vlastimil Babka Cc: Roman Gushchin , Kirill Tkhai , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 29, 2021 at 7:40 AM Vlastimil Babka wrote: > > On 1/28/21 12:33 AM, Yang Shi wrote: > > Now nr_deferred is available on per memcg level for memcg aware shrinkers, so don't need > > allocate shrinker->nr_deferred for such shrinkers anymore. > > > > The prealloc_memcg_shrinker() would return -ENOSYS if !CONFIG_MEMCG or memcg is disabled > > by kernel command line, then shrinker's SHRINKER_MEMCG_AWARE flag would be cleared. > > This makes the implementation of this patch simpler. > > > > Signed-off-by: Yang Shi > > Acked-by: Vlastimil Babka > > > @@ -525,8 +528,20 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone > > */ > > int prealloc_shrinker(struct shrinker *shrinker) > > { > > - unsigned int size = sizeof(*shrinker->nr_deferred); > > + unsigned int size; > > + int err; > > + > > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) { > > + err = prealloc_memcg_shrinker(shrinker); > > + if (!err) > > + return 0; > > Nit: this err == 0 case is covered below: Aha, thanks. Will fix in v6. > > > + if (err != -ENOSYS) > > + return err; > > + > > + shrinker->flags &= ~SHRINKER_MEMCG_AWARE; > > + } > > > > + size = sizeof(*shrinker->nr_deferred); > > if (shrinker->flags & SHRINKER_NUMA_AWARE) > > size *= nr_node_ids; > >